<p>osmith <strong>merged</strong> this change.</p><p><a href="https://gerrit.osmocom.org/11041">View Change</a></p><div style="white-space:pre-wrap">Approvals:
Harald Welte: Looks good to me, approved
osmith: Verified
</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">debian-repo-install-test: UNKNOWN in --version?<br><br>With this patch, the debian-repo-install-test script checks if<br>the Osmocom programs as installed from the Debian repository have<br>"UNKNOWN" in their --version output.<br><br>Relates: OS#3555<br>Change-Id: I46f18dc86d3e257c772a6db8539027aad26e24a8<br>---<br>M debian-repo-install-test/testdata/repo-install-test.sh<br>1 file changed, 36 insertions(+), 13 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/debian-repo-install-test/testdata/repo-install-test.sh b/debian-repo-install-test/testdata/repo-install-test.sh</span><br><span>index ea1c5fb..3ef88e8 100755</span><br><span>--- a/debian-repo-install-test/testdata/repo-install-test.sh</span><br><span>+++ b/debian-repo-install-test/testdata/repo-install-test.sh</span><br><span>@@ -44,25 +44,48 @@</span><br><span> apt install -y $(cat /data/osmocom_packages.txt)</span><br><span> }</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+test_binaries_version() {</span><br><span style="color: hsl(120, 100%, 40%);">+ # Make sure --version runs and does not output UNKNOWN</span><br><span style="color: hsl(120, 100%, 40%);">+ failed=""</span><br><span style="color: hsl(120, 100%, 40%);">+ for program in $@; do</span><br><span style="color: hsl(120, 100%, 40%);">+ # Make sure it runs at all</span><br><span style="color: hsl(120, 100%, 40%);">+ $program --version</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ # Check for UNKNOWN</span><br><span style="color: hsl(120, 100%, 40%);">+ if $program --version | grep -q UNKNOWN; then</span><br><span style="color: hsl(120, 100%, 40%);">+ failed="$failed $program"</span><br><span style="color: hsl(120, 100%, 40%);">+ echo "ERROR: this program prints UNKNOWN in --version!"</span><br><span style="color: hsl(120, 100%, 40%);">+ fi</span><br><span style="color: hsl(120, 100%, 40%);">+ done</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ if [ -n "$failed" ]; then</span><br><span style="color: hsl(120, 100%, 40%);">+ echo "ERROR: the following program(s) print UNKNOWN in --version:"</span><br><span style="color: hsl(120, 100%, 40%);">+ echo "$failed"</span><br><span style="color: hsl(120, 100%, 40%);">+ return 1</span><br><span style="color: hsl(120, 100%, 40%);">+ fi</span><br><span style="color: hsl(120, 100%, 40%);">+}</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> test_binaries() {</span><br><span> # Make sure the binaries are not broken (run -h or --version)</span><br><span style="color: hsl(0, 100%, 40%);">- osmo-bsc --version</span><br><span style="color: hsl(0, 100%, 40%);">- osmo-bts-trx --version</span><br><span style="color: hsl(0, 100%, 40%);">- osmo-bts-virtual --version</span><br><span style="color: hsl(0, 100%, 40%);">- osmo-gbproxy --version</span><br><span style="color: hsl(0, 100%, 40%);">- osmo-ggsn --version</span><br><span> osmo-gtphub -h</span><br><span style="color: hsl(0, 100%, 40%);">- osmo-hlr --version</span><br><span style="color: hsl(0, 100%, 40%);">- osmo-hlr-db-tool --version</span><br><span style="color: hsl(0, 100%, 40%);">- osmo-hnbgw --version</span><br><span style="color: hsl(0, 100%, 40%);">- osmo-mgw --version</span><br><span style="color: hsl(0, 100%, 40%);">- osmo-msc --version</span><br><span style="color: hsl(0, 100%, 40%);">- osmo-pcu --version</span><br><span style="color: hsl(0, 100%, 40%);">- osmo-sgsn --version</span><br><span> osmo-sip-connector -h</span><br><span style="color: hsl(0, 100%, 40%);">- osmo-stp --version</span><br><span> osmo-trx-uhd -h</span><br><span> osmo-trx-usrp1 -h</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ test_binaries_version \</span><br><span style="color: hsl(120, 100%, 40%);">+ osmo-bsc \</span><br><span style="color: hsl(120, 100%, 40%);">+ osmo-bts-trx \</span><br><span style="color: hsl(120, 100%, 40%);">+ osmo-bts-virtual \</span><br><span style="color: hsl(120, 100%, 40%);">+ osmo-gbproxy \</span><br><span style="color: hsl(120, 100%, 40%);">+ osmo-ggsn \</span><br><span style="color: hsl(120, 100%, 40%);">+ osmo-hlr \</span><br><span style="color: hsl(120, 100%, 40%);">+ osmo-hlr-db-tool \</span><br><span style="color: hsl(120, 100%, 40%);">+ osmo-hnbgw \</span><br><span style="color: hsl(120, 100%, 40%);">+ osmo-mgw \</span><br><span style="color: hsl(120, 100%, 40%);">+ osmo-msc \</span><br><span style="color: hsl(120, 100%, 40%);">+ osmo-pcu \</span><br><span style="color: hsl(120, 100%, 40%);">+ osmo-sgsn \</span><br><span style="color: hsl(120, 100%, 40%);">+ osmo-stp</span><br><span> }</span><br><span> </span><br><span> finish() {</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/11041">change 11041</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/11041"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: docker-playground </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: merged </div>
<div style="display:none"> Gerrit-Change-Id: I46f18dc86d3e257c772a6db8539027aad26e24a8 </div>
<div style="display:none"> Gerrit-Change-Number: 11041 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: osmith <osmith@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Harald Welte <laforge@gnumonks.org> </div>
<div style="display:none"> Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: osmith <osmith@sysmocom.de> </div>