<p>Stefan Sperling has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/11046">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">check for overlong unix socket paths<br><br>In rf_create_socket(), check the result of osmo_strlcpy().<br>This catches overlong and non-NUL-terminated socket paths.<br><br>Change-Id: I4b9ff9146068bf7f53d67c577454f32c02361b86<br>Related: OS#2673<br>---<br>M src/osmo-bsc/bsc_rf_ctrl.c<br>1 file changed, 5 insertions(+), 1 deletion(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/46/11046/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/osmo-bsc/bsc_rf_ctrl.c b/src/osmo-bsc/bsc_rf_ctrl.c</span><br><span>index f4a21b5..ac87fb9 100644</span><br><span>--- a/src/osmo-bsc/bsc_rf_ctrl.c</span><br><span>+++ b/src/osmo-bsc/bsc_rf_ctrl.c</span><br><span>@@ -450,8 +450,12 @@</span><br><span>        }</span><br><span> </span><br><span>        local.sun_family = AF_UNIX;</span><br><span style="color: hsl(0, 100%, 40%);">-     osmo_strlcpy(local.sun_path, path, sizeof(local.sun_path));</span><br><span>  unlink(local.sun_path);</span><br><span style="color: hsl(120, 100%, 40%);">+       if (osmo_strlcpy(local.sun_path, path, sizeof(local.sun_path)) >= sizeof(local.sun_path)) {</span><br><span style="color: hsl(120, 100%, 40%);">+                LOGP(DLINP, LOGL_ERROR, "Socket path exceeds maximum length of %zd bytes: %s\n",</span><br><span style="color: hsl(120, 100%, 40%);">+                 sizeof(local.sun_path), path);</span><br><span style="color: hsl(120, 100%, 40%);">+           return -1;</span><br><span style="color: hsl(120, 100%, 40%);">+    }</span><br><span> </span><br><span>        /* we use the same magic that X11 uses in Xtranssock.c for</span><br><span>    * calculating the proper length of the sockaddr */</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/11046">change 11046</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/11046"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-bsc </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I4b9ff9146068bf7f53d67c577454f32c02361b86 </div>
<div style="display:none"> Gerrit-Change-Number: 11046 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Stefan Sperling <ssperling@sysmocom.de> </div>