<p><a href="https://gerrit.osmocom.org/11048">View Change</a></p><p>1 comment:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.osmocom.org/#/c/11048/1/src/osmobts_sock.cpp">File src/osmobts_sock.cpp:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/#/c/11048/1/src/osmobts_sock.cpp@268">Patch Set #1, Line 268:</a> <code style="font-family:monospace,monospace">       if (osmo_strlcpy(local.sun_path, bts->pcu_sock_path, sizeof(local.sun_path)) >= sizeof(local.sun_path)) {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">I would prefer to see:</p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">  rc = osmo_strlcpy(...);<br>  if (rc) { ... }</pre><p style="white-space: pre-wrap; word-wrap: break-word;">here instead of this long construction.</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.osmocom.org/11048">change 11048</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/11048"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-pcu </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: I825190cbb34d052b797e9fb5208884d6f5992839 </div>
<div style="display:none"> Gerrit-Change-Number: 11048 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Stefan Sperling <ssperling@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder (1000002) </div>
<div style="display:none"> Gerrit-CC: Vadim Yanitskiy <axilirator@gmail.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Thu, 20 Sep 2018 17:25:07 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-HasLabels: No </div>