<p>Harald Welte <strong>merged</strong> this change.</p><p><a href="https://gerrit.osmocom.org/11007">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Jenkins Builder: Verified
  Harald Welte: Looks good to me, approved

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">common/rsl.c: tweak log message in lapdm_rll_tx_cb()<br><br>During the investigation of OS#3559, it was discovered that the<br>log message, which warns that an RSL message was dropped due to<br>inactive logical channel, has incorrect log level - LOGL_INFO.<br><br>This is not informative kind of message, so let's increase the<br>log level, and additionally let's print the hexdump of message<br>and it's length.<br><br>Change-Id: I26eac5e4466c493ffe08dbb89de20f5e1c2bb85d<br>---<br>M src/common/rsl.c<br>1 file changed, 3 insertions(+), 2 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/common/rsl.c b/src/common/rsl.c</span><br><span>index 2aa7f4d..601b1c1 100644</span><br><span>--- a/src/common/rsl.c</span><br><span>+++ b/src/common/rsl.c</span><br><span>@@ -2671,8 +2671,9 @@</span><br><span>     rh = msgb_l2(msg);</span><br><span> </span><br><span>       if (lchan->state != LCHAN_S_ACTIVE) {</span><br><span style="color: hsl(0, 100%, 40%);">-                LOGP(DRSL, LOGL_INFO, "%s(%s) is not active . Dropping message.\n",</span><br><span style="color: hsl(0, 100%, 40%);">-                   gsm_lchan_name(lchan), gsm_lchans_name(lchan->state));</span><br><span style="color: hsl(120, 100%, 40%);">+             LOGP(DRSL, LOGL_ERROR, "%s(%s) is not active. Dropping message (len=%u): %s\n",</span><br><span style="color: hsl(120, 100%, 40%);">+                     gsm_lchan_name(lchan), gsm_lchans_name(lchan->state),</span><br><span style="color: hsl(120, 100%, 40%);">+                      msgb_l2len(msg), msgb_hexdump_l2(msg));</span><br><span>              msgb_free(msg);</span><br><span>              return 0;</span><br><span>    }</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/11007">change 11007</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/11007"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-bts </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: merged </div>
<div style="display:none"> Gerrit-Change-Id: I26eac5e4466c493ffe08dbb89de20f5e1c2bb85d </div>
<div style="display:none"> Gerrit-Change-Number: 11007 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: Vadim Yanitskiy <axilirator@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: Harald Welte <laforge@gnumonks.org> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder (1000002) </div>