<p>lynxis lazus has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/11022">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">gprs_llc: remove the FCS from the msgb by trim'ing the msgb<br><br>After checking the FCS, it's no use. The FCS should also not<br>appear on `hexdump(msgb_l3(MSG), msgb_l3len(MSG))`.<br><br>Change-Id: I27e061ead86395a336b67c7aead93d305a0f2ae8<br>---<br>M src/gprs/gprs_llc.c<br>1 file changed, 3 insertions(+), 1 deletion(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-sgsn refs/changes/22/11022/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/gprs/gprs_llc.c b/src/gprs/gprs_llc.c</span><br><span>index 6c92f83..abbb742 100644</span><br><span>--- a/src/gprs/gprs_llc.c</span><br><span>+++ b/src/gprs/gprs_llc.c</span><br><span>@@ -945,6 +945,9 @@</span><br><span>              LOGP(DLLC, LOGL_INFO, "Dropping frame with invalid FCS\n");</span><br><span>                return -EIO;</span><br><span>         }</span><br><span style="color: hsl(120, 100%, 40%);">+     /* set l3 layer & remove the fcs */</span><br><span style="color: hsl(120, 100%, 40%);">+       msg->l3h = llhp.data;</span><br><span style="color: hsl(120, 100%, 40%);">+      msgb_l3trim(msg, llhp.data_len);</span><br><span> </span><br><span>         /* Update LLE's (BVCI, NSEI) tuple */</span><br><span>    lle->llme->bvci = msgb_bvci(msg);</span><br><span>@@ -960,7 +963,6 @@</span><br><span> </span><br><span>    /* llhp.data is only set when we need to send LL_[UNIT]DATA_IND up */</span><br><span>        if (llhp.cmd == GPRS_LLC_UI && llhp.data && llhp.data_len) {</span><br><span style="color: hsl(0, 100%, 40%);">-            msgb_gmmh(msg) = llhp.data;</span><br><span>          switch (llhp.sapi) {</span><br><span>                 case GPRS_SAPI_GMM:</span><br><span>                  /* send LL_UNITDATA_IND to GMM */</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/11022">change 11022</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/11022"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-sgsn </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I27e061ead86395a336b67c7aead93d305a0f2ae8 </div>
<div style="display:none"> Gerrit-Change-Number: 11022 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: lynxis lazus <lynxis@fe80.eu> </div>