<p>lynxis lazus has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/11019">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">sgsn_libgtp: fix a potential memleak when the GGSN is not reachable<br><br>When a MS does the following<br><br>- MS: GMM Attach Activate<br>- MS: Activate PDP CTX<br>- SGNS: send Request Ctx to GSGSN which does not answer<br>- GMM Detach (MM ctx get freed)<br>- libgtp retrans timeout of the first answer<br>- sgsn_libgtp.c: create_pdp_conf() which ignores this ctx because of emtpy MM ctx<br><br>Change-Id: I4575f7f80f785a62ae3b7f165d236a9dd818aabf<br>---<br>M src/gprs/sgsn_libgtp.c<br>1 file changed, 6 insertions(+), 6 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-sgsn refs/changes/19/11019/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/gprs/sgsn_libgtp.c b/src/gprs/sgsn_libgtp.c</span><br><span>index 7829796..478d402 100644</span><br><span>--- a/src/gprs/sgsn_libgtp.c</span><br><span>+++ b/src/gprs/sgsn_libgtp.c</span><br><span>@@ -390,15 +390,13 @@</span><br><span> static int create_pdp_conf(struct pdp_t *pdp, void *cbp, int cause)</span><br><span> {</span><br><span>     struct sgsn_pdp_ctx *pctx = cbp;</span><br><span style="color: hsl(0, 100%, 40%);">-        uint8_t reject_cause;</span><br><span style="color: hsl(120, 100%, 40%);">+ uint8_t reject_cause = 0;</span><br><span> </span><br><span>        LOGPDPCTXP(LOGL_INFO, pctx, "Received CREATE PDP CTX CONF, cause=%d(%s)\n",</span><br><span>                cause, get_value_string(gtp_cause_strs, cause));</span><br><span> </span><br><span>         if (!pctx->mm) {</span><br><span style="color: hsl(0, 100%, 40%);">-             LOGP(DGPRS, LOGL_INFO,</span><br><span style="color: hsl(0, 100%, 40%);">-               "No MM context, aborting CREATE PDP CTX CONF\n");</span><br><span style="color: hsl(0, 100%, 40%);">-                return -EIO;</span><br><span style="color: hsl(120, 100%, 40%);">+          goto reject;</span><br><span>         }</span><br><span> </span><br><span>        /* Check for cause value if it was really successful */</span><br><span>@@ -452,9 +450,11 @@</span><br><span> </span><br><span>   if (pdp)</span><br><span>             pdp_freepdp(pdp);</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span>  /* Send PDP CTX ACT REJ to MS */</span><br><span style="color: hsl(0, 100%, 40%);">-        gsm48_tx_gsm_act_pdp_rej(pctx->mm, pctx->ti, reject_cause,</span><br><span style="color: hsl(0, 100%, 40%);">-                                        0, NULL);</span><br><span style="color: hsl(120, 100%, 40%);">+     if (pctx->mm)</span><br><span style="color: hsl(120, 100%, 40%);">+              gsm48_tx_gsm_act_pdp_rej(pctx->mm, pctx->ti, reject_cause,</span><br><span style="color: hsl(120, 100%, 40%);">+                                       0, NULL);</span><br><span>   sgsn_pdp_ctx_free(pctx);</span><br><span> </span><br><span>         return EOF;</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/11019">change 11019</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/11019"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-sgsn </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I4575f7f80f785a62ae3b7f165d236a9dd818aabf </div>
<div style="display:none"> Gerrit-Change-Number: 11019 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: lynxis lazus <lynxis@fe80.eu> </div>