<p>dexter has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/10964">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">codec_pref: fix missing breaks in switch-case statement<br><br>In function test_codec_support_bts() the switch case statement lacks<br>break; statements for some cases. This may lead into messed up codec<br>decisions.<br><br>- Add missing break statements<br><br>Change-Id: Ib5400a0a0a8a39fa714bd087df345160bed5cc61<br>---<br>M src/osmo-bsc/codec_pref.c<br>1 file changed, 4 insertions(+), 0 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/64/10964/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/osmo-bsc/codec_pref.c b/src/osmo-bsc/codec_pref.c</span><br><span>index 96c2c38..924f77f 100644</span><br><span>--- a/src/osmo-bsc/codec_pref.c</span><br><span>+++ b/src/osmo-bsc/codec_pref.c</span><br><span>@@ -148,15 +148,19 @@</span><br><span>         case GSM0808_PERM_FR2:</span><br><span>               if (bts_codec->efr)</span><br><span>                       return true;</span><br><span style="color: hsl(120, 100%, 40%);">+          break;</span><br><span>       case GSM0808_PERM_FR3:</span><br><span>               if (bts_codec->amr)</span><br><span>                       return true;</span><br><span style="color: hsl(120, 100%, 40%);">+          break;</span><br><span>       case GSM0808_PERM_HR1:</span><br><span>               if (bts_codec->hr)</span><br><span>                        return true;</span><br><span style="color: hsl(120, 100%, 40%);">+          break;</span><br><span>       case GSM0808_PERM_HR3:</span><br><span>               if (bts_codec->amr)</span><br><span>                       return true;</span><br><span style="color: hsl(120, 100%, 40%);">+          break;</span><br><span>       default:</span><br><span>             return false;</span><br><span>        }</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/10964">change 10964</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/10964"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-bsc </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: Ib5400a0a0a8a39fa714bd087df345160bed5cc61 </div>
<div style="display:none"> Gerrit-Change-Number: 10964 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: dexter <pmaier@sysmocom.de> </div>