<p>dexter has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/10960">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">gsm0808: fix wrong codec defaults for OFR_AMR_WB<br><br>3GPP TS 48.008 chapter 3.2.2.103 states that the configuration bits of<br>OFR_AMR_WB are coded as follows:<br><br>"S0, S2, S4 indicates the supported Codec Configurations. S1, S3, S5, S6,<br>S7 are reserved and coded with zeroes."<br><br>The current default setting of 0x3F violates this requirement. Lets set<br>the "forbidden" settings zu zero and keep only the allowed ones.<br><br>Change-Id: I4a481def59e9c98cfdcafc2b80c0ac7df0c14130<br>---<br>M include/osmocom/gsm/protocol/gsm_08_08.h<br>1 file changed, 1 insertion(+), 1 deletion(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/60/10960/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/include/osmocom/gsm/protocol/gsm_08_08.h b/include/osmocom/gsm/protocol/gsm_08_08.h</span><br><span>index 69007b5..9433817 100644</span><br><span>--- a/include/osmocom/gsm/protocol/gsm_08_08.h</span><br><span>+++ b/include/osmocom/gsm/protocol/gsm_08_08.h</span><br><span>@@ -499,7 +499,7 @@</span><br><span>       GSM0808_SC_CFG_DEFAULT_HR_AMR           = 0x073f,</span><br><span>    GSM0808_SC_CFG_DEFAULT_OHR_AMR          = 0x57ff,</span><br><span>    GSM0808_SC_CFG_DEFAULT_FR_AMR_WB        = 0x01,</span><br><span style="color: hsl(0, 100%, 40%);">- GSM0808_SC_CFG_DEFAULT_OFR_AMR_WB       = 0x3f,</span><br><span style="color: hsl(120, 100%, 40%);">+       GSM0808_SC_CFG_DEFAULT_OFR_AMR_WB       = 0x15,</span><br><span>      GSM0808_SC_CFG_DEFAULT_OHR_AMR_WB       = 0x01,</span><br><span> };</span><br><span> </span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/10960">change 10960</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/10960"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: libosmocore </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I4a481def59e9c98cfdcafc2b80c0ac7df0c14130 </div>
<div style="display:none"> Gerrit-Change-Number: 10960 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: dexter <pmaier@sysmocom.de> </div>