<p>Piotr Krysik <strong>merged</strong> this change.</p><p><a href="https://gerrit.osmocom.org/10831">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Harald Welte: Looks good to me, but someone else must approve
  Piotr Krysik: Looks good to me, approved; Verified

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">apps/grgsm_trx: fix inaccurate sample rate calculation<br><br>Change-Id: I0c309588fa0f7822abfb3919327639735db07679<br>---<br>M apps/grgsm_trx<br>M python/trx/radio_if.py<br>2 files changed, 4 insertions(+), 1 deletion(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/apps/grgsm_trx b/apps/grgsm_trx</span><br><span>index 45312e6..6efed07 100755</span><br><span>--- a/apps/grgsm_trx</span><br><span>+++ b/apps/grgsm_trx</span><br><span>@@ -46,7 +46,7 @@</span><br><span>   base_port = 6700</span><br><span> </span><br><span>         # PHY specific</span><br><span style="color: hsl(0, 100%, 40%);">-  phy_sample_rate = 4 * 1625000 / 6</span><br><span style="color: hsl(120, 100%, 40%);">+     phy_sample_rate = radio_if.SAMPLE_RATE</span><br><span>       phy_freq_offset_hz = None</span><br><span>    phy_tx_antenna = "TX/RX"</span><br><span>   phy_rx_antenna = "RX2"</span><br><span>diff --git a/python/trx/radio_if.py b/python/trx/radio_if.py</span><br><span>index 407e724..2aeb49a 100644</span><br><span>--- a/python/trx/radio_if.py</span><br><span>+++ b/python/trx/radio_if.py</span><br><span>@@ -75,6 +75,9 @@</span><br><span>    GSM_TS_PERIOD_uS = GSM_SYM_PERIOD_uS * 156.25</span><br><span>        GSM_UL_DL_SHIFT_uS = -(GSM_TS_PERIOD_uS * 3)</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+      # TODO: explain where do these values come from?</span><br><span style="color: hsl(120, 100%, 40%);">+      SAMPLE_RATE = 4.0 * 1625000.0 / 6.0</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span>        # FIXME: shall be measured (automatically?) for</span><br><span>      # particular device and particular clock rate.</span><br><span>       # The current value is measured for USRP B2X0 at 26e6.</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/10831">change 10831</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/10831"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: gr-gsm </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: merged </div>
<div style="display:none"> Gerrit-Change-Id: I0c309588fa0f7822abfb3919327639735db07679 </div>
<div style="display:none"> Gerrit-Change-Number: 10831 </div>
<div style="display:none"> Gerrit-PatchSet: 3 </div>
<div style="display:none"> Gerrit-Owner: Vadim Yanitskiy <axilirator@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: Harald Welte <laforge@gnumonks.org> </div>
<div style="display:none"> Gerrit-Reviewer: Piotr Krysik <ptrkrysik@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: Vadim Yanitskiy <axilirator@gmail.com> </div>