<p>Harald Welte <strong>merged</strong> this change.</p><p><a href="https://gerrit.osmocom.org/10904">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Harald Welte: Looks good to me, approved
  Vadim Yanitskiy: Looks good to me, but someone else must approve
  Jenkins Builder: Verified

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">MSC_ConnectionHandler: stop properly on failure in f_establish_fully()<br><br>When the altstep in f_establish_fully() gets an unexpected ASSIGNMENT<br>FAIL or COMPLETE it should stop completely like it is already<br>implemented in many other altsteps.<br><br>Change-Id: Ib4ac7bcbac35a4ae454d1806f3fbb727834d18b7<br>---<br>M bsc/MSC_ConnectionHandler.ttcn<br>1 file changed, 10 insertions(+), 0 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/bsc/MSC_ConnectionHandler.ttcn b/bsc/MSC_ConnectionHandler.ttcn</span><br><span>index 102c30e..9f67f1b 100644</span><br><span>--- a/bsc/MSC_ConnectionHandler.ttcn</span><br><span>+++ b/bsc/MSC_ConnectionHandler.ttcn</span><br><span>@@ -939,18 +939,28 @@</span><br><span>    (not st.is_assignment and (st.modify_done or not exp_modify))) and</span><br><span>   exp_compl] BSSAP.receive(tr_BSSMAP_AssignmentComplete) {</span><br><span>            setverdict(fail, "Received non-matching ASSIGNMENT COMPLETE");</span><br><span style="color: hsl(120, 100%, 40%);">+              all component.stop;</span><br><span style="color: hsl(120, 100%, 40%);">+           mtc.stop;</span><br><span>            }</span><br><span>    [exp_compl] BSSAP.receive(tr_BSSMAP_AssignmentFail) {</span><br><span>                setverdict(fail, "Received unexpected ASSIGNMENT FAIL");</span><br><span style="color: hsl(120, 100%, 40%);">+            all component.stop;</span><br><span style="color: hsl(120, 100%, 40%);">+           mtc.stop;</span><br><span>            }</span><br><span>    [not exp_compl] BSSAP.receive(tr_BSSMAP_AssignmentComplete) {</span><br><span>                setverdict(fail, "Received unexpected ASSIGNMENT COMPLETE");</span><br><span style="color: hsl(120, 100%, 40%);">+                all component.stop;</span><br><span style="color: hsl(120, 100%, 40%);">+           mtc.stop;</span><br><span>            }</span><br><span>    [not exp_compl] BSSAP.receive(tr_BSSMAP_AssignmentFail) {</span><br><span>            setverdict(fail, "Received non-matching ASSIGNMENT FAIL");</span><br><span style="color: hsl(120, 100%, 40%);">+          all component.stop;</span><br><span style="color: hsl(120, 100%, 40%);">+           mtc.stop;</span><br><span>            }</span><br><span>    [] T.timeout {</span><br><span>               setverdict(fail, "Timeout waiting for ASSIGNMENT COMPLETE");</span><br><span style="color: hsl(120, 100%, 40%);">+                all component.stop;</span><br><span style="color: hsl(120, 100%, 40%);">+           mtc.stop;</span><br><span>            }</span><br><span>    }</span><br><span>    log("g_media ", g_media);</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/10904">change 10904</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/10904"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-ttcn3-hacks </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: merged </div>
<div style="display:none"> Gerrit-Change-Id: Ib4ac7bcbac35a4ae454d1806f3fbb727834d18b7 </div>
<div style="display:none"> Gerrit-Change-Number: 10904 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: dexter <pmaier@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Harald Welte <laforge@gnumonks.org> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder (1000002) </div>
<div style="display:none"> Gerrit-Reviewer: Vadim Yanitskiy <axilirator@gmail.com> </div>