<p>Keith Whyte <strong>merged</strong> this change.</p><p><a href="https://gerrit.osmocom.org/10869">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Jenkins Builder: Verified
  Harald Welte: Looks good to me, approved

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">log: add error log for RSL Chan Mode Modif<br><br>Add log context to chan_mode error in rsl_rx_mode_modif().<br><br>Tweaked-by: neels<br>Change-Id: I945cf1ca8660ad5daf097edab1833bbc74b6185f<br>---<br>M src/common/rsl.c<br>1 file changed, 4 insertions(+), 1 deletion(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/common/rsl.c b/src/common/rsl.c</span><br><span>index ad2d4de..2aa7f4d 100644</span><br><span>--- a/src/common/rsl.c</span><br><span>+++ b/src/common/rsl.c</span><br><span>@@ -1499,7 +1499,10 @@</span><br><span>  lchan_tchmode_from_cmode(lchan, cm);</span><br><span> </span><br><span>     if (bts_supports_cm(lchan->ts->trx->bts, ts_pchan(lchan->ts), lchan->tch_mode) != 1) {</span><br><span style="color: hsl(0, 100%, 40%);">-           LOGP(DRSL, LOGL_ERROR, "invalid mode/codec instructed by BSC, check BSC configuration.\n");</span><br><span style="color: hsl(120, 100%, 40%);">+         LOGP(DRSL, LOGL_ERROR,</span><br><span style="color: hsl(120, 100%, 40%);">+                     "%s %s: invalid mode: %s (wrong BSC configuration?)\n",</span><br><span style="color: hsl(120, 100%, 40%);">+                     gsm_ts_and_pchan_name(lchan->ts), gsm_lchan_name(lchan),</span><br><span style="color: hsl(120, 100%, 40%);">+                   gsm48_chan_mode_name(lchan->tch_mode));</span><br><span>              return rsl_tx_mode_modif_nack(lchan, RSL_ERR_SERV_OPT_UNAVAIL);</span><br><span>      }</span><br><span> </span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/10869">change 10869</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/10869"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-bts </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: merged </div>
<div style="display:none"> Gerrit-Change-Id: I945cf1ca8660ad5daf097edab1833bbc74b6185f </div>
<div style="display:none"> Gerrit-Change-Number: 10869 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Neels Hofmeyr <nhofmeyr@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Harald Welte <laforge@gnumonks.org> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder (1000002) </div>
<div style="display:none"> Gerrit-Reviewer: Keith Whyte <keith@rhizomatica.org> </div>