<p>Harald Welte <strong>merged</strong> this change.</p><p><a href="https://gerrit.osmocom.org/10819">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Jenkins Builder: Verified
  Harald Welte: Looks good to me, approved

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">trxcon/l1ctl.c: refactor Timing Advance handling<br><br>Change-Id: I0e4f18173347e3a7cb875f95d796e8ea20bfc4bf<br>---<br>M src/host/trxcon/l1ctl.c<br>M src/host/trxcon/trx_if.c<br>2 files changed, 6 insertions(+), 8 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/host/trxcon/l1ctl.c b/src/host/trxcon/l1ctl.c</span><br><span>index 230ef0a..1e88f8b 100644</span><br><span>--- a/src/host/trxcon/l1ctl.c</span><br><span>+++ b/src/host/trxcon/l1ctl.c</span><br><span>@@ -663,7 +663,6 @@</span><br><span> {</span><br><span>  struct l1ctl_par_req *par_req;</span><br><span>       struct l1ctl_info_ul *ul;</span><br><span style="color: hsl(0, 100%, 40%);">-       int rc = 0;</span><br><span> </span><br><span>      ul = (struct l1ctl_info_ul *) msg->l1h;</span><br><span>   par_req = (struct l1ctl_par_req *) ul->payload;</span><br><span>@@ -671,13 +670,16 @@</span><br><span>   LOGP(DL1C, LOGL_NOTICE, "Received L1CTL_PARAM_REQ "</span><br><span>                "(ta=%d, tx_power=%u)\n", par_req->ta, par_req->tx_power);</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-  rc |= trx_if_cmd_setta(l1l->trx, par_req->ta);</span><br><span style="color: hsl(120, 100%, 40%);">+  /* Instruct TRX to use new TA value */</span><br><span style="color: hsl(120, 100%, 40%);">+        if (l1l->trx->ta != par_req->ta) {</span><br><span style="color: hsl(120, 100%, 40%);">+           trx_if_cmd_setta(l1l->trx, par_req->ta);</span><br><span style="color: hsl(120, 100%, 40%);">+                l1l->trx->ta = par_req->ta;</span><br><span style="color: hsl(120, 100%, 40%);">+  }</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-   l1l->trx->ta = par_req->ta;</span><br><span>         l1l->trx->tx_power = par_req->tx_power;</span><br><span> </span><br><span>         msgb_free(msg);</span><br><span style="color: hsl(0, 100%, 40%);">- return rc;</span><br><span style="color: hsl(120, 100%, 40%);">+    return 0;</span><br><span> }</span><br><span> </span><br><span> static int l1ctl_rx_tch_mode_req(struct l1ctl_link *l1l, struct msgb *msg)</span><br><span>diff --git a/src/host/trxcon/trx_if.c b/src/host/trxcon/trx_if.c</span><br><span>index 19d8c75..b8bbace 100644</span><br><span>--- a/src/host/trxcon/trx_if.c</span><br><span>+++ b/src/host/trxcon/trx_if.c</span><br><span>@@ -388,10 +388,6 @@</span><br><span> </span><br><span> int trx_if_cmd_setta(struct trx_instance *trx, int8_t ta)</span><br><span> {</span><br><span style="color: hsl(0, 100%, 40%);">-      /* Do nothing, if requested TA value matches the current */</span><br><span style="color: hsl(0, 100%, 40%);">-     if (trx->ta == ta)</span><br><span style="color: hsl(0, 100%, 40%);">-           return 0;</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span>    return trx_ctrl_cmd(trx, 0, "SETTA", "%d", ta);</span><br><span> }</span><br><span> </span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/10819">change 10819</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/10819"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmocom-bb </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: merged </div>
<div style="display:none"> Gerrit-Change-Id: I0e4f18173347e3a7cb875f95d796e8ea20bfc4bf </div>
<div style="display:none"> Gerrit-Change-Number: 10819 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: Vadim Yanitskiy <axilirator@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: Harald Welte <laforge@gnumonks.org> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder (1000002) </div>