<p style="white-space: pre-wrap; word-wrap: break-word;">since this is a new subdir and nothing depends on it, you can decide whether to commit this patch as-is and continue later, or to wait and add more changes before submitting.</p><p>Patch set 2:<span style="border-radius: 3px; display: inline-block; margin: 0 2px; padding: 4px;background-color: #d4ffd4;">Code-Review +2</span></p><p><a href="https://gerrit.osmocom.org/10862">View Change</a></p><p>2 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.osmocom.org/#/c/10862/2/debian-repo-install-test/testdata/repo-install-test.sh">File debian-repo-install-test/testdata/repo-install-test.sh:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/#/c/10862/2/debian-repo-install-test/testdata/repo-install-test.sh@1">Patch Set #2, Line 1:</a> <code style="font-family:monospace,monospace">#!/bin/sh -e</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">also add -x to list the commands that were run?</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/#/c/10862/2/debian-repo-install-test/testdata/repo-install-test.sh@44">Patch Set #2, Line 44:</a> <code style="font-family:monospace,monospace">            bash</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">what does this do? if it's an interactive shell, just exiting should already give a terminal? I'm confused...</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.osmocom.org/10862">change 10862</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/10862"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: docker-playground </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: I0f0a8b4f0ccd706cd1af98fe25accd6fd410e007 </div>
<div style="display:none"> Gerrit-Change-Number: 10862 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: osmith <osmith@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Harald Welte <laforge@gnumonks.org> </div>
<div style="display:none"> Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr@sysmocom.de> </div>
<div style="display:none"> Gerrit-Comment-Date: Tue, 11 Sep 2018 00:40:20 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-HasLabels: Yes </div>