<p>Pau Espin Pedrol has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/10867">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">mgcp_osmux.c: osmux_enable_endpoint: Fix incorrect return check<br><br>osmux_xfrm_input_open_circuit returns 0 on success and -1 on error.<br>Confusion comes from that function being implemented by calling<br>osmux_batch_add_circuit which returns NULL on error.<br><br>Change-Id: I98700aa1e2fab9784706bfac1a47cc84635172b7<br>---<br>M openbsc/src/libmgcp/mgcp_osmux.c<br>1 file changed, 2 insertions(+), 2 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/openbsc refs/changes/67/10867/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/openbsc/src/libmgcp/mgcp_osmux.c b/openbsc/src/libmgcp/mgcp_osmux.c</span><br><span>index 69124d2..8a802f5 100644</span><br><span>--- a/openbsc/src/libmgcp/mgcp_osmux.c</span><br><span>+++ b/openbsc/src/libmgcp/mgcp_osmux.c</span><br><span>@@ -456,8 +456,8 @@</span><br><span>             LOGP(DMGCP, LOGL_ERROR, "Cannot allocate input osmux handle\n");</span><br><span>           return -1;</span><br><span>   }</span><br><span style="color: hsl(0, 100%, 40%);">-       if (!osmux_xfrm_input_open_circuit(endp->osmux.in, endp->osmux.cid,</span><br><span style="color: hsl(0, 100%, 40%);">-                                          endp->cfg->osmux_dummy)) {</span><br><span style="color: hsl(120, 100%, 40%);">+   if (osmux_xfrm_input_open_circuit(endp->osmux.in, endp->osmux.cid,</span><br><span style="color: hsl(120, 100%, 40%);">+                                         endp->cfg->osmux_dummy) < 0) {</span><br><span>           LOGP(DMGCP, LOGL_ERROR, "Cannot open osmux circuit %u\n",</span><br><span>               endp->osmux.cid);</span><br><span>            return -1;</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/10867">change 10867</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/10867"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: openbsc </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I98700aa1e2fab9784706bfac1a47cc84635172b7 </div>
<div style="display:none"> Gerrit-Change-Number: 10867 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Pau Espin Pedrol <pespin@sysmocom.de> </div>