<p>Neels Hofmeyr <strong>merged</strong> this change.</p><p><a href="https://gerrit.osmocom.org/10834">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">ho fsm: handle RR HO Failure for inter-BSC outgoing<br><br>Before, this would ignore the failure and hit a timeout instead. Rather handle<br>the event directly.<br><br>Change-Id: I21c43d2907d0413ef18ec43cf27f680ebecf9e82<br>---<br>M src/osmo-bsc/handover_fsm.c<br>1 file changed, 16 insertions(+), 0 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/osmo-bsc/handover_fsm.c b/src/osmo-bsc/handover_fsm.c</span><br><span>index a42f10c..9d558bc 100644</span><br><span>--- a/src/osmo-bsc/handover_fsm.c</span><br><span>+++ b/src/osmo-bsc/handover_fsm.c</span><br><span>@@ -1025,6 +1025,18 @@</span><br><span>  }</span><br><span> }</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+static void ho_out_fsm_wait_clear(struct osmo_fsm_inst *fi, uint32_t event, void *data)</span><br><span style="color: hsl(120, 100%, 40%);">+{</span><br><span style="color: hsl(120, 100%, 40%);">+        struct gsm_subscriber_connection *conn = ho_fi_conn(fi);</span><br><span style="color: hsl(120, 100%, 40%);">+      switch (event) {</span><br><span style="color: hsl(120, 100%, 40%);">+      case HO_EV_RR_HO_FAIL:</span><br><span style="color: hsl(120, 100%, 40%);">+                ho_fail(HO_RESULT_FAIL_RR_HO_FAIL, "Received RR Handover Failure message");</span><br><span style="color: hsl(120, 100%, 40%);">+         return;</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+     default:</span><br><span style="color: hsl(120, 100%, 40%);">+              OSMO_ASSERT(false);</span><br><span style="color: hsl(120, 100%, 40%);">+   }</span><br><span style="color: hsl(120, 100%, 40%);">+}</span><br><span> </span><br><span> #define S(x)        (1 << (x))</span><br><span> </span><br><span>@@ -1108,6 +1120,10 @@</span><br><span>        },</span><br><span>   [HO_OUT_ST_WAIT_CLEAR] = {</span><br><span>           .name = "inter-BSC-OUT:WAIT_CLEAR",</span><br><span style="color: hsl(120, 100%, 40%);">+         .in_event_mask = 0</span><br><span style="color: hsl(120, 100%, 40%);">+                    | S(HO_EV_RR_HO_FAIL)</span><br><span style="color: hsl(120, 100%, 40%);">+                 ,</span><br><span style="color: hsl(120, 100%, 40%);">+             .action = ho_out_fsm_wait_clear,</span><br><span>     },</span><br><span> };</span><br><span> </span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/10834">change 10834</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/10834"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-bsc </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: merged </div>
<div style="display:none"> Gerrit-Change-Id: I21c43d2907d0413ef18ec43cf27f680ebecf9e82 </div>
<div style="display:none"> Gerrit-Change-Number: 10834 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: Neels Hofmeyr <nhofmeyr@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Harald Welte <laforge@gnumonks.org> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder (1000002) </div>
<div style="display:none"> Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr@sysmocom.de> </div>