<p>Neels Hofmeyr <strong>merged</strong> this change.</p><p><a href="https://gerrit.osmocom.org/10809">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Jenkins Builder: Verified
  Neels Hofmeyr: Looks good to me, approved

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">inter-BSC HO outgoing: fix L3 forwarding<br><br>Set msgb->l3h when composing the L3 message. Before this, the unset l3h<br>resulted in erratic size in the RSL L3 Info IE. This likely fixes inter-BSC<br>Handover on the outgoing side, to properly forward the RR Handover Command.<br><br>Change-Id: Ice37242c90c19adbf0795618fd16fe75f0809317<br>---<br>M src/osmo-bsc/abis_rsl.c<br>1 file changed, 2 insertions(+), 3 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/osmo-bsc/abis_rsl.c b/src/osmo-bsc/abis_rsl.c</span><br><span>index 0dd27fd..589d673 100644</span><br><span>--- a/src/osmo-bsc/abis_rsl.c</span><br><span>+++ b/src/osmo-bsc/abis_rsl.c</span><br><span>@@ -683,14 +683,13 @@</span><br><span> int rsl_forward_layer3_info(struct gsm_lchan *lchan, const uint8_t *l3_info, uint8_t l3_info_len)</span><br><span> {</span><br><span>        struct msgb *msg;</span><br><span style="color: hsl(0, 100%, 40%);">-       uint8_t *dst;</span><br><span> </span><br><span>    if (!l3_info || !l3_info_len)</span><br><span>                return -EINVAL;</span><br><span> </span><br><span>  msg = rsl_msgb_alloc();</span><br><span style="color: hsl(0, 100%, 40%);">- dst = msgb_put(msg, l3_info_len);</span><br><span style="color: hsl(0, 100%, 40%);">-       memcpy(dst, l3_info, l3_info_len);</span><br><span style="color: hsl(120, 100%, 40%);">+    msg->l3h = msgb_put(msg, l3_info_len);</span><br><span style="color: hsl(120, 100%, 40%);">+     memcpy(msg->l3h, l3_info, l3_info_len);</span><br><span> </span><br><span>       msg->lchan = lchan;</span><br><span>       return rsl_data_request(msg, 0);</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/10809">change 10809</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/10809"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-bsc </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: merged </div>
<div style="display:none"> Gerrit-Change-Id: Ice37242c90c19adbf0795618fd16fe75f0809317 </div>
<div style="display:none"> Gerrit-Change-Number: 10809 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: Neels Hofmeyr <nhofmeyr@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Harald Welte <laforge@gnumonks.org> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder (1000002) </div>
<div style="display:none"> Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Vadim Yanitskiy <axilirator@gmail.com> </div>