<p>Neels Hofmeyr has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/10800">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">compare_results.sh: less drastic wording<br><br>We don't currently fail test runs from mismatching results, it's just for human<br>convenience. So don't say things like "Failing due to skipped tests", it's<br>confusing.<br><br>Summarize once the need to update results instead.<br><br>Change-Id: Ibafa75bd54df07253780c6af3a68a0a4d148e64b<br>---<br>M compare-results.sh<br>1 file changed, 9 insertions(+), 8 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/00/10800/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/compare-results.sh b/compare-results.sh</span><br><span>index 708f59d..cce3a8d 100755</span><br><span>--- a/compare-results.sh</span><br><span>+++ b/compare-results.sh</span><br><span>@@ -152,6 +152,8 @@</span><br><span> echo "--------------------"</span><br><span> overall_verdict=0</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+ask_update=""</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> if [ "x$pass" != x0 ]; then</span><br><span>   echo "$pass pass"</span><br><span> fi</span><br><span>@@ -162,25 +164,25 @@</span><br><span> </span><br><span> if [ "x$skipped" != x0 ]; then</span><br><span>   echo "$skipped skipped"</span><br><span style="color: hsl(120, 100%, 40%);">+  ask_update="$ask_update removed=$skipped"</span><br><span>   if [ "x$allow_skip" = x0 ]; then</span><br><span>     overall_verdict=4</span><br><span style="color: hsl(0, 100%, 40%);">-    echo "   Failing due to skipped tests. If tests were removed, update the expected results!"</span><br><span>   fi</span><br><span> fi</span><br><span> </span><br><span> if [ "x$new" != x0 ]; then</span><br><span>   echo "$new new"</span><br><span style="color: hsl(120, 100%, 40%);">+  ask_update="$ask_update new=$new"</span><br><span>   if [ "x$allow_new" = x0 ]; then</span><br><span>     overall_verdict=3</span><br><span style="color: hsl(0, 100%, 40%);">-    echo "   Failing due to new tests. Update the expected results!"</span><br><span>   fi</span><br><span> fi</span><br><span> </span><br><span> if [ "x$more_successes" != x0 ]; then</span><br><span>   echo "$more_successes pass unexpectedly"</span><br><span style="color: hsl(120, 100%, 40%);">+  ask_update="$ask_update xpass=$more_successes"</span><br><span>   if [ "x$allow_xpass" = x0 ]; then</span><br><span>     overall_verdict=2</span><br><span style="color: hsl(0, 100%, 40%);">-    echo "   Update the expected results!"</span><br><span>   fi</span><br><span> fi</span><br><span> </span><br><span>@@ -189,10 +191,9 @@</span><br><span>   overall_verdict=1</span><br><span> fi</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-echo</span><br><span style="color: hsl(0, 100%, 40%);">-if [ "x$overall_verdict" != x0 ]; then</span><br><span style="color: hsl(0, 100%, 40%);">-  echo "FAILURE"</span><br><span style="color: hsl(0, 100%, 40%);">-else</span><br><span style="color: hsl(0, 100%, 40%);">-  echo "ok"</span><br><span style="color: hsl(120, 100%, 40%);">+if [ -n "$ask_update" ]; then</span><br><span style="color: hsl(120, 100%, 40%);">+  echo</span><br><span style="color: hsl(120, 100%, 40%);">+  echo "(Please update the expected results:$ask_update)"</span><br><span> fi</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> exit $overall_verdict</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/10800">change 10800</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/10800"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-ttcn3-hacks </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: Ibafa75bd54df07253780c6af3a68a0a4d148e64b </div>
<div style="display:none"> Gerrit-Change-Number: 10800 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Neels Hofmeyr <nhofmeyr@sysmocom.de> </div>