<p>Neels Hofmeyr has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/10810">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">SCCPlite Assignment Complete: include Speech Codec (Chosen)<br><br>Compose the Speech Codec (Chosen) IE not only for AoIP, but also for SCCPlite:<br>place the code that assigns the codec to sc_ptr outside of the gscon_is_aoip()<br>if scope.<br><br>This way the MSC is told the chosen speech codec, which is mandatory for IP<br>based user plane, and was missing until now.<br><br>Related: OS#3528<br>Change-Id: Ibedade8d71a7994d25a63bc2faa2a24a10bfffa1<br>---<br>M src/osmo-bsc/assignment_fsm.c<br>1 file changed, 4 insertions(+), 4 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/10/10810/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/osmo-bsc/assignment_fsm.c b/src/osmo-bsc/assignment_fsm.c</span><br><span>index e1da45b..63776f0 100644</span><br><span>--- a/src/osmo-bsc/assignment_fsm.c</span><br><span>+++ b/src/osmo-bsc/assignment_fsm.c</span><br><span>@@ -163,12 +163,12 @@</span><br><span>                          return;</span><br><span>                      }</span><br><span>                    addr_local_p = &addr_local;</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">-                 /* Extrapolate speech codec from speech mode */</span><br><span style="color: hsl(0, 100%, 40%);">-                 gsm0808_speech_codec_from_chan_type(&sc, perm_spch);</span><br><span style="color: hsl(0, 100%, 40%);">-                        sc_ptr = &sc;</span><br><span>            }</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+           /* Extrapolate speech codec from speech mode */</span><br><span>              /* FIXME: AMR codec configuration must be derived from lchan1! */</span><br><span style="color: hsl(120, 100%, 40%);">+             gsm0808_speech_codec_from_chan_type(&sc, perm_spch);</span><br><span style="color: hsl(120, 100%, 40%);">+              sc_ptr = &sc;</span><br><span>    }</span><br><span> </span><br><span>        resp = gsm0808_create_ass_compl(lchan->abis_ip.ass_compl.rr_cause,</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/10810">change 10810</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/10810"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-bsc </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: Ibedade8d71a7994d25a63bc2faa2a24a10bfffa1 </div>
<div style="display:none"> Gerrit-Change-Number: 10810 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Neels Hofmeyr <nhofmeyr@sysmocom.de> </div>