<p>Vadim Yanitskiy <strong>merged</strong> this change.</p><p><a href="https://gerrit.osmocom.org/10776">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Jenkins Builder: Verified
  Harald Welte: Looks good to me, approved

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">trxcon/l1ctl.c: drop meaningless 'tn > 7' checks<br><br>There is no need to check the range of timeslot number, which is<br>decoded from GSM 08.58 channel number (9.3.1) by applying 0x07<br>mask, because any result of this operation is always within<br>the correct range.<br><br>Change-Id: Ib84417099d303bd3ae3557f48a5c40b812c6cdfc<br>---<br>M src/host/trxcon/l1ctl.c<br>1 file changed, 0 insertions(+), 10 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/host/trxcon/l1ctl.c b/src/host/trxcon/l1ctl.c</span><br><span>index 74400be..ec8b4c7 100644</span><br><span>--- a/src/host/trxcon/l1ctl.c</span><br><span>+++ b/src/host/trxcon/l1ctl.c</span><br><span>@@ -565,11 +565,6 @@</span><br><span> </span><br><span>      /* Determine TS index */</span><br><span>     tn = chan_nr & 0x7;</span><br><span style="color: hsl(0, 100%, 40%);">- if (tn > 7) {</span><br><span style="color: hsl(0, 100%, 40%);">-                LOGP(DL1C, LOGL_ERROR, "Incorrect TS index %u\n", tn);</span><br><span style="color: hsl(0, 100%, 40%);">-                rc = -EINVAL;</span><br><span style="color: hsl(0, 100%, 40%);">-           goto exit;</span><br><span style="color: hsl(0, 100%, 40%);">-      }</span><br><span> </span><br><span>        /* Configure requested TS */</span><br><span>         rc = sched_trx_configure_ts(l1l->trx, tn, config);</span><br><span>@@ -732,11 +727,6 @@</span><br><span> </span><br><span>     /* Determine TS index */</span><br><span>     tn = ul->chan_nr & 0x7;</span><br><span style="color: hsl(0, 100%, 40%);">-  if (tn > 7) {</span><br><span style="color: hsl(0, 100%, 40%);">-                LOGP(DL1C, LOGL_ERROR, "Incorrect TS index %u\n", tn);</span><br><span style="color: hsl(0, 100%, 40%);">-                rc = -EINVAL;</span><br><span style="color: hsl(0, 100%, 40%);">-           goto exit;</span><br><span style="color: hsl(0, 100%, 40%);">-      }</span><br><span> </span><br><span>        /* Make sure that required TS is allocated and configured */</span><br><span>         ts = l1l->trx->ts_list[tn];</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/10776">change 10776</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/10776"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmocom-bb </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: merged </div>
<div style="display:none"> Gerrit-Change-Id: Ib84417099d303bd3ae3557f48a5c40b812c6cdfc </div>
<div style="display:none"> Gerrit-Change-Number: 10776 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Vadim Yanitskiy <axilirator@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: Harald Welte <laforge@gnumonks.org> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder (1000002) </div>
<div style="display:none"> Gerrit-Reviewer: Vadim Yanitskiy <axilirator@gmail.com> </div>