<p>Vadim Yanitskiy <strong>merged</strong> this change.</p><p><a href="https://gerrit.osmocom.org/10432">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Jenkins Builder: Verified
  Harald Welte: Looks good to me, approved

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">trxcon: distinguish between unimplemented and unknown messages<br><br>Let's differentiate between 'expected' unimplemented messages<br>like L1CTL_NEIGH_PM_REQ and truly unknonw message types.<br><br>Change-Id: Id76993056fb514e6fb0242d505205316c61bb965<br>---<br>M src/host/trxcon/l1ctl.c<br>1 file changed, 10 insertions(+), 0 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/host/trxcon/l1ctl.c b/src/host/trxcon/l1ctl.c</span><br><span>index b0a4c6d..230ef0a 100644</span><br><span>--- a/src/host/trxcon/l1ctl.c</span><br><span>+++ b/src/host/trxcon/l1ctl.c</span><br><span>@@ -792,6 +792,16 @@</span><br><span>             return l1ctl_rx_tch_mode_req(l1l, msg);</span><br><span>      case L1CTL_CRYPTO_REQ:</span><br><span>               return l1ctl_rx_crypto_req(l1l, msg);</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+       /* Not (yet) handled messages */</span><br><span style="color: hsl(120, 100%, 40%);">+      case L1CTL_NEIGH_PM_REQ:</span><br><span style="color: hsl(120, 100%, 40%);">+      case L1CTL_DATA_TBF_REQ:</span><br><span style="color: hsl(120, 100%, 40%);">+      case L1CTL_TBF_CFG_REQ:</span><br><span style="color: hsl(120, 100%, 40%);">+       case L1CTL_DM_FREQ_REQ:</span><br><span style="color: hsl(120, 100%, 40%);">+       case L1CTL_SIM_REQ:</span><br><span style="color: hsl(120, 100%, 40%);">+           LOGP(DL1C, LOGL_NOTICE, "Ignoring unsupported message "</span><br><span style="color: hsl(120, 100%, 40%);">+                     "(type=%u)\n", l1h->msg_type);</span><br><span style="color: hsl(120, 100%, 40%);">+           return -ENOTSUP;</span><br><span>     default:</span><br><span>             LOGP(DL1C, LOGL_ERROR, "Unknown MSG type %u: %s\n", l1h->msg_type,</span><br><span>                      osmo_hexdump(msgb_data(msg), msgb_length(msg)));</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/10432">change 10432</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/10432"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmocom-bb </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: merged </div>
<div style="display:none"> Gerrit-Change-Id: Id76993056fb514e6fb0242d505205316c61bb965 </div>
<div style="display:none"> Gerrit-Change-Number: 10432 </div>
<div style="display:none"> Gerrit-PatchSet: 4 </div>
<div style="display:none"> Gerrit-Owner: Harald Welte <laforge@gnumonks.org> </div>
<div style="display:none"> Gerrit-Reviewer: Harald Welte <laforge@gnumonks.org> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder (1000002) </div>
<div style="display:none"> Gerrit-Reviewer: Vadim Yanitskiy <axilirator@gmail.com> </div>