<p>Neels Hofmeyr <strong>merged</strong> this change.</p><p><a href="https://gerrit.osmocom.org/10774">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Neels Hofmeyr: Looks good to me, approved
  Jenkins Builder: Verified

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">assignment: remove unnecessary call to gsm0808_speech_codec_from_chan_type()<br><br>There is a function call to gsm0808_speech_codec_from_chan_type() after<br>an if construct that checks if we need voice and if we need it if it is<br>related to an AoIP connection.<br><br>However, at the moment we call gsm0808_speech_codec_from_chan_type() all<br>the time, even when just figured out that we don't need to. Presumably<br>this is a refactory leftover. Lets remove the excess function call.<br><br>Change-Id: I34d9281944b36cd89ad8e1c5774f0ea80fdfadc8<br>---<br>M src/osmo-bsc/assignment_fsm.c<br>1 file changed, 0 insertions(+), 2 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/osmo-bsc/assignment_fsm.c b/src/osmo-bsc/assignment_fsm.c</span><br><span>index 41615ac..e1da45b 100644</span><br><span>--- a/src/osmo-bsc/assignment_fsm.c</span><br><span>+++ b/src/osmo-bsc/assignment_fsm.c</span><br><span>@@ -171,8 +171,6 @@</span><br><span>                 /* FIXME: AMR codec configuration must be derived from lchan1! */</span><br><span>    }</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-   gsm0808_speech_codec_from_chan_type(&sc, perm_spch);</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span>     resp = gsm0808_create_ass_compl(lchan->abis_ip.ass_compl.rr_cause,</span><br><span>                                        chosen_channel,</span><br><span>                                      lchan->encr.alg_id, perm_spch,</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/10774">change 10774</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/10774"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-bsc </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: merged </div>
<div style="display:none"> Gerrit-Change-Id: I34d9281944b36cd89ad8e1c5774f0ea80fdfadc8 </div>
<div style="display:none"> Gerrit-Change-Number: 10774 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: dexter <pmaier@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder (1000002) </div>
<div style="display:none"> Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr@sysmocom.de> </div>