<p>Harald Welte <strong>merged</strong> this change.</p><p><a href="https://gerrit.osmocom.org/10729">View Change</a></p><div style="white-space:pre-wrap">Approvals:
Jenkins Builder: Verified
Harald Welte: Looks good to me, approved
</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">Logging: Add debug logging for status/causes<br><br>Adds some DEBUG level logging for SIP status and MNCC causes.<br><br>Change-Id: Ib56e34ba079c7927e932c1b29d3e8341b8099ae0<br>---<br>M src/mncc.c<br>M src/sip.c<br>2 files changed, 9 insertions(+), 3 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/mncc.c b/src/mncc.c</span><br><span>index ae60321..4cdc0b3 100644</span><br><span>--- a/src/mncc.c</span><br><span>+++ b/src/mncc.c</span><br><span>@@ -264,7 +264,7 @@</span><br><span> case MNCC_CC_PROCEEDING:</span><br><span> case MNCC_CC_CONNECTED:</span><br><span> LOGP(DMNCC, LOGL_DEBUG,</span><br><span style="color: hsl(0, 100%, 40%);">- "Releasing call in non-initial leg(%u)\n", leg->callref);</span><br><span style="color: hsl(120, 100%, 40%);">+ "Releasing call in non-initial leg(%u) cause(%d)\n", leg->callref, leg->base.cause);</span><br><span> leg->base.in_release = true;</span><br><span> start_cmd_timer(leg, MNCC_REL_IND);</span><br><span> mncc_send(leg->conn, MNCC_DISC_REQ, leg->callref);</span><br><span>@@ -508,6 +508,8 @@</span><br><span> return;</span><br><span> </span><br><span> LOGP(DMNCC,</span><br><span style="color: hsl(120, 100%, 40%);">+ LOGL_DEBUG, "Rcvd MNCC_DISC_IND, Cause: %d\n", data->cause.value);</span><br><span style="color: hsl(120, 100%, 40%);">+ LOGP(DMNCC,</span><br><span> LOGL_DEBUG, "leg(%u) was disconnected. Releasing\n", data->callref);</span><br><span> leg->base.in_release = true;</span><br><span> start_cmd_timer(leg, MNCC_REL_CNF);</span><br><span>@@ -529,6 +531,8 @@</span><br><span> if (!leg)</span><br><span> return;</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+ LOGP(DMNCC, LOGL_DEBUG, "Rcvd MNCC_REL_IND, Cause: %d\n", data->cause.value);</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> if (leg->base.in_release)</span><br><span> stop_cmd_timer(leg, MNCC_REL_IND);</span><br><span> else {</span><br><span>@@ -587,7 +591,7 @@</span><br><span> other_leg->cause = data->cause.value;</span><br><span> other_leg->release_call(other_leg);</span><br><span> }</span><br><span style="color: hsl(0, 100%, 40%);">- LOGP(DMNCC, LOGL_DEBUG, "leg(%u) was rejected.\n", data->callref);</span><br><span style="color: hsl(120, 100%, 40%);">+ LOGP(DMNCC, LOGL_DEBUG, "leg(%u) was rejected with cause(%d).\n", data->callref, leg->cause);</span><br><span> mncc_leg_release(leg);</span><br><span> }</span><br><span> </span><br><span>diff --git a/src/sip.c b/src/sip.c</span><br><span>index 088dbc3..c9f5abb 100644</span><br><span>--- a/src/sip.c</span><br><span>+++ b/src/sip.c</span><br><span>@@ -239,12 +239,13 @@</span><br><span> else if (status >= 300) {</span><br><span> struct call_leg *other = call_leg_other(&leg->base);</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- LOGP(DSIP, LOGL_ERROR, "leg(%p) unknown err, releasing.\n", leg);</span><br><span style="color: hsl(120, 100%, 40%);">+ LOGP(DSIP, LOGL_ERROR, "leg(%p) unknown SIP status(%d), releasing.\n", leg, status);</span><br><span> nua_cancel(leg->nua_handle, TAG_END());</span><br><span> nua_handle_destroy(leg->nua_handle);</span><br><span> call_leg_release(&leg->base);</span><br><span> </span><br><span> if (other) {</span><br><span style="color: hsl(120, 100%, 40%);">+ LOGP(DSIP, LOGL_DEBUG, "Releasing other leg (%p) with status(%d)\n", other, status);</span><br><span> other->cause = status2cause(status);</span><br><span> other->release_call(other);</span><br><span> }</span><br><span>@@ -326,6 +327,7 @@</span><br><span> * to help us here.</span><br><span> */</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+ LOGP(DSIP, LOGL_DEBUG, "%s(): Release with MNCC cause(%d)\n", __func__, _leg->cause);</span><br><span> cause2status(_leg->cause, &sip_cause, &sip_phrase, &reason_text);</span><br><span> snprintf(reason, sizeof reason, "Q.850;cause=%u;text=\"%s\"", _leg->cause, reason_text);</span><br><span> </span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/10729">change 10729</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/10729"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: osmo-sip-connector </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: merged </div>
<div style="display:none"> Gerrit-Change-Id: Ib56e34ba079c7927e932c1b29d3e8341b8099ae0 </div>
<div style="display:none"> Gerrit-Change-Number: 10729 </div>
<div style="display:none"> Gerrit-PatchSet: 5 </div>
<div style="display:none"> Gerrit-Owner: Keith Whyte <keith@rhizomatica.org> </div>
<div style="display:none"> Gerrit-Reviewer: Harald Welte <laforge@gnumonks.org> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder (1000002) </div>
<div style="display:none"> Gerrit-Reviewer: Keith Whyte <keith@rhizomatica.org> </div>