<p>Harald Welte <strong>merged</strong> this change.</p><p><a href="https://gerrit.osmocom.org/10699">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Jenkins Builder: Verified
  Harald Welte: Looks good to me, approved

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">cosmetic: lchan activ: no need to clear mr again<br><br>In lchan state UNUSED, on activating an lchan, we zero out the lchan->mr_ms_lv<br>and mr_bts_lv. However, in UNUSED's onenter function, we already called<br>lchan_reset(), clearing out the lchan completely.<br><br>Drop two lines of unnecessary code.<br><br>Change-Id: I8b38f222f1c8c822e8e5e776850dbc60e30e8b8d<br>---<br>M src/osmo-bsc/lchan_fsm.c<br>1 file changed, 0 insertions(+), 2 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/osmo-bsc/lchan_fsm.c b/src/osmo-bsc/lchan_fsm.c</span><br><span>index 13ae7ad..28dc846 100644</span><br><span>--- a/src/osmo-bsc/lchan_fsm.c</span><br><span>+++ b/src/osmo-bsc/lchan_fsm.c</span><br><span>@@ -460,8 +460,6 @@</span><br><span>                   };</span><br><span>                   lchan->ms_power = ms_pwr_ctl_lvl(bts->band, bts->ms_max_power);</span><br><span>                     lchan->bs_power = 0; /* 0dB reduction, output power = Pn */</span><br><span style="color: hsl(0, 100%, 40%);">-                  memset(&lchan->mr_ms_lv, 0, sizeof(lchan->mr_ms_lv));</span><br><span style="color: hsl(0, 100%, 40%);">-                 memset(&lchan->mr_bts_lv, 0, sizeof(lchan->mr_bts_lv));</span><br><span>            }</span><br><span> </span><br><span>                if (info->chan_mode == GSM48_CMODE_SPEECH_AMR)</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/10699">change 10699</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/10699"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-bsc </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: merged </div>
<div style="display:none"> Gerrit-Change-Id: I8b38f222f1c8c822e8e5e776850dbc60e30e8b8d </div>
<div style="display:none"> Gerrit-Change-Number: 10699 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Neels Hofmeyr <nhofmeyr@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Harald Welte <laforge@gnumonks.org> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder (1000002) </div>
<div style="display:none"> Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr@sysmocom.de> </div>
<div style="display:none"> Gerrit-CC: Pau Espin Pedrol <pespin@sysmocom.de> </div>