<p>Harald Welte <strong>merged</strong> this change.</p><p><a href="https://gerrit.osmocom.org/10673">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Jenkins Builder: Verified
  Harald Welte: Looks good to me, approved

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">qmod: output EEPROM data only on debug level, and add completion output<br><br>the EEPROM byte output was causing data loss on the serial output,<br>resulting is automatic tests failing.<br>instead an end text will be output to detect the end of the procedure.<br><br>Change-Id: Ib8d3cbd01d0e34432d424355f4fafb24bc5273a1<br>---<br>M firmware/libboard/qmod/source/board_qmod.c<br>1 file changed, 5 insertions(+), 3 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/firmware/libboard/qmod/source/board_qmod.c b/firmware/libboard/qmod/source/board_qmod.c</span><br><span>index f04bc12..55efb54 100644</span><br><span>--- a/firmware/libboard/qmod/source/board_qmod.c</span><br><span>+++ b/firmware/libboard/qmod/source/board_qmod.c</span><br><span>@@ -90,11 +90,12 @@</span><br><span>         TRACE_INFO("Verifying EEPROM...\n\r");</span><br><span>     for (i = 0; i < ARRAY_SIZE(__eeprom_bin); i++) {</span><br><span>          int byte = eeprom_read_byte(0x50, i);</span><br><span style="color: hsl(0, 100%, 40%);">-           TRACE_INFO("0x%02x: %02x\n\r", i, byte);</span><br><span style="color: hsl(120, 100%, 40%);">+            TRACE_DEBUG("0x%02x: %02x\n\r", i, byte);</span><br><span>          if (byte != __eeprom_bin[i])</span><br><span>                         TRACE_ERROR("Byte %u is wrong, expected 0x%02x, found 0x%02x\n\r",</span><br><span>                                         i, __eeprom_bin[i], byte);</span><br><span>   }</span><br><span style="color: hsl(120, 100%, 40%);">+     TRACE_INFO("EEPROM written\n\r");</span><br><span> </span><br><span>      /* FIXME: Release PIN_PRTPWR_OVERRIDE after we know the hub is</span><br><span>        * again powering us up */</span><br><span>@@ -119,6 +120,7 @@</span><br><span>                     return 1;</span><br><span>            }</span><br><span>    }</span><br><span style="color: hsl(120, 100%, 40%);">+     TRACE_INFO("EEPROM erased\n\r");</span><br><span> </span><br><span>       return 0;</span><br><span> }</span><br><span>@@ -163,13 +165,13 @@</span><br><span>               UART_GetIntegerMinMax(&addr, 0, 255);</span><br><span>            printf("Please enter EEPROM value:\n\r");</span><br><span>          UART_GetIntegerMinMax(&val, 0, 255);</span><br><span style="color: hsl(0, 100%, 40%);">-                printf("Writing value 0x%02lx to EEPROM offset 0x%02lx\n\r", val, addr);</span><br><span style="color: hsl(120, 100%, 40%);">+            printf("Writing value 0x%02x to EEPROM offset 0x%02x\n\r", val, addr);</span><br><span>             eeprom_write_byte(0x50, addr, val);</span><br><span>          break;</span><br><span>       case 'r':</span><br><span>            printf("Please enter EEPROM offset:\n\r");</span><br><span>                 UART_GetIntegerMinMax(&addr, 0, 255);</span><br><span style="color: hsl(0, 100%, 40%);">-               printf("EEPROM[0x%02lx] = 0x%02x\n\r", addr, eeprom_read_byte(0x50, addr));</span><br><span style="color: hsl(120, 100%, 40%);">+         printf("EEPROM[0x%02x] = 0x%02x\n\r", addr, eeprom_read_byte(0x50, addr));</span><br><span>                 break;</span><br><span>       default:</span><br><span>             printf("Unknown command '%c'\n\r", ch);</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/10673">change 10673</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/10673"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: simtrace2 </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: merged </div>
<div style="display:none"> Gerrit-Change-Id: Ib8d3cbd01d0e34432d424355f4fafb24bc5273a1 </div>
<div style="display:none"> Gerrit-Change-Number: 10673 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: Kévin Redon <kredon@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Harald Welte <laforge@gnumonks.org> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder (1000002) </div>