<p>Harald Welte <strong>merged</strong> this change.</p><p><a href="https://gerrit.osmocom.org/10734">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Jenkins Builder: Verified
  Vadim Yanitskiy: Looks good to me, but someone else must approve
  Harald Welte: Looks good to me, approved

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">mncc: Fix missing conditional clause<br><br>Fixes following compilation warning:<br>osmo-sip-connector/src/mncc.c: In function ‘check_disc_ind’:<br>osmo-sip-connector/src/mncc.c:517:2: warning: this ‘if’ clause does not guard... [-Wmisleading-indentation]<br>  if (other_leg)<br>  ^~<br><br>Fixes: 008915ee41900c34ec0fd8df0c9f1d7c2cbdb3b2 ("Implement Cause Mapping")<br><br>Change-Id: I5bdbc29a3f82bdc92b156c1f7df68c9503f85f8f<br>---<br>M src/mncc.c<br>1 file changed, 6 insertions(+), 3 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/mncc.c b/src/mncc.c</span><br><span>index f41bb51..ae60321 100644</span><br><span>--- a/src/mncc.c</span><br><span>+++ b/src/mncc.c</span><br><span>@@ -514,9 +514,10 @@</span><br><span>    mncc_send(leg->conn, MNCC_REL_REQ, leg->callref);</span><br><span> </span><br><span>  other_leg = call_leg_other(&leg->base);</span><br><span style="color: hsl(0, 100%, 40%);">-  if (other_leg)</span><br><span style="color: hsl(120, 100%, 40%);">+        if (other_leg) {</span><br><span>             other_leg->cause = data->cause.value;</span><br><span>          other_leg->release_call(other_leg);</span><br><span style="color: hsl(120, 100%, 40%);">+        }</span><br><span> }</span><br><span> </span><br><span> static void check_rel_ind(struct mncc_connection *conn, const char *buf, int rc)</span><br><span>@@ -533,9 +534,10 @@</span><br><span>        else {</span><br><span>               struct call_leg *other_leg;</span><br><span>          other_leg = call_leg_other(&leg->base);</span><br><span style="color: hsl(0, 100%, 40%);">-          if (other_leg)</span><br><span style="color: hsl(120, 100%, 40%);">+                if (other_leg) {</span><br><span>                     other_leg->cause = data->cause.value;</span><br><span>                  other_leg->release_call(other_leg);</span><br><span style="color: hsl(120, 100%, 40%);">+                }</span><br><span>    }</span><br><span>    LOGP(DMNCC, LOGL_DEBUG, "leg(%u) was released.\n", data->callref);</span><br><span>      mncc_leg_release(leg);</span><br><span>@@ -581,9 +583,10 @@</span><br><span> </span><br><span>    leg->cause = data->cause.value;</span><br><span>        other_leg = call_leg_other(&leg->base);</span><br><span style="color: hsl(0, 100%, 40%);">-  if (other_leg)</span><br><span style="color: hsl(120, 100%, 40%);">+        if (other_leg) {</span><br><span>             other_leg->cause = data->cause.value;</span><br><span>          other_leg->release_call(other_leg);</span><br><span style="color: hsl(120, 100%, 40%);">+        }</span><br><span>    LOGP(DMNCC, LOGL_DEBUG, "leg(%u) was rejected.\n", data->callref);</span><br><span>      mncc_leg_release(leg);</span><br><span> }</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/10734">change 10734</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/10734"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-sip-connector </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: merged </div>
<div style="display:none"> Gerrit-Change-Id: I5bdbc29a3f82bdc92b156c1f7df68c9503f85f8f </div>
<div style="display:none"> Gerrit-Change-Number: 10734 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Pau Espin Pedrol <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Harald Welte <laforge@gnumonks.org> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder (1000002) </div>
<div style="display:none"> Gerrit-Reviewer: Pau Espin Pedrol <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Vadim Yanitskiy <axilirator@gmail.com> </div>