<p>Neels Hofmeyr has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/10701">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">lchan: pick proper power and ta values<br><br>When activating an lchan, the power levels should be maximum and TA zero. Only<br>if a new lchan is assigned within the same cell does it make sense to take over<br>the previous power and TA levels.<br><br>In LCHAN_EV_ACTIVATE:<br><br>- Separate the code that copies previous encryption data. This should happen<br>  regardless of whether we're staying in the same cell or not.<br><br>- For the power,TA levels, take over an old lchan's values only when it is<br>  assigning a new lchan in the same cell.<br><br>Change-Id: I360b003398487fa6f934296ff03643c33ec61a35<br>---<br>M src/osmo-bsc/lchan_fsm.c<br>1 file changed, 15 insertions(+), 6 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/01/10701/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/osmo-bsc/lchan_fsm.c b/src/osmo-bsc/lchan_fsm.c</span><br><span>index 3352da5..7d47380 100644</span><br><span>--- a/src/osmo-bsc/lchan_fsm.c</span><br><span>+++ b/src/osmo-bsc/lchan_fsm.c</span><br><span>@@ -429,6 +429,8 @@</span><br><span> {</span><br><span>        struct lchan_activate_info *info = data;</span><br><span>     struct gsm_lchan *lchan = lchan_fi_lchan(fi);</span><br><span style="color: hsl(120, 100%, 40%);">+ struct gsm_bts *bts = lchan->ts->trx->bts;</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span>        switch (event) {</span><br><span> </span><br><span>         case LCHAN_EV_ACTIVATE:</span><br><span>@@ -446,18 +448,25 @@</span><br><span>              lchan->activate.concluded = false;</span><br><span>                lchan->activate.re_use_mgw_endpoint_from_lchan = info->old_lchan;</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-             if (info->old_lchan) {</span><br><span style="color: hsl(120, 100%, 40%);">+             if (info->old_lchan)</span><br><span>                      lchan->encr = info->old_lchan->encr;</span><br><span style="color: hsl(120, 100%, 40%);">+         else {</span><br><span style="color: hsl(120, 100%, 40%);">+                        lchan->encr = (struct gsm_encr){</span><br><span style="color: hsl(120, 100%, 40%);">+                           .alg_id = RSL_ENC_ALG_A5(0),    /* no encryption */</span><br><span style="color: hsl(120, 100%, 40%);">+                   };</span><br><span style="color: hsl(120, 100%, 40%);">+            }</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+           /* If there is a previous lchan, and the new lchan is on the same cell as previous one,</span><br><span style="color: hsl(120, 100%, 40%);">+                * take over power and TA values. Otherwise, use max power and zero TA. */</span><br><span style="color: hsl(120, 100%, 40%);">+            if (info->old_lchan && info->old_lchan->ts->trx->bts == bts) {</span><br><span>                        lchan->ms_power = info->old_lchan->ms_power;</span><br><span>                        lchan->bs_power = info->old_lchan->bs_power;</span><br><span>                        lchan->rqd_ta = info->old_lchan->rqd_ta;</span><br><span>            } else {</span><br><span style="color: hsl(0, 100%, 40%);">-                        struct gsm_bts *bts = lchan->ts->trx->bts;</span><br><span style="color: hsl(0, 100%, 40%);">-                     lchan->encr = (struct gsm_encr){</span><br><span style="color: hsl(0, 100%, 40%);">-                             .alg_id = RSL_ENC_ALG_A5(0),    /* no encryption */</span><br><span style="color: hsl(0, 100%, 40%);">-                     };</span><br><span>                   lchan->ms_power = ms_pwr_ctl_lvl(bts->band, bts->ms_max_power);</span><br><span style="color: hsl(0, 100%, 40%);">-                        lchan->bs_power = 0; /* 0dB reduction, output power = Pn */</span><br><span style="color: hsl(120, 100%, 40%);">+                        /* From lchan_reset():</span><br><span style="color: hsl(120, 100%, 40%);">+                         * - bs_power is still zero, 0dB reduction, output power = Pn.</span><br><span style="color: hsl(120, 100%, 40%);">+                         * - TA is still zero, to be determined by RACH. */</span><br><span>          }</span><br><span> </span><br><span>                if (info->chan_mode == GSM48_CMODE_SPEECH_AMR)</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/10701">change 10701</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/10701"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-bsc </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I360b003398487fa6f934296ff03643c33ec61a35 </div>
<div style="display:none"> Gerrit-Change-Number: 10701 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Neels Hofmeyr <nhofmeyr@sysmocom.de> </div>