<p>Harald Welte <strong>merged</strong> this change.</p><p><a href="https://gerrit.osmocom.org/10661">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Jenkins Builder: Verified
  Harald Welte: Looks good to me, approved

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">ipaccess: Allow passing return code in e1inp_line_ops->sign_link()<br><br>Change-Id: Ia83eead3622d86f55c1dc5e91acc78dde73a0367<br>---<br>M include/osmocom/abis/e1_input.h<br>M src/input/ipaccess.c<br>2 files changed, 3 insertions(+), 3 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/include/osmocom/abis/e1_input.h b/include/osmocom/abis/e1_input.h</span><br><span>index 3fbce5b..79455e1 100644</span><br><span>--- a/include/osmocom/abis/e1_input.h</span><br><span>+++ b/include/osmocom/abis/e1_input.h</span><br><span>@@ -173,6 +173,7 @@</span><br><span> </span><br><span>  struct e1inp_sign_link *        (*sign_link_up)(void *unit_info, struct e1inp_line *line, enum e1inp_sign_type type);</span><br><span>        void    (*sign_link_down)(struct e1inp_line *line);</span><br><span style="color: hsl(120, 100%, 40%);">+   /* Called when a new message arrives. -EBADF must be returned if the osmo_fd in link (msg->dst) is destroyed. */</span><br><span>  int     (*sign_link)(struct msgb *msg);</span><br><span> };</span><br><span> </span><br><span>diff --git a/src/input/ipaccess.c b/src/input/ipaccess.c</span><br><span>index 24a79ea..566fd64 100644</span><br><span>--- a/src/input/ipaccess.c</span><br><span>+++ b/src/input/ipaccess.c</span><br><span>@@ -279,7 +279,7 @@</span><br><span>                      " sign_link returned error: %s.\n", strerror(-rc));</span><br><span>   }</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-   return 0;</span><br><span style="color: hsl(120, 100%, 40%);">+     return rc;</span><br><span> err_msg:</span><br><span>       msgb_free(msg);</span><br><span> err:</span><br><span>@@ -790,8 +790,7 @@</span><br><span>                        "no action set for signalling messages.\n");</span><br><span>               goto err;</span><br><span>    }</span><br><span style="color: hsl(0, 100%, 40%);">-       link->line->ops->sign_link(msg);</span><br><span style="color: hsl(0, 100%, 40%);">-       return 0;</span><br><span style="color: hsl(120, 100%, 40%);">+     return link->line->ops->sign_link(msg);</span><br><span> </span><br><span> err:</span><br><span>         ipa_client_conn_close(link);</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/10661">change 10661</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/10661"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: libosmo-abis </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: merged </div>
<div style="display:none"> Gerrit-Change-Id: Ia83eead3622d86f55c1dc5e91acc78dde73a0367 </div>
<div style="display:none"> Gerrit-Change-Number: 10661 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Pau Espin Pedrol <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Harald Welte <laforge@gnumonks.org> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder (1000002) </div>