<p>Neels Hofmeyr has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/10635">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">inter-BSC HO incoming: drop old/wrong RTP port code<br><br>Drop nonsensical legacy code.<br><br>The Circuit Identifier Code in A/SCCPlite does *not* indicate the RTP port to<br>use. Rather, it indicates the MGW endpoint name to use when configuring the<br>BSC's side of the MGW endpoint, and only the MGW will ever know the RTP port.<br><br>Change-Id: I471bd5e5cc2a083dd37290aeaae5c334ca5f7eed<br>---<br>M src/osmo-bsc/handover_fsm.c<br>1 file changed, 0 insertions(+), 17 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/35/10635/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/osmo-bsc/handover_fsm.c b/src/osmo-bsc/handover_fsm.c</span><br><span>index e3e8ae1..a42f10c 100644</span><br><span>--- a/src/osmo-bsc/handover_fsm.c</span><br><span>+++ b/src/osmo-bsc/handover_fsm.c</span><br><span>@@ -487,25 +487,8 @@</span><br><span>      OSMO_STRLCPY_ARRAY(req->cell_id_target_name, gsm0808_cell_id_name(&req->cell_id_target));</span><br><span> </span><br><span>      if ((e = TLVP_GET(tp, GSM0808_IE_CIRCUIT_IDENTITY_CODE))) {</span><br><span style="color: hsl(0, 100%, 40%);">-             int timeslot;</span><br><span style="color: hsl(0, 100%, 40%);">-           int multiplex;</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span>               /* CIC is permitted in both AoIP and SCCPlite */</span><br><span>             req->msc_assigned_cic = osmo_load16be(e->val);</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">-            /* For SCCPlite, the CIC implies the RTP port to use */</span><br><span style="color: hsl(0, 100%, 40%);">-         if (sccplite) {</span><br><span style="color: hsl(0, 100%, 40%);">-                 timeslot = req->msc_assigned_cic & 0x1f;</span><br><span style="color: hsl(0, 100%, 40%);">-                 multiplex = (req->msc_assigned_cic & ~0x1f) >> 5;</span><br><span style="color: hsl(0, 100%, 40%);">-                  req->msc_assigned_rtp_port = mgcp_timeslot_to_port(multiplex, timeslot,</span><br><span style="color: hsl(0, 100%, 40%);">-                                                                         conn->sccp.msc->rtp_base);</span><br><span style="color: hsl(0, 100%, 40%);">-                     LOG_HO(conn, LOGL_DEBUG, "Derived RTP port from MSC assigned CIC:"</span><br><span style="color: hsl(0, 100%, 40%);">-                           " CIC=0x%x (timeslot=%d multiplex=%d) rtp_base=%d=0x%x RTP-port=%u\n",</span><br><span style="color: hsl(0, 100%, 40%);">-                        req->msc_assigned_cic, timeslot, multiplex,</span><br><span style="color: hsl(0, 100%, 40%);">-                          conn->sccp.msc->rtp_base, conn->sccp.msc->rtp_base,</span><br><span style="color: hsl(0, 100%, 40%);">-                         req->msc_assigned_rtp_port);</span><br><span style="color: hsl(0, 100%, 40%);">-          }</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span>    } else if (sccplite) {</span><br><span>               /* no CIC but SCCPlite: illegal */</span><br><span>           LOG_HO(conn, LOGL_ERROR, "SCCPlite MSC, but no CIC in incoming inter-BSC Handover\n");</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/10635">change 10635</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/10635"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-bsc </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I471bd5e5cc2a083dd37290aeaae5c334ca5f7eed </div>
<div style="display:none"> Gerrit-Change-Number: 10635 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Neels Hofmeyr <nhofmeyr@sysmocom.de> </div>