<p>Harald Welte <strong>merged</strong> this change.</p><p><a href="https://gerrit.osmocom.org/10590">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Jenkins Builder: Verified
  Harald Welte: Looks good to me, approved

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">osmo_mcast_sock: make sure SO_REUSEADDR is applied<br><br>virtphy uses UDP multicast to communicate with its osmo-bts-virtual<br>counterpart. At the momemnt SO_REUSEADDR is not applied for those<br>multicast connections because OSMO_SOCK_F_UDP_REUSEADDR is not set. This<br>makes prevents the proper function of UDP multicast.<br><br>- Make sure OSMO_SOCK_F_UDP_REUSEADDR is set<br><br>Change-Id: Ia1014ac5e0522e77178249cdc6398dec2168bffe<br>Depends: libosmocore I1399a428467ca12f1564a14eb8ffb294d4f59874<br>Related: OS#3497<br>---<br>M src/host/virt_phy/src/shared/osmo_mcast_sock.c<br>1 file changed, 3 insertions(+), 2 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/host/virt_phy/src/shared/osmo_mcast_sock.c b/src/host/virt_phy/src/shared/osmo_mcast_sock.c</span><br><span>index b52e005..9a713fc 100644</span><br><span>--- a/src/host/virt_phy/src/shared/osmo_mcast_sock.c</span><br><span>+++ b/src/host/virt_phy/src/shared/osmo_mcast_sock.c</span><br><span>@@ -17,7 +17,7 @@</span><br><span>                         uint16_t tx_mcast_port, bool loopback)</span><br><span> {</span><br><span>      int rc;</span><br><span style="color: hsl(0, 100%, 40%);">- unsigned int flags = OSMO_SOCK_F_CONNECT;</span><br><span style="color: hsl(120, 100%, 40%);">+     unsigned int flags = OSMO_SOCK_F_CONNECT | OSMO_SOCK_F_UDP_REUSEADDR;</span><br><span> </span><br><span>    if (!loopback)</span><br><span>               flags |= OSMO_SOCK_F_NO_MCAST_LOOP;</span><br><span>@@ -41,6 +41,7 @@</span><br><span>                          void *osmo_fd_data)</span><br><span> {</span><br><span>         int rc;</span><br><span style="color: hsl(120, 100%, 40%);">+       unsigned int flags = OSMO_SOCK_F_BIND | OSMO_SOCK_F_NO_MCAST_ALL | OSMO_SOCK_F_UDP_REUSEADDR;</span><br><span> </span><br><span>    ofd->cb = fd_rx_cb;</span><br><span>       ofd->when = BSC_FD_READ;</span><br><span>@@ -48,7 +49,7 @@</span><br><span> </span><br><span>  /* Create mcast client socket */</span><br><span>     rc = osmo_sock_init_ofd(ofd, AF_INET, SOCK_DGRAM, IPPROTO_UDP,</span><br><span style="color: hsl(0, 100%, 40%);">-                          NULL, mcast_port, OSMO_SOCK_F_BIND|OSMO_SOCK_F_NO_MCAST_ALL);</span><br><span style="color: hsl(120, 100%, 40%);">+                         NULL, mcast_port, flags);</span><br><span>    if (rc < 0) {</span><br><span>             perror("Could not create mcast client socket");</span><br><span>            return rc;</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/10590">change 10590</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/10590"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmocom-bb </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: merged </div>
<div style="display:none"> Gerrit-Change-Id: Ia1014ac5e0522e77178249cdc6398dec2168bffe </div>
<div style="display:none"> Gerrit-Change-Number: 10590 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: dexter <pmaier@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Harald Welte <laforge@gnumonks.org> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder (1000002) </div>