<p>Harald Welte <strong>merged</strong> this change.</p><p><a href="https://gerrit.osmocom.org/10571">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Jenkins Builder: Verified
  Harald Welte: Looks good to me, approved

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">cards: do not feed ascii as adm for sysmosim-gr1<br><br>When sysmosom-gr1 is used with a custom ADM key, then the ADM string is<br>not fed through h2b() like we see it with sysmo-usim-sjs1 for example.<br><br>- feed the ADM to h2b() before use<br><br>Change-Id: I0b7cab380b89612ed3b8318e014161038335fe1b<br>Related: OS#3405<br>---<br>M pySim/cards.py<br>1 file changed, 1 insertion(+), 1 deletion(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/pySim/cards.py b/pySim/cards.py</span><br><span>index 4dee0d8..e294f9a 100644</span><br><span>--- a/pySim/cards.py</span><br><span>+++ b/pySim/cards.py</span><br><span>@@ -338,7 +338,7 @@</span><br><span> </span><br><span>            # Authenticate using ADM PIN 5</span><br><span>               if p['pin_adm']:</span><br><span style="color: hsl(0, 100%, 40%);">-                        pin = p['pin_adm']</span><br><span style="color: hsl(120, 100%, 40%);">+                    pin = h2b(p['pin_adm'])</span><br><span>              else:</span><br><span>                        pin = h2b("4444444444444444")</span><br><span>              self._scc.verify_chv(5, pin)</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/10571">change 10571</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/10571"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: pysim </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: merged </div>
<div style="display:none"> Gerrit-Change-Id: I0b7cab380b89612ed3b8318e014161038335fe1b </div>
<div style="display:none"> Gerrit-Change-Number: 10571 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: dexter <pmaier@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Harald Welte <laforge@gnumonks.org> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder (1000002) </div>