<p>Harald Welte <strong>merged</strong> this change.</p><p><a href="https://gerrit.osmocom.org/9627">View Change</a></p><div style="white-space:pre-wrap">Approvals:
Harald Welte: Looks good to me, approved
Jenkins Builder: Verified
</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">log / comment tweaks<br><br>BSC_Tests: sprinkle logs to illustrate what the dyn PDCH tests expect.<br><br>BSC_Tests: tweak comment to mention that inter-BSC HO MT *does* allow N-CONNECT<br>from MSC.<br><br>f_tc_assignment_fr_a5_1_codec_missing: mark the missing IE beyond doubt.<br><br>Change-Id: I93c2914e766e200d89308cc81dd803e939b9b28c<br>---<br>M bsc/BSC_Tests.ttcn<br>1 file changed, 11 insertions(+), 1 deletion(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/bsc/BSC_Tests.ttcn b/bsc/BSC_Tests.ttcn</span><br><span>index e94b781..b44de9f 100644</span><br><span>--- a/bsc/BSC_Tests.ttcn</span><br><span>+++ b/bsc/BSC_Tests.ttcn</span><br><span>@@ -518,7 +518,8 @@</span><br><span> * Assignment Testing</span><br><span> ***********************************************************************/</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-/* Verify that the BSC refuses any BSSAP connection from the MSC (They are all BSC->MSC direction) */</span><br><span style="color: hsl(120, 100%, 40%);">+/* Verify that the BSC refuses any BSSAP connection from the MSC (They are all BSC->MSC direction,</span><br><span style="color: hsl(120, 100%, 40%);">+ * except for the inter-BSC handover, MT side) */</span><br><span> testcase TC_outbound_connect() runs on test_CT {</span><br><span> f_init(1);</span><br><span> </span><br><span>@@ -1630,6 +1631,8 @@</span><br><span> const OCT8 kc := '0001020304050607'O;</span><br><span> </span><br><span> ass_cmd.pdu.bssmap.assignmentRequest.channelType := valueof(ts_BSSMAP_IE_ChannelType);</span><br><span style="color: hsl(120, 100%, 40%);">+ /* Omit: ass_cmd.pdu.bssmap.assignmentRequest.codecList */</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> f_establish_fully(ass_cmd, exp_fail);</span><br><span> }</span><br><span> testcase TC_assignment_fr_a5_1_codec_missing() runs on test_CT {</span><br><span>@@ -2367,26 +2370,31 @@</span><br><span> </span><br><span> var RslChannelNr chan_nr := valueof(t_RslChanNr_Bm(6));</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+ log("TCH/F_PDCH pchan starts out in TCH/F mode:");</span><br><span> f_ts_dyn_mode_assert(0, 0, chan_nr.tn, TCHF_MODE);</span><br><span> /* The BSC will activate the dynamic PDCH by default, so confirm that */</span><br><span> rsl_unused := f_exp_ipa_rx(0, tr_RSL_IPA_PDCH_ACT(chan_nr));</span><br><span> f_ipa_tx(0, ts_RSL_IPA_PDCH_ACT_ACK(chan_nr, ts_RSL_IE_FrameNumber(2342)));</span><br><span> f_sleep(1.0);</span><br><span style="color: hsl(120, 100%, 40%);">+ log("TCH/F_PDCH pchan, PDCH ACT was ACKed, so now in PDCH mode:");</span><br><span> f_ts_dyn_mode_assert(0, 0, chan_nr.tn, PDCH_MODE);</span><br><span> </span><br><span> /* De-activate it via VTY */</span><br><span> f_dyn_ipa_pdch_deact(0, 0, chan_nr.tn);</span><br><span> f_sleep(1.0);</span><br><span style="color: hsl(120, 100%, 40%);">+ log("TCH/F_PDCH pchan, PDCH DEACT via VTY, so now back in TCH/F mode:");</span><br><span> f_ts_dyn_mode_assert(0, 0, chan_nr.tn, TCHF_MODE);</span><br><span> </span><br><span> /* re-activate it via VTY */</span><br><span> f_dyn_ipa_pdch_act(0, 0, chan_nr.tn);</span><br><span> f_sleep(1.0);</span><br><span style="color: hsl(120, 100%, 40%);">+ log("TCH/F_PDCH pchan, PDCH ACT via VTY, so now in PDCH mode:");</span><br><span> f_ts_dyn_mode_assert(0, 0, chan_nr.tn, PDCH_MODE);</span><br><span> </span><br><span> /* and finally de-activate it again */</span><br><span> f_dyn_ipa_pdch_deact(0, 0, chan_nr.tn);</span><br><span> f_sleep(1.0);</span><br><span style="color: hsl(120, 100%, 40%);">+ log("TCH/F_PDCH pchan, PDCH DEACT via VTY, so now back in TCH/F mode:");</span><br><span> f_ts_dyn_mode_assert(0, 0, chan_nr.tn, TCHF_MODE);</span><br><span> </span><br><span> /* clean up config */</span><br><span>@@ -2485,12 +2493,14 @@</span><br><span> </span><br><span> var RslChannelNr chan_nr := valueof(t_RslChanNr_PDCH(6));</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+ log("TCH/F_TCH/H_PDCH pchan starts out in disabled mode:");</span><br><span> f_ts_dyn_mode_assert(0, 0, chan_nr.tn, NONE_MODE);</span><br><span> /* The BSC will activate the dynamic PDCH by default, so confirm that */</span><br><span> rsl_unused := f_exp_ipa_rx(0, tr_RSL_CHAN_ACT_PDCH(chan_nr, ?));</span><br><span> </span><br><span> f_ipa_tx(0, ts_RSL_CHAN_ACT_ACK(chan_nr, 2342));</span><br><span> f_sleep(1.0);</span><br><span style="color: hsl(120, 100%, 40%);">+ log("TCH/F_TCH/H_PDCH requested to PDCH ACT on startup, which was ACKed, so now in PDCH:");</span><br><span> f_ts_dyn_mode_assert(0, 0, chan_nr.tn, PDCH_MODE);</span><br><span> </span><br><span> /* clean up config */</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/9627">change 9627</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/9627"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: osmo-ttcn3-hacks </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: merged </div>
<div style="display:none"> Gerrit-Change-Id: I93c2914e766e200d89308cc81dd803e939b9b28c </div>
<div style="display:none"> Gerrit-Change-Number: 9627 </div>
<div style="display:none"> Gerrit-PatchSet: 5 </div>
<div style="display:none"> Gerrit-Owner: Neels Hofmeyr <nhofmeyr@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Harald Welte <laforge@gnumonks.org> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder (1000002) </div>
<div style="display:none"> Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr@sysmocom.de> </div>