<p>Neels Hofmeyr has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/10538">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">use __FILE__, not __BASE_FILE__<br><br>The intention was to use the file's basename, but __BASE_FILE__ means "the root<br>file that is being parsed and contains #include statements".<br><br>If we had a function using __BASE_FILE__ and that was defined in an #included<br>file, __BASE_FILE__ would indicate the first file where the #include is, and<br>not the file where the function is defined. __BASE_FILE__ works for us because<br>we don't ever include function definitions that log something, so __BASE_FILE__<br>always coincides with __FILE__ for our logging; but still __BASE_FILE__ is<br>semantically the wrong constant.<br><br>Related: OS#2740<br>Change-Id: Ic6d9dafc96c9d467ae53be2cd41adcf26a4e5125<br>---<br>M include/osmocom/bsc/bsc_subscriber.h<br>1 file changed, 2 insertions(+), 2 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/38/10538/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/include/osmocom/bsc/bsc_subscriber.h b/include/osmocom/bsc/bsc_subscriber.h</span><br><span>index a7b3e53..93b3539 100644</span><br><span>--- a/include/osmocom/bsc/bsc_subscriber.h</span><br><span>+++ b/include/osmocom/bsc/bsc_subscriber.h</span><br><span>@@ -37,8 +37,8 @@</span><br><span>                                   const char *file, int line);</span><br><span> struct bsc_subscr *_bsc_subscr_put(struct bsc_subscr *bsub,</span><br><span>                                  const char *file, int line);</span><br><span style="color: hsl(0, 100%, 40%);">-#define bsc_subscr_get(bsub) _bsc_subscr_get(bsub, __BASE_FILE__, __LINE__)</span><br><span style="color: hsl(0, 100%, 40%);">-#define bsc_subscr_put(bsub) _bsc_subscr_put(bsub, __BASE_FILE__, __LINE__)</span><br><span style="color: hsl(120, 100%, 40%);">+#define bsc_subscr_get(bsub) _bsc_subscr_get(bsub, __FILE__, __LINE__)</span><br><span style="color: hsl(120, 100%, 40%);">+#define bsc_subscr_put(bsub) _bsc_subscr_put(bsub, __FILE__, __LINE__)</span><br><span> </span><br><span> void log_set_filter_bsc_subscr(struct log_target *target,</span><br><span>                              struct bsc_subscr *bsub);</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/10538">change 10538</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/10538"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-bsc </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: Ic6d9dafc96c9d467ae53be2cd41adcf26a4e5125 </div>
<div style="display:none"> Gerrit-Change-Number: 10538 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Neels Hofmeyr <nhofmeyr@sysmocom.de> </div>