<p>Neels Hofmeyr <strong>merged</strong> this change.</p><p><a href="https://gerrit.osmocom.org/10162">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Jenkins Builder: Verified
  Harald Welte: Looks good to me, approved

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">ipa_asp_fsm: init: expect IPA ID ACK, not GET<br><br>Testing with an actual SCCPlite MSC, I see the IPA connection starting out by<br>the MSC sending an IPA ID ACK. Make the ipa_asp_fsm match that.<br><br>Change-Id: Icffda98579e676ab6ca63c9c22cf5d151c4fe95f<br>---<br>M src/xua_asp_fsm.c<br>1 file changed, 2 insertions(+), 2 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/xua_asp_fsm.c b/src/xua_asp_fsm.c</span><br><span>index 78a4f25..d6edac0 100644</span><br><span>--- a/src/xua_asp_fsm.c</span><br><span>+++ b/src/xua_asp_fsm.c</span><br><span>@@ -785,7 +785,7 @@</span><br><span>                   }</span><br><span>            } else {</span><br><span>                     /* Client: We simply wait for an ID GET */</span><br><span style="color: hsl(0, 100%, 40%);">-                      osmo_fsm_inst_state_chg(fi, IPA_ASP_S_WAIT_ID_GET, 10, T_WAIT_ID_GET);</span><br><span style="color: hsl(120, 100%, 40%);">+                        osmo_fsm_inst_state_chg(fi, IPA_ASP_S_WAIT_ID_ACK, 10, T_WAIT_ID_ACK);</span><br><span>               }</span><br><span>            break;</span><br><span>       }</span><br><span>@@ -985,7 +985,7 @@</span><br><span>      [IPA_ASP_S_DOWN] = {</span><br><span>                 .in_event_mask = S(XUA_ASP_E_M_ASP_UP_REQ) |</span><br><span>                                  S(XUA_ASP_E_SCTP_EST_IND),</span><br><span style="color: hsl(0, 100%, 40%);">-             .out_state_mask = S(IPA_ASP_S_WAIT_ID_GET) |</span><br><span style="color: hsl(120, 100%, 40%);">+          .out_state_mask = S(IPA_ASP_S_WAIT_ID_ACK) |</span><br><span>                                   S(IPA_ASP_S_WAIT_ID_RESP),</span><br><span>                 .name = "ASP_DOWN",</span><br><span>                .action = ipa_asp_fsm_down,</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/10162">change 10162</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/10162"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: libosmo-sccp </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: merged </div>
<div style="display:none"> Gerrit-Change-Id: Icffda98579e676ab6ca63c9c22cf5d151c4fe95f </div>
<div style="display:none"> Gerrit-Change-Number: 10162 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: Neels Hofmeyr <nhofmeyr@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Harald Welte <laforge@gnumonks.org> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder (1000002) </div>
<div style="display:none"> Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr@sysmocom.de> </div>