<p>Neels Hofmeyr <strong>merged</strong> this change.</p><p><a href="https://gerrit.osmocom.org/10556">View Change</a></p><div style="white-space:pre-wrap">Approvals:
Harald Welte: Looks good to me, approved
Jenkins Builder: Verified
</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">fix handling of "Wrong domain name" error<br><br>If no endpoint was found, assert that the cause code indicates error, so that<br>the remaining code path doesn't assume finding an endpoint was successful.<br><br>Also fix find_endpoint() to return an error cause (not 0) in case it finds the<br>domain name to be wrong.<br><br>After this, the error described in OS#3488 simply results in a CRCX failure,<br>not in a program crash.<br><br>Related: OS#3488<br>Change-Id: I87e2d76c22603d6fef89907c3cf8f7965abf35a0<br>---<br>M src/libosmo-mgcp/mgcp_msg.c<br>1 file changed, 2 insertions(+), 0 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/libosmo-mgcp/mgcp_msg.c b/src/libosmo-mgcp/mgcp_msg.c</span><br><span>index 8d22cc5..7378ddc 100644</span><br><span>--- a/src/libosmo-mgcp/mgcp_msg.c</span><br><span>+++ b/src/libosmo-mgcp/mgcp_msg.c</span><br><span>@@ -241,6 +241,7 @@</span><br><span> /* Check if the domainname in the request is correct */</span><br><span> if (check_domain_name(cfg, mgcp)) {</span><br><span> LOGP(DLMGCP, LOGL_ERROR, "Wrong domain name '%s'\n", mgcp);</span><br><span style="color: hsl(120, 100%, 40%);">+ *cause = -500;</span><br><span> return NULL;</span><br><span> }</span><br><span> </span><br><span>@@ -320,6 +321,7 @@</span><br><span> if (!pdata->endp) {</span><br><span> LOGP(DLMGCP, LOGL_ERROR,</span><br><span> "Unable to find Endpoint `%s'\n", elem);</span><br><span style="color: hsl(120, 100%, 40%);">+ OSMO_ASSERT(cause < 0);</span><br><span> return cause;</span><br><span> }</span><br><span> break;</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/10556">change 10556</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/10556"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: osmo-mgw </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: merged </div>
<div style="display:none"> Gerrit-Change-Id: I87e2d76c22603d6fef89907c3cf8f7965abf35a0 </div>
<div style="display:none"> Gerrit-Change-Number: 10556 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Neels Hofmeyr <nhofmeyr@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Harald Welte <laforge@gnumonks.org> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder (1000002) </div>
<div style="display:none"> Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr@sysmocom.de> </div>