<p>Harald Welte <strong>merged</strong> this change.</p><p><a href="https://gerrit.osmocom.org/10481">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Jenkins Builder: Verified
  Vadim Yanitskiy: Looks good to me, but someone else must approve
  Harald Welte: Looks good to me, approved

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">signal: Introduce API osmo_signal_talloc_ctx_init<br><br>Otherwise applications need to use "extern void* tall_sigh_ctx" and set<br>it manually (that symbol is not exported in any header file) or end up<br>allocating struct signal_handler into the NULL talloc ctx.<br><br>API created in a similar way as already existing msgb_talloc_ctx_init(),<br>but without the pool_size because it's not considered necessary in this<br>case.<br><br>Change-Id: Id58ca18eb826b8f4183a7cf0dbb2b38cba702a09<br>---<br>M include/osmocom/core/signal.h<br>M src/signal.c<br>2 files changed, 10 insertions(+), 0 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/include/osmocom/core/signal.h b/include/osmocom/core/signal.h</span><br><span>index ae78f15..449b976 100644</span><br><span>--- a/include/osmocom/core/signal.h</span><br><span>+++ b/include/osmocom/core/signal.h</span><br><span>@@ -34,6 +34,7 @@</span><br><span> </span><br><span> </span><br><span> /* Management */</span><br><span style="color: hsl(120, 100%, 40%);">+void *osmo_signal_talloc_ctx_init(void *root_ctx);</span><br><span> int osmo_signal_register_handler(unsigned int subsys, osmo_signal_cbfn *cbfn, void *data);</span><br><span> void osmo_signal_unregister_handler(unsigned int subsys, osmo_signal_cbfn *cbfn, void *data);</span><br><span> </span><br><span>diff --git a/src/signal.c b/src/signal.c</span><br><span>index 745d7c3..188876b 100644</span><br><span>--- a/src/signal.c</span><br><span>+++ b/src/signal.c</span><br><span>@@ -46,6 +46,15 @@</span><br><span>       void *data;</span><br><span> };</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+/*! Initialize a signal_handler talloc context for \ref osmo_signal_register_handler.</span><br><span style="color: hsl(120, 100%, 40%);">+ * Create a talloc context called "osmo_signal".</span><br><span style="color: hsl(120, 100%, 40%);">+ *  \param[in] root_ctx talloc context used as parent for the new "osmo_signal" ctx.</span><br><span style="color: hsl(120, 100%, 40%);">+ *  \returns the new osmo_signal talloc context, e.g. for reporting</span><br><span style="color: hsl(120, 100%, 40%);">+ */</span><br><span style="color: hsl(120, 100%, 40%);">+void *osmo_signal_talloc_ctx_init(void *root_ctx) {</span><br><span style="color: hsl(120, 100%, 40%);">+       tall_sigh_ctx = talloc_named_const(tall_sigh_ctx, 0, "osmo_signal");</span><br><span style="color: hsl(120, 100%, 40%);">+        return tall_sigh_ctx;</span><br><span style="color: hsl(120, 100%, 40%);">+}</span><br><span> </span><br><span> /*! Register a new signal handler</span><br><span>  *  \param[in] subsys Subsystem number</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/10481">change 10481</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/10481"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: libosmocore </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: merged </div>
<div style="display:none"> Gerrit-Change-Id: Id58ca18eb826b8f4183a7cf0dbb2b38cba702a09 </div>
<div style="display:none"> Gerrit-Change-Number: 10481 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: Pau Espin Pedrol <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Harald Welte <laforge@gnumonks.org> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: Pau Espin Pedrol <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Vadim Yanitskiy <axilirator@gmail.com> </div>