<p>Pau Espin Pedrol has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/10444">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">xua_rkm: Fix xua_msg memleank in handle_rkey_reg_resp<br><br>From LeakSanitizer report:<br>Indirect leak of 384 byte(s) in 3 object(s) allocated from:<br> #0 0x7f986da27d99 in __interceptor_malloc /build/gcc/src/gcc/libsanitizer/asan/asan_malloc_linux.cc:86<br> #1 0x7f9868d0cb61 in _talloc_zero (/usr/lib/libtalloc.so.2+0x5b61)<br> #2 0x7f986ad33766 in xua_msg_add_data /home/pespin/dev/sysmocom/git/libosmo-sccp/src/xua_msg.c:73<br> #3 0x7f986ad343c3 in xua_from_msg_common /home/pespin/dev/sysmocom/git/libosmo-sccp/src/xua_msg.c:143<br> #4 0x7f986ad347d2 in xua_from_nested /home/pespin/dev/sysmocom/git/libosmo-sccp/src/xua_msg.c:201<br> #5 0x7f986ad65563 in m3ua_rx_rkm_reg_rsp /home/pespin/dev/sysmocom/git/libosmo-sccp/src/xua_rkm.c:431<br> #6 0x7f986ad65f96 in m3ua_rx_rkm /home/pespin/dev/sysmocom/git/libosmo-sccp/src/xua_rkm.c:510<br> #7 0x7f986ad31ef7 in m3ua_rx_msg /home/pespin/dev/sysmocom/git/libosmo-sccp/src/m3ua.c:749<br> #8 0x7f986ad7c1e8 in xua_cli_read_cb /home/pespin/dev/sysmocom/git/libosmo-sccp/src/osmo_ss7.c:1590<br> #9 0x7f986a66cdb4 in osmo_stream_cli_read /home/pespin/dev/sysmocom/git/libosmo-netif/src/stream.c:192<br> #10 0x7f986a66e091 in osmo_stream_cli_fd_cb /home/pespin/dev/sysmocom/git/libosmo-netif/src/stream.c:276<br> #11 0x7f986994e795 in osmo_fd_disp_fds /home/pespin/dev/sysmocom/git/libosmocore/src/select.c:217<br> #12 0x7f986994eabb in osmo_select_main /home/pespin/dev/sysmocom/git/libosmocore/src/select.c:257<br> #13 0x5630cb294bd3 in main /home/pespin/dev/sysmocom/git/osmo-msc/src/osmo-msc/msc_main.c:697<br> #14 0x7f98678b806a in __libc_start_main (/usr/lib/libc.so.6+0x2306a)<br> #15 0x5630cb292649 in _start (/home/pespin/dev/sysmocom/build/new/out/bin/osmo-msc+0x185649)<br><br>Following code paths:<br>m3ua_rx_rkm_reg_rsp<br> xua_from_nested<br> xua_from_msg_common<br> xua_msg_add_data<br> talloc_zero (part)<br> handle_rkey_reg_resp<br><br>Take the chance to fix the same issue in m3ua_rx_rkm_dereg_rsp.<br><br>Change-Id: I0b15d81099a9f8274b7e39962caa339da644e0dc<br>---<br>M src/xua_rkm.c<br>1 file changed, 2 insertions(+), 0 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/libosmo-sccp refs/changes/44/10444/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/xua_rkm.c b/src/xua_rkm.c</span><br><span>index b79f7f3..a77460d 100644</span><br><span>--- a/src/xua_rkm.c</span><br><span>+++ b/src/xua_rkm.c</span><br><span>@@ -433,6 +433,7 @@</span><br><span> continue;</span><br><span> </span><br><span> handle_rkey_reg_resp(asp, inner);</span><br><span style="color: hsl(120, 100%, 40%);">+ xua_msg_free(inner);</span><br><span> }</span><br><span> return 0;</span><br><span> }</span><br><span>@@ -485,6 +486,7 @@</span><br><span> continue;</span><br><span> </span><br><span> handle_rkey_dereg_resp(asp, inner);</span><br><span style="color: hsl(120, 100%, 40%);">+ xua_msg_free(inner);</span><br><span> }</span><br><span> return 0;</span><br><span> }</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/10444">change 10444</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/10444"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: libosmo-sccp </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I0b15d81099a9f8274b7e39962caa339da644e0dc </div>
<div style="display:none"> Gerrit-Change-Number: 10444 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Pau Espin Pedrol <pespin@sysmocom.de> </div>