<p>Harald Welte <strong>merged</strong> this change.</p><p><a href="https://gerrit.osmocom.org/10428">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Vadim Yanitskiy: Looks good to me, but someone else must approve
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">libmsc/mncc_sock.c: Add lchan_type_offset in queue_hello()<br><br>lchan_type was removed from gsm_mncc and the hello message<br>on initial import from legacy OpenBSC in <br>Change-Id: Id3705236350d5f69e447046b0a764bbabc3d493c<br><br>This patch follows on from Change-Id: Ia02373a36df7605507ee3de49173a9fd6547b726<br>which reintroduced lchan_type to the gsm_mncc struct.<br><br>This patch restores the lchan_type_offset to the hello protocol message<br><br>Without this patch, LCR will issue an error and disconnect from the MNCC socket.<br><br>Change-Id: I65312082fa5dc0721170f923840e992ef9481a63<br>Closes: OS#3461<br>---<br>M src/libmsc/mncc_sock.c<br>1 file changed, 1 insertion(+), 0 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/libmsc/mncc_sock.c b/src/libmsc/mncc_sock.c</span><br><span>index 74ea9d2..57b4bd8 100644</span><br><span>--- a/src/libmsc/mncc_sock.c</span><br><span>+++ b/src/libmsc/mncc_sock.c</span><br><span>@@ -228,6 +228,7 @@</span><br><span>       hello->called_offset = offsetof(struct gsm_mncc, called);</span><br><span>         hello->signal_offset = offsetof(struct gsm_mncc, signal);</span><br><span>         hello->emergency_offset = offsetof(struct gsm_mncc, emergency);</span><br><span style="color: hsl(120, 100%, 40%);">+    hello->lchan_type_offset = offsetof(struct gsm_mncc, lchan_type);</span><br><span> </span><br><span>     msgb_enqueue(&mncc->net->upqueue, msg);</span><br><span>    mncc->conn_bfd.when |= BSC_FD_WRITE;</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/10428">change 10428</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/10428"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-msc </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: merged </div>
<div style="display:none"> Gerrit-Change-Id: I65312082fa5dc0721170f923840e992ef9481a63 </div>
<div style="display:none"> Gerrit-Change-Number: 10428 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: Keith Whyte <keith@rhizomatica.org> </div>
<div style="display:none"> Gerrit-Reviewer: Harald Welte <laforge@gnumonks.org> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: Vadim Yanitskiy <axilirator@gmail.com> </div>