<p>Harald Welte <strong>merged</strong> this change.</p><p><a href="https://gerrit.osmocom.org/10372">View Change</a></p><div style="white-space:pre-wrap">Approvals:
Harald Welte: Looks good to me, approved
Jenkins Builder: Verified
</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">add DTX fill frame BTS tests<br><br>Add tests TC_tch_sign_l2_fill_frame and TC_tch_sign_l2_fill_frame_dtxd.<br><br>TC_tch_sign_l2_fill_frame is already passing and verifies that fill<br>frames are sent if there is nothing else to transmit on a SDCCH4/SDCCH8,<br>TCH/H, or TCH/F signalling channel where DTX is disabled for downlink.<br><br>TC_tch_sign_l2_fill_frame_dtxd is currently failing. It verifies that<br>only specific fill frames are sent, as required by GSM 05.08 for TCHF<br>signalling channels with DTX enabled for downlink. At present, our<br>implementation generates no fill frames in this case, which is one<br>piece of the problem described in issue OS#1950.<br><br>Change-Id: Id4e0de6e78b62cd408f600a57a28617d91da64af<br>Related: OS#1950<br>---<br>M bts/BTS_Tests.ttcn<br>M bts/expected-results.xml<br>M library/RSL_Types.ttcn<br>3 files changed, 196 insertions(+), 4 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/bts/BTS_Tests.ttcn b/bts/BTS_Tests.ttcn</span><br><span>index fb6137c..890be91 100644</span><br><span>--- a/bts/BTS_Tests.ttcn</span><br><span>+++ b/bts/BTS_Tests.ttcn</span><br><span>@@ -3794,6 +3794,187 @@</span><br><span> f_assert_lapdm('03e00d063505'O, tr_LAPDm_I(0, true, false, 7, 0, '063505'O), "I/7/0");</span><br><span> }</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+/***********************************************************************</span><br><span style="color: hsl(120, 100%, 40%);">+ * DTX Related (see GSM 05.08, section 8.3)</span><br><span style="color: hsl(120, 100%, 40%);">+ ***********************************************************************/</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+/* XXX These functions must be kept in sync with g_AllChannels defined on test_CT. */</span><br><span style="color: hsl(120, 100%, 40%);">+function f_g_chan_is_tchf() runs on ConnHdlr return boolean {</span><br><span style="color: hsl(120, 100%, 40%);">+ return (g_chan_nr == valueof(ts_RslChanNr_Bm(1)) or</span><br><span style="color: hsl(120, 100%, 40%);">+ g_chan_nr == valueof(ts_RslChanNr_Bm(2)) or</span><br><span style="color: hsl(120, 100%, 40%);">+ g_chan_nr == valueof(ts_RslChanNr_Bm(3)) or</span><br><span style="color: hsl(120, 100%, 40%);">+ g_chan_nr == valueof(ts_RslChanNr_Bm(4)));</span><br><span style="color: hsl(120, 100%, 40%);">+}</span><br><span style="color: hsl(120, 100%, 40%);">+function f_g_chan_is_tchh() runs on ConnHdlr return boolean {</span><br><span style="color: hsl(120, 100%, 40%);">+ return (g_chan_nr == valueof(ts_RslChanNr_Lm(5,0)) or</span><br><span style="color: hsl(120, 100%, 40%);">+ g_chan_nr == valueof(ts_RslChanNr_Lm(5,1)));</span><br><span style="color: hsl(120, 100%, 40%);">+}</span><br><span style="color: hsl(120, 100%, 40%);">+function f_g_chan_is_sdcch4() runs on ConnHdlr return boolean {</span><br><span style="color: hsl(120, 100%, 40%);">+ return (g_chan_nr == valueof(ts_RslChanNr_SDCCH4(0,0)) or</span><br><span style="color: hsl(120, 100%, 40%);">+ g_chan_nr == valueof(ts_RslChanNr_SDCCH4(0,1)) or</span><br><span style="color: hsl(120, 100%, 40%);">+ g_chan_nr == valueof(ts_RslChanNr_SDCCH4(0,2)) or</span><br><span style="color: hsl(120, 100%, 40%);">+ g_chan_nr == valueof(ts_RslChanNr_SDCCH4(0,3)));</span><br><span style="color: hsl(120, 100%, 40%);">+}</span><br><span style="color: hsl(120, 100%, 40%);">+function f_g_chan_is_sdcch8() runs on ConnHdlr return boolean {</span><br><span style="color: hsl(120, 100%, 40%);">+ return (g_chan_nr == valueof(ts_RslChanNr_SDCCH8(6,0)) or</span><br><span style="color: hsl(120, 100%, 40%);">+ g_chan_nr == valueof(ts_RslChanNr_SDCCH8(6,1)) or</span><br><span style="color: hsl(120, 100%, 40%);">+ g_chan_nr == valueof(ts_RslChanNr_SDCCH8(6,2)) or</span><br><span style="color: hsl(120, 100%, 40%);">+ g_chan_nr == valueof(ts_RslChanNr_SDCCH8(6,3)) or</span><br><span style="color: hsl(120, 100%, 40%);">+ g_chan_nr == valueof(ts_RslChanNr_SDCCH8(6,4)) or</span><br><span style="color: hsl(120, 100%, 40%);">+ g_chan_nr == valueof(ts_RslChanNr_SDCCH8(6,5)) or</span><br><span style="color: hsl(120, 100%, 40%);">+ g_chan_nr == valueof(ts_RslChanNr_SDCCH8(6,6)) or</span><br><span style="color: hsl(120, 100%, 40%);">+ g_chan_nr == valueof(ts_RslChanNr_SDCCH8(6,7)));</span><br><span style="color: hsl(120, 100%, 40%);">+}</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+function f_test_l2_fill_frames(boolean dtxd) runs on ConnHdlr {</span><br><span style="color: hsl(120, 100%, 40%);">+ var L1ctlDlMessage dl;</span><br><span style="color: hsl(120, 100%, 40%);">+ var octetstring l2_fill_frame := '0303012B2B2B2B2B2B2B2B2B2B2B2B2B2B2B2B2B2B2B2B'O;</span><br><span style="color: hsl(120, 100%, 40%);">+ var octetstring l2_fill_frame_sacch := substr(l2_fill_frame, 0, lengthof(l2_fill_frame) - 2);</span><br><span style="color: hsl(120, 100%, 40%);">+ var GsmFrameNumber first_fn;</span><br><span style="color: hsl(120, 100%, 40%);">+ var boolean is_first_frame := true;</span><br><span style="color: hsl(120, 100%, 40%);">+ var integer nfill_frames := 0;</span><br><span style="color: hsl(120, 100%, 40%);">+ const integer dtx_tchf_mod := 104;</span><br><span style="color: hsl(120, 100%, 40%);">+ /* Frames numbers (mod 104) for which a fill frame is expected on TCHF if DTX is enabled. */</span><br><span style="color: hsl(120, 100%, 40%);">+ var Integers required_tdma_frames_dtx_tchf := { 52, 53, 54, 55, 56, 57, 58, 59 };</span><br><span style="color: hsl(120, 100%, 40%);">+ timer T := 5.0;</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ f_l1_tune(L1CTL);</span><br><span style="color: hsl(120, 100%, 40%);">+ RSL.clear;</span><br><span style="color: hsl(120, 100%, 40%);">+ L1CTL.clear;</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ /* activate TCHF signalling channel */</span><br><span style="color: hsl(120, 100%, 40%);">+ f_est_dchan(false);</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ T.start;</span><br><span style="color: hsl(120, 100%, 40%);">+ alt {</span><br><span style="color: hsl(120, 100%, 40%);">+ [] L1CTL.receive(tr_L1CTL_DATA_IND(g_chan_nr, ?)) -> value dl {</span><br><span style="color: hsl(120, 100%, 40%);">+ var GsmFrameNumber fn := dl.dl_info.frame_nr;</span><br><span style="color: hsl(120, 100%, 40%);">+ var octetstring l2 := dl.payload.data_ind.payload;</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ if (is_first_frame) {</span><br><span style="color: hsl(120, 100%, 40%);">+ is_first_frame := false;</span><br><span style="color: hsl(120, 100%, 40%);">+ first_fn := dl.dl_info.frame_nr;</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ if (dl.dl_info.link_id.c == SACCH) {</span><br><span style="color: hsl(120, 100%, 40%);">+ l2 := substr(l2, 2, lengthof(l2) - 2); /* remove L1 header */</span><br><span style="color: hsl(120, 100%, 40%);">+ if (not match(l2_fill_frame_sacch, l2)) {</span><br><span style="color: hsl(120, 100%, 40%);">+ repeat;</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+ } else if (not match(l2_fill_frame, l2)) {</span><br><span style="color: hsl(120, 100%, 40%);">+ repeat;</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ if (dtxd) {</span><br><span style="color: hsl(120, 100%, 40%);">+ if (not f_g_chan_is_tchf()) {</span><br><span style="color: hsl(120, 100%, 40%);">+ T.stop;</span><br><span style="color: hsl(120, 100%, 40%);">+ f_rsl_chan_deact();</span><br><span style="color: hsl(120, 100%, 40%);">+ f_L1CTL_DM_REL_REQ(L1CTL, g_chan_nr);</span><br><span style="color: hsl(120, 100%, 40%);">+ setverdict(fail, "Received fill frame on non-TCH/F channel; DTX is only allowed on TCH/F!");</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+ if (fn >= first_fn + dtx_tchf_mod) {</span><br><span style="color: hsl(120, 100%, 40%);">+ T.stop;</span><br><span style="color: hsl(120, 100%, 40%);">+ f_rsl_chan_deact();</span><br><span style="color: hsl(120, 100%, 40%);">+ f_L1CTL_DM_REL_REQ(L1CTL, g_chan_nr);</span><br><span style="color: hsl(120, 100%, 40%);">+ /* With DTX enabled we can expect at least 1 fill frame every 104 frames. */</span><br><span style="color: hsl(120, 100%, 40%);">+ if (nfill_frames < 1) {</span><br><span style="color: hsl(120, 100%, 40%);">+ setverdict(fail);</span><br><span style="color: hsl(120, 100%, 40%);">+ } else {</span><br><span style="color: hsl(120, 100%, 40%);">+ setverdict(pass);</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+ for (var integer i := 0; i < lengthof(required_tdma_frames_dtx_tchf); i := i + 1) {</span><br><span style="color: hsl(120, 100%, 40%);">+ if (fn mod dtx_tchf_mod == required_tdma_frames_dtx_tchf[i]) {</span><br><span style="color: hsl(120, 100%, 40%);">+ nfill_frames := nfill_frames + 1;</span><br><span style="color: hsl(120, 100%, 40%);">+ repeat;</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+ log("Received DTX TCH fill frame with bad frame number: ", fn,</span><br><span style="color: hsl(120, 100%, 40%);">+ " (mod ", dtx_tchf_mod, ": ", fn mod dtx_tchf_mod, ")");</span><br><span style="color: hsl(120, 100%, 40%);">+ f_rsl_chan_deact();</span><br><span style="color: hsl(120, 100%, 40%);">+ f_L1CTL_DM_REL_REQ(L1CTL, g_chan_nr);</span><br><span style="color: hsl(120, 100%, 40%);">+ setverdict(fail, "Unexpected L2 fill frame received on Um");</span><br><span style="color: hsl(120, 100%, 40%);">+ } else {</span><br><span style="color: hsl(120, 100%, 40%);">+ nfill_frames := nfill_frames + 1;</span><br><span style="color: hsl(120, 100%, 40%);">+ if (fn >= first_fn + dtx_tchf_mod) {</span><br><span style="color: hsl(120, 100%, 40%);">+ var integer expected_fill_frames;</span><br><span style="color: hsl(120, 100%, 40%);">+ T.stop;</span><br><span style="color: hsl(120, 100%, 40%);">+ if (f_g_chan_is_tchf()) {</span><br><span style="color: hsl(120, 100%, 40%);">+ /* Without DTX we can expect 25 fill frames for every 104 frames.</span><br><span style="color: hsl(120, 100%, 40%);">+ * (24 FACCH + 1 SACCH filling) */</span><br><span style="color: hsl(120, 100%, 40%);">+ expected_fill_frames := 25;</span><br><span style="color: hsl(120, 100%, 40%);">+ } else if (f_g_chan_is_tchh()) {</span><br><span style="color: hsl(120, 100%, 40%);">+ /* We can expect 2 fill frames for every 104 frames. */</span><br><span style="color: hsl(120, 100%, 40%);">+ expected_fill_frames := 2;</span><br><span style="color: hsl(120, 100%, 40%);">+ } else if (f_g_chan_is_sdcch4() or f_g_chan_is_sdcch8()) {</span><br><span style="color: hsl(120, 100%, 40%);">+ /* We can expect 5 fill frames for every 104 frames. */</span><br><span style="color: hsl(120, 100%, 40%);">+ expected_fill_frames := 5;</span><br><span style="color: hsl(120, 100%, 40%);">+ } else {</span><br><span style="color: hsl(120, 100%, 40%);">+ f_rsl_chan_deact();</span><br><span style="color: hsl(120, 100%, 40%);">+ f_L1CTL_DM_REL_REQ(L1CTL, g_chan_nr);</span><br><span style="color: hsl(120, 100%, 40%);">+ setverdict(fail, "Unknown channel type");</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ f_rsl_chan_deact();</span><br><span style="color: hsl(120, 100%, 40%);">+ f_L1CTL_DM_REL_REQ(L1CTL, g_chan_nr);</span><br><span style="color: hsl(120, 100%, 40%);">+ if (nfill_frames >= expected_fill_frames) {</span><br><span style="color: hsl(120, 100%, 40%);">+ setverdict(pass);</span><br><span style="color: hsl(120, 100%, 40%);">+ } else {</span><br><span style="color: hsl(120, 100%, 40%);">+ setverdict(fail, "Not enough fill frames received");</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+ } else {</span><br><span style="color: hsl(120, 100%, 40%);">+ repeat;</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+ [] L1CTL.receive { repeat; }</span><br><span style="color: hsl(120, 100%, 40%);">+ [] T.timeout {</span><br><span style="color: hsl(120, 100%, 40%);">+ f_rsl_chan_deact();</span><br><span style="color: hsl(120, 100%, 40%);">+ f_L1CTL_DM_REL_REQ(L1CTL, g_chan_nr);</span><br><span style="color: hsl(120, 100%, 40%);">+ setverdict(fail, "Timeout waiting for L2 fill frames on Um");</span><br><span style="color: hsl(120, 100%, 40%);">+ mtc.stop;</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+}</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+function f_TC_tch_sign_l2_fill_frame(charstring id) runs on ConnHdlr {</span><br><span style="color: hsl(120, 100%, 40%);">+ f_test_l2_fill_frames(false);</span><br><span style="color: hsl(120, 100%, 40%);">+}</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+function f_TC_tch_sign_l2_fill_frame_dtxd(charstring id) runs on ConnHdlr {</span><br><span style="color: hsl(120, 100%, 40%);">+ f_test_l2_fill_frames(true);</span><br><span style="color: hsl(120, 100%, 40%);">+}</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+function f_tch_sign_l2_fill_frame(boolean dtxd) runs on test_CT {</span><br><span style="color: hsl(120, 100%, 40%);">+ var ConnHdlr vc_conn;</span><br><span style="color: hsl(120, 100%, 40%);">+ var ConnHdlrPars pars;</span><br><span style="color: hsl(120, 100%, 40%);">+ pars.t_guard := 60.0;</span><br><span style="color: hsl(120, 100%, 40%);">+ f_init(testcasename());</span><br><span style="color: hsl(120, 100%, 40%);">+ for (var integer i := 0; i < sizeof(g_AllChannels); i := i + 1) {</span><br><span style="color: hsl(120, 100%, 40%);">+ pars := valueof(t_Pars(g_AllChannels[i], ts_RSL_ChanMode_SIGN(dtxd)));</span><br><span style="color: hsl(120, 100%, 40%);">+ if (dtxd) {</span><br><span style="color: hsl(120, 100%, 40%);">+ if (i >= 4) { /* DTX is only allowed on TCH/F */</span><br><span style="color: hsl(120, 100%, 40%);">+ break;</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+ vc_conn := f_start_handler(refers(f_TC_tch_sign_l2_fill_frame_dtxd), pars);</span><br><span style="color: hsl(120, 100%, 40%);">+ } else {</span><br><span style="color: hsl(120, 100%, 40%);">+ vc_conn := f_start_handler(refers(f_TC_tch_sign_l2_fill_frame), pars);</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+ vc_conn.done;</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+}</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+/* Verify that L2 fill frames are sent on TCH in signaling mode if</span><br><span style="color: hsl(120, 100%, 40%);">+ * there is nothing to transmit while DTX is disabled on downlink. */</span><br><span style="color: hsl(120, 100%, 40%);">+testcase TC_tch_sign_l2_fill_frame() runs on test_CT {</span><br><span style="color: hsl(120, 100%, 40%);">+ f_tch_sign_l2_fill_frame(false);</span><br><span style="color: hsl(120, 100%, 40%);">+}</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+/* Verify that particular L2 fill frames are sent on TCH in signaling mode if</span><br><span style="color: hsl(120, 100%, 40%);">+ * there is nothing to transmit while DTX is enabled on downlink. */</span><br><span style="color: hsl(120, 100%, 40%);">+testcase TC_tch_sign_l2_fill_frame_dtxd() runs on test_CT {</span><br><span style="color: hsl(120, 100%, 40%);">+ f_tch_sign_l2_fill_frame(true);</span><br><span style="color: hsl(120, 100%, 40%);">+}</span><br><span> </span><br><span> /* test generation of RLL ERR IND based on Um errors (TS 48.058 3.9) */</span><br><span> /* protocol error as per 44.006 */</span><br><span>@@ -3926,6 +4107,9 @@</span><br><span> execute( TC_encr_cmd_a53() );</span><br><span> </span><br><span> execute( TC_lapdm_selftest() );</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ execute( TC_tch_sign_l2_fill_frame() );</span><br><span style="color: hsl(120, 100%, 40%);">+ execute( TC_tch_sign_l2_fill_frame_dtxd() );</span><br><span> }</span><br><span> </span><br><span> </span><br><span>diff --git a/bts/expected-results.xml b/bts/expected-results.xml</span><br><span>index d1a65a3..8bfd305 100644</span><br><span>--- a/bts/expected-results.xml</span><br><span>+++ b/bts/expected-results.xml</span><br><span>@@ -85,4 +85,11 @@</span><br><span> <testcase classname='BTS_Tests' name='TC_encr_cmd_a52' time='MASKED'/></span><br><span> <testcase classname='BTS_Tests' name='TC_encr_cmd_a53' time='MASKED'/></span><br><span> <testcase classname='BTS_Tests' name='TC_lapdm_selftest' time='MASKED'/></span><br><span style="color: hsl(120, 100%, 40%);">+ <testcase classname='BTS_Tests' name='TC_tch_sign_l2_fill_frame' time='MASKED'/></span><br><span style="color: hsl(120, 100%, 40%);">+ <testcase classname='BTS_Tests' name='TC_tch_sign_l2_fill_frame_dtxd' time='MASKED'></span><br><span style="color: hsl(120, 100%, 40%);">+ <failure type='fail-verdict'>"Unexpected L2 fill frame received on Um"</span><br><span style="color: hsl(120, 100%, 40%);">+ BTS_Tests.ttcn:MASKED BTS_Tests control part</span><br><span style="color: hsl(120, 100%, 40%);">+ BTS_Tests.ttcn:MASKED TC_tch_sign_l2_fill_frame_dtxd testcase</span><br><span style="color: hsl(120, 100%, 40%);">+ </failure></span><br><span style="color: hsl(120, 100%, 40%);">+ </testcase></span><br><span> </testsuite></span><br><span>diff --git a/library/RSL_Types.ttcn b/library/RSL_Types.ttcn</span><br><span>index d4d0c4d..95a7b1f 100644</span><br><span>--- a/library/RSL_Types.ttcn</span><br><span>+++ b/library/RSL_Types.ttcn</span><br><span>@@ -325,20 +325,21 @@</span><br><span> RSL_SpeechAlgo coding_alg_rate</span><br><span> } with { variant (len) "LENGTHTO(reserved,dtx_d,dtx_u,spd_ind,ch_rate_type,coding_alg_rate)" }</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- template (value) RSL_IE_ChannelMode ts_RSL_ChanMode_SIGN := {</span><br><span style="color: hsl(120, 100%, 40%);">+ template (value) RSL_IE_ChannelMode ts_RSL_ChanMode_SIGN(boolean dtx_downlink := false) := {</span><br><span> len := 0, /* overwritten */</span><br><span> reserved := '000000'B,</span><br><span style="color: hsl(0, 100%, 40%);">- dtx_d := false,</span><br><span style="color: hsl(120, 100%, 40%);">+ dtx_d := dtx_downlink,</span><br><span> dtx_u := false,</span><br><span> spd_ind := RSL_SPDI_SIGN,</span><br><span> ch_rate_type := RSL_CHRT_SDCCH,</span><br><span> coding_alg_rate := RSL_CMOD_NO_RESOURCE</span><br><span> }</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- template (value) RSL_IE_ChannelMode ts_RSL_ChanMode(RSL_ChanRateType t, RSL_SpeechAlgo alg) := {</span><br><span style="color: hsl(120, 100%, 40%);">+ template (value) RSL_IE_ChannelMode ts_RSL_ChanMode(RSL_ChanRateType t, RSL_SpeechAlgo alg,</span><br><span style="color: hsl(120, 100%, 40%);">+ boolean dtx_downlink := false) := {</span><br><span> len := 0, /* overwritten */</span><br><span> reserved := '000000'B,</span><br><span style="color: hsl(0, 100%, 40%);">- dtx_d := false,</span><br><span style="color: hsl(120, 100%, 40%);">+ dtx_d := dtx_downlink,</span><br><span> dtx_u := false,</span><br><span> spd_ind := RSL_SPDI_SPEECH,</span><br><span> ch_rate_type := t,</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/10372">change 10372</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/10372"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: osmo-ttcn3-hacks </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: merged </div>
<div style="display:none"> Gerrit-Change-Id: Id4e0de6e78b62cd408f600a57a28617d91da64af </div>
<div style="display:none"> Gerrit-Change-Number: 10372 </div>
<div style="display:none"> Gerrit-PatchSet: 4 </div>
<div style="display:none"> Gerrit-Owner: Stefan Sperling <ssperling@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Harald Welte <laforge@gnumonks.org> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: Stefan Sperling <ssperling@sysmocom.de> </div>