<p>lynxis lazus has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/10391">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">sgsn: rework TC_attach_closed_add_vty to be executed in a single BSSGP_ConnHldr<br><br>When stopping and starting BSSGP_ConnHdlr multiple times, there<br>are Port connecting problems. Using a single iteration of<br>BSSGP_ConnHldr.start() works around this problem.<br><br>Change-Id: I8e5ae832f3908a172b9beb6d936074b806e0c799<br>---<br>M sgsn/SGSN_Tests.ttcn<br>1 file changed, 13 insertions(+), 6 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/91/10391/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/sgsn/SGSN_Tests.ttcn b/sgsn/SGSN_Tests.ttcn</span><br><span>index 43c297e..a6a3c6c 100644</span><br><span>--- a/sgsn/SGSN_Tests.ttcn</span><br><span>+++ b/sgsn/SGSN_Tests.ttcn</span><br><span>@@ -1738,7 +1738,7 @@</span><br><span>      /* unregister the old IMSI */</span><br><span>        f_bssgp_client_unregister(g_pars.imsi);</span><br><span>      /* Simulate a foreign IMSI */</span><br><span style="color: hsl(0, 100%, 40%);">-   g_pars.imsi := '001010123456789'H;</span><br><span style="color: hsl(120, 100%, 40%);">+    g_pars.imsi := '001010123456700'H;</span><br><span>   f_bssgp_client_register(g_pars.imsi, g_pars.tlli, g_pars.bssgp_cell_id[0]);</span><br><span> </span><br><span>      /* there is no auth */</span><br><span>@@ -1758,6 +1758,15 @@</span><br><span>              }</span><br><span>    }</span><br><span> }</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+private function f_TC_attach_closed_add_vty(charstring id) runs on BSSGP_ConnHdlr {</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+       f_TC_attach_closed_foreign(id);</span><br><span style="color: hsl(120, 100%, 40%);">+       f_TC_attach_closed_imsi_added(id);</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+}</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> testcase TC_attach_closed_add_vty() runs on test_CT {</span><br><span>         /* VTY-> SGSN: policy close</span><br><span>        * MS -> SGSN: Attach Request</span><br><span>@@ -1777,12 +1786,10 @@</span><br><span>   f_sleep(1.0);</span><br><span>        f_vty_config(SGSNVTY, "sgsn", "auth-policy closed");</span><br><span>     f_vty_config(SGSNVTY, "sgsn", "imsi-acl del 001010123456789");</span><br><span style="color: hsl(120, 100%, 40%);">+    f_vty_config(SGSNVTY, "sgsn", "imsi-acl del 001010123456700");</span><br><span style="color: hsl(120, 100%, 40%);">+    f_vty_config(SGSNVTY, "sgsn", "imsi-acl add 001010123456700");</span><br><span>   /* test with foreign IMSI: Must Reject */</span><br><span style="color: hsl(0, 100%, 40%);">-       vc_conn := f_start_handler(refers(f_TC_attach_closed_foreign), testcasename(), g_gb, 9);</span><br><span style="color: hsl(0, 100%, 40%);">-        vc_conn.done;</span><br><span style="color: hsl(0, 100%, 40%);">-   f_vty_config(SGSNVTY, "sgsn", "imsi-acl add 001010123456789");</span><br><span style="color: hsl(0, 100%, 40%);">-      /* test with same IMSI: Must Accept */</span><br><span style="color: hsl(0, 100%, 40%);">-  vc_conn := f_start_handler(refers(f_TC_attach_closed_imsi_added), testcasename(), g_gb, 10);</span><br><span style="color: hsl(120, 100%, 40%);">+  vc_conn := f_start_handler(refers(f_TC_attach_closed_add_vty), testcasename(), g_gb, 9);</span><br><span>     vc_conn.done;</span><br><span> }</span><br><span> </span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/10391">change 10391</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/10391"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-ttcn3-hacks </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I8e5ae832f3908a172b9beb6d936074b806e0c799 </div>
<div style="display:none"> Gerrit-Change-Number: 10391 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: lynxis lazus <lynxis@fe80.eu> </div>