<p>Stefan Sperling has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/10372">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">add DTX fill frame BTS tests<br><br>Add tests TC_tch_sign_l2_fill_frame and TC_tch_sign_l2_fill_frame_dtxd.<br><br>TC_tch_sign_l2_fill_frame is already passing and verifies that fill<br>frames are sent if there is nothing else to transmit on a TCHF<br>signalling channel where DTX is disabled for downstream.<br><br>TC_tch_sign_l2_fill_frame_dtxd is currently failing. It verifies that<br>only specific fill frames are sent, as required by GSM 05.08 for TCHF<br>signalling channels with DTX enabled for downstream. At present, our<br>implementation generates no fill frames in this case, which is one<br>piece of the problem described in issue OS#1950.<br><br>Change-Id: Id4e0de6e78b62cd408f600a57a28617d91da64af<br>Related: OS#1950<br>---<br>M bts/BTS_Tests.ttcn<br>M bts/expected-results.xml<br>2 files changed, 101 insertions(+), 0 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/72/10372/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/bts/BTS_Tests.ttcn b/bts/BTS_Tests.ttcn</span><br><span>index fb6137c..8ff2d35 100644</span><br><span>--- a/bts/BTS_Tests.ttcn</span><br><span>+++ b/bts/BTS_Tests.ttcn</span><br><span>@@ -3794,6 +3794,97 @@</span><br><span> f_assert_lapdm('03e00d063505'O, tr_LAPDm_I(0, true, false, 7, 0, '063505'O), "I/7/0");</span><br><span> }</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+/***********************************************************************</span><br><span style="color: hsl(120, 100%, 40%);">+ * DTX Related (see GSM 05.08, section 8.3)</span><br><span style="color: hsl(120, 100%, 40%);">+ ***********************************************************************/</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ function f_test_l2_fill_frames(boolean dtxd, integer num_fill_frames_expected, float wait_time) runs on ConnHdlr {</span><br><span style="color: hsl(120, 100%, 40%);">+ var L1ctlDlMessage dl;</span><br><span style="color: hsl(120, 100%, 40%);">+ var octetstring l2_fill_frame := '0303012B2B2B2B2B2B2B2B2B2B2B2B2B2B2B2B2B2B2B2B'O;</span><br><span style="color: hsl(120, 100%, 40%);">+ var integer nframes := 0;</span><br><span style="color: hsl(120, 100%, 40%);">+ /* Frames numbers (mod 104) for which a fill frame is expected on TCHF if DTX is enabled. */</span><br><span style="color: hsl(120, 100%, 40%);">+ var Integers required_tdma_frames_dtx_tchf := { 52, 53, 54, 55, 56, 57, 58, 59 };</span><br><span style="color: hsl(120, 100%, 40%);">+ timer T := wait_time;</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ f_l1_tune(L1CTL);</span><br><span style="color: hsl(120, 100%, 40%);">+ RSL.clear;</span><br><span style="color: hsl(120, 100%, 40%);">+ L1CTL.clear;</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ /* activate TCHF signalling channel */</span><br><span style="color: hsl(120, 100%, 40%);">+ f_est_dchan(false);</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ T.start;</span><br><span style="color: hsl(120, 100%, 40%);">+ alt {</span><br><span style="color: hsl(120, 100%, 40%);">+ [] L1CTL.receive(tr_L1CTL_DATA_IND(g_chan_nr, ?)) -> value dl {</span><br><span style="color: hsl(120, 100%, 40%);">+ var octetstring l2 := dl.payload.data_ind.payload;</span><br><span style="color: hsl(120, 100%, 40%);">+ if (not match(l2, l2_fill_frame)) {</span><br><span style="color: hsl(120, 100%, 40%);">+ repeat;</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+ nframes := nframes + 1;</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ if (dtxd) {</span><br><span style="color: hsl(120, 100%, 40%);">+ var GsmFrameNumber frame_number := dl.dl_info.frame_nr;</span><br><span style="color: hsl(120, 100%, 40%);">+ for (var integer i := 0; i < lengthof(required_tdma_frames_dtx_tchf); i := i + 1) {</span><br><span style="color: hsl(120, 100%, 40%);">+ if (frame_number mod 104 == required_tdma_frames_dtx_tchf[i]) {</span><br><span style="color: hsl(120, 100%, 40%);">+ if (nframes >= num_fill_frames_expected) {</span><br><span style="color: hsl(120, 100%, 40%);">+ T.stop;</span><br><span style="color: hsl(120, 100%, 40%);">+ setverdict(pass);</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+ repeat;</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+ log("Received DTX TCH fill frame with bad frame number: ", frame_number);</span><br><span style="color: hsl(120, 100%, 40%);">+ setverdict(fail, "Unexpected L2 fill frame received on Um");</span><br><span style="color: hsl(120, 100%, 40%);">+ } else if (nframes >= num_fill_frames_expected) {</span><br><span style="color: hsl(120, 100%, 40%);">+ T.stop;</span><br><span style="color: hsl(120, 100%, 40%);">+ setverdict(pass);</span><br><span style="color: hsl(120, 100%, 40%);">+ } else {</span><br><span style="color: hsl(120, 100%, 40%);">+ repeat;</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+ [] L1CTL.receive { repeat; }</span><br><span style="color: hsl(120, 100%, 40%);">+ [] T.timeout {</span><br><span style="color: hsl(120, 100%, 40%);">+ setverdict(fail, "Timeout waiting for L2 fill frames on Um");</span><br><span style="color: hsl(120, 100%, 40%);">+ mtc.stop;</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+}</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+function f_TC_tch_sign_l2_fill_frame(charstring id) runs on ConnHdlr {</span><br><span style="color: hsl(120, 100%, 40%);">+ /* Expect 104 L2 fill frames to show up on the Um interface within 2.5 seconds. */</span><br><span style="color: hsl(120, 100%, 40%);">+ f_test_l2_fill_frames(false, 104, 2.5);</span><br><span style="color: hsl(120, 100%, 40%);">+}</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+function f_TC_tch_sign_l2_fill_frame_dtxd(charstring id) runs on ConnHdlr {</span><br><span style="color: hsl(120, 100%, 40%);">+ /* With DTX enabled there are 8 TDMA fill frames per every 104 frames.</span><br><span style="color: hsl(120, 100%, 40%);">+ * Expect at least 8 L2 fill frames (out of 104 TDMA frames) on the Um interface within 2.5 seconds. */</span><br><span style="color: hsl(120, 100%, 40%);">+ f_test_l2_fill_frames(true, 8, 2.5);</span><br><span style="color: hsl(120, 100%, 40%);">+}</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+function f_tch_sign_l2_fill_frame(boolean dtxd) runs on test_CT {</span><br><span style="color: hsl(120, 100%, 40%);">+ var ConnHdlr vc_conn;</span><br><span style="color: hsl(120, 100%, 40%);">+ var ConnHdlrPars pars := valueof(t_Pars(t_RslChanNr_Bm(1), ts_RSL_ChanMode_SIGN(dtxd)));</span><br><span style="color: hsl(120, 100%, 40%);">+ pars.t_guard := 60.0;</span><br><span style="color: hsl(120, 100%, 40%);">+ f_init(testcasename());</span><br><span style="color: hsl(120, 100%, 40%);">+ if (dtxd) {</span><br><span style="color: hsl(120, 100%, 40%);">+ vc_conn := f_start_handler(refers(f_TC_tch_sign_l2_fill_frame_dtxd), pars);</span><br><span style="color: hsl(120, 100%, 40%);">+ } else {</span><br><span style="color: hsl(120, 100%, 40%);">+ vc_conn := f_start_handler(refers(f_TC_tch_sign_l2_fill_frame), pars);</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+ vc_conn.done;</span><br><span style="color: hsl(120, 100%, 40%);">+}</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+/* Verify that L2 fill frames are sent on TCH in signaling mode if</span><br><span style="color: hsl(120, 100%, 40%);">+ * there is nothing to transmit while DTX is disabled on downlink. */</span><br><span style="color: hsl(120, 100%, 40%);">+testcase TC_tch_sign_l2_fill_frame() runs on test_CT {</span><br><span style="color: hsl(120, 100%, 40%);">+ f_tch_sign_l2_fill_frame(false);</span><br><span style="color: hsl(120, 100%, 40%);">+}</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+/* Verify that particular L2 fill frames are sent on TCH in signaling mode if</span><br><span style="color: hsl(120, 100%, 40%);">+ * there is nothing to transmit while DTX is enabled on downlink. */</span><br><span style="color: hsl(120, 100%, 40%);">+testcase TC_tch_sign_l2_fill_frame_dtxd() runs on test_CT {</span><br><span style="color: hsl(120, 100%, 40%);">+ f_tch_sign_l2_fill_frame(true);</span><br><span style="color: hsl(120, 100%, 40%);">+}</span><br><span> </span><br><span> /* test generation of RLL ERR IND based on Um errors (TS 48.058 3.9) */</span><br><span> /* protocol error as per 44.006 */</span><br><span>@@ -3926,6 +4017,9 @@</span><br><span> execute( TC_encr_cmd_a53() );</span><br><span> </span><br><span> execute( TC_lapdm_selftest() );</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ execute( TC_tch_sign_l2_fill_frame() );</span><br><span style="color: hsl(120, 100%, 40%);">+ execute( TC_tch_sign_l2_fill_frame_dtxd() );</span><br><span> }</span><br><span> </span><br><span> </span><br><span>diff --git a/bts/expected-results.xml b/bts/expected-results.xml</span><br><span>index d1a65a3..b8f0d68 100644</span><br><span>--- a/bts/expected-results.xml</span><br><span>+++ b/bts/expected-results.xml</span><br><span>@@ -85,4 +85,11 @@</span><br><span> <testcase classname='BTS_Tests' name='TC_encr_cmd_a52' time='MASKED'/></span><br><span> <testcase classname='BTS_Tests' name='TC_encr_cmd_a53' time='MASKED'/></span><br><span> <testcase classname='BTS_Tests' name='TC_lapdm_selftest' time='MASKED'/></span><br><span style="color: hsl(120, 100%, 40%);">+ <testcase classname='BTS_Tests' name='TC_tch_sign_l2_fill_frame' time='MASKED'/></span><br><span style="color: hsl(120, 100%, 40%);">+ <testcase classname='BTS_Tests' name='TC_tch_sign_l2_fill_frame_dtxd' time='MASKED'></span><br><span style="color: hsl(120, 100%, 40%);">+ <failure type='fail-verdict'>"Timeout waiting for L2 fill frames on Um"</span><br><span style="color: hsl(120, 100%, 40%);">+ BTS_Tests.ttcn:MASKED BTS_Tests control part</span><br><span style="color: hsl(120, 100%, 40%);">+ BTS_Tests.ttcn:MASKED TC_tch_sign_l2_fill_frame_dtxd testcase</span><br><span style="color: hsl(120, 100%, 40%);">+ </failure></span><br><span style="color: hsl(120, 100%, 40%);">+ </testcase></span><br><span> </testsuite></span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/10372">change 10372</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/10372"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: osmo-ttcn3-hacks </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: Id4e0de6e78b62cd408f600a57a28617d91da64af </div>
<div style="display:none"> Gerrit-Change-Number: 10372 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Stefan Sperling <ssperling@sysmocom.de> </div>