<p>Harald Welte <strong>merged</strong> this change.</p><p><a href="https://gerrit.osmocom.org/10325">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">gsm/gsm0480.c: prevent NULL-pointer dereference<br><br>Change-Id: I444d95941837458b46e581298f76f3a9926c8552<br>---<br>M src/gsm/gsm0480.c<br>1 file changed, 10 insertions(+), 2 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/gsm/gsm0480.c b/src/gsm/gsm0480.c</span><br><span>index 2d2df4a..5b51c75 100644</span><br><span>--- a/src/gsm/gsm0480.c</span><br><span>+++ b/src/gsm/gsm0480.c</span><br><span>@@ -880,7 +880,11 @@</span><br><span>  */</span><br><span> struct msgb *gsm0480_gen_return_error(uint8_t invoke_id, uint8_t error_code)</span><br><span> {</span><br><span style="color: hsl(0, 100%, 40%);">-        struct msgb *msg = gsm0480_msgb_alloc_name("TS 04.80 ReturnError");</span><br><span style="color: hsl(120, 100%, 40%);">+ struct msgb *msg;</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+   msg = gsm0480_msgb_alloc_name("TS 04.80 ReturnError");</span><br><span style="color: hsl(120, 100%, 40%);">+      if (!msg)</span><br><span style="color: hsl(120, 100%, 40%);">+             return NULL;</span><br><span> </span><br><span>     /* First insert the problem code */</span><br><span>  msgb_push_TLV1(msg, GSM_0480_ERROR_CODE_TAG, error_code);</span><br><span>@@ -906,7 +910,11 @@</span><br><span>  */</span><br><span> struct msgb *gsm0480_gen_reject(int invoke_id, uint8_t problem_tag, uint8_t problem_code)</span><br><span> {</span><br><span style="color: hsl(0, 100%, 40%);">-       struct msgb *msg = gsm0480_msgb_alloc_name("TS 04.80 Reject");</span><br><span style="color: hsl(120, 100%, 40%);">+      struct msgb *msg;</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+   msg = gsm0480_msgb_alloc_name("TS 04.80 Reject");</span><br><span style="color: hsl(120, 100%, 40%);">+   if (!msg)</span><br><span style="color: hsl(120, 100%, 40%);">+             return NULL;</span><br><span> </span><br><span>     /* First insert the problem code */</span><br><span>  msgb_push_TLV1(msg, problem_tag, problem_code);</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/10325">change 10325</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/10325"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: libosmocore </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: merged </div>
<div style="display:none"> Gerrit-Change-Id: I444d95941837458b46e581298f76f3a9926c8552 </div>
<div style="display:none"> Gerrit-Change-Number: 10325 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: Vadim Yanitskiy <axilirator@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: Harald Welte <laforge@gnumonks.org> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>