<p>Harald Welte <strong>merged</strong> this change.</p><p><a href="https://gerrit.osmocom.org/10316">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Jenkins Builder: Verified
  Harald Welte: Looks good to me, approved

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">cardem: add state name in trace<br><br>this helps reading the output while debugging quite a lot<br><br>Change-Id: Idf301e09cf14e2412e29dcb252563bc6e4e5c630<br>---<br>M firmware/libcommon/source/card_emu.c<br>1 file changed, 19 insertions(+), 2 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/firmware/libcommon/source/card_emu.c b/firmware/libcommon/source/card_emu.c</span><br><span>index 14a5dd8..fa09829 100644</span><br><span>--- a/firmware/libcommon/source/card_emu.c</span><br><span>+++ b/firmware/libcommon/source/card_emu.c</span><br><span>@@ -54,6 +54,22 @@</span><br><span>       ISO_S_IN_TPDU,          /* inside a TPDU */</span><br><span> };</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+const struct value_string iso7816_3_card_state_names[] = {</span><br><span style="color: hsl(120, 100%, 40%);">+     OSMO_VALUE_STRING(ISO_S_WAIT_POWER),</span><br><span style="color: hsl(120, 100%, 40%);">+  OSMO_VALUE_STRING(ISO_S_WAIT_CLK),</span><br><span style="color: hsl(120, 100%, 40%);">+    OSMO_VALUE_STRING(ISO_S_WAIT_RST),</span><br><span style="color: hsl(120, 100%, 40%);">+    OSMO_VALUE_STRING(ISO_S_WAIT_ATR),</span><br><span style="color: hsl(120, 100%, 40%);">+    OSMO_VALUE_STRING(ISO_S_IN_ATR),</span><br><span style="color: hsl(120, 100%, 40%);">+      OSMO_VALUE_STRING(ISO_S_IN_PTS),</span><br><span style="color: hsl(120, 100%, 40%);">+      OSMO_VALUE_STRING(ISO_S_WAIT_TPDU),</span><br><span style="color: hsl(120, 100%, 40%);">+   OSMO_VALUE_STRING(ISO_S_IN_TPDU),</span><br><span style="color: hsl(120, 100%, 40%);">+     {</span><br><span style="color: hsl(120, 100%, 40%);">+             .value = 0,</span><br><span style="color: hsl(120, 100%, 40%);">+           .str = NULL,</span><br><span style="color: hsl(120, 100%, 40%);">+  },</span><br><span style="color: hsl(120, 100%, 40%);">+};</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> /* detailed sub-states of ISO_S_IN_PTS */</span><br><span> enum pts_state {</span><br><span>  PTS_S_WAIT_REQ_PTSS,</span><br><span>@@ -285,8 +301,9 @@</span><br><span>   if (ch->state == new_state)</span><br><span>               return;</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-     TRACE_DEBUG("%u: 7816 card state %u -> %u\r\n", ch->num,</span><br><span style="color: hsl(0, 100%, 40%);">-                    ch->state, new_state);</span><br><span style="color: hsl(120, 100%, 40%);">+ TRACE_DEBUG("%u: 7816 card state %u (%s) -> %u (%s)\r\n", ch->num,</span><br><span style="color: hsl(120, 100%, 40%);">+                ch->state, get_value_string(iso7816_3_card_state_names, ch->state),</span><br><span style="color: hsl(120, 100%, 40%);">+             new_state, get_value_string(iso7816_3_card_state_names, new_state));</span><br><span>     ch->state = new_state;</span><br><span> </span><br><span>        switch (new_state) {</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/10316">change 10316</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/10316"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: simtrace2 </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: merged </div>
<div style="display:none"> Gerrit-Change-Id: Idf301e09cf14e2412e29dcb252563bc6e4e5c630 </div>
<div style="display:none"> Gerrit-Change-Number: 10316 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: Kévin Redon <kredon@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Harald Welte <laforge@gnumonks.org> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: Kévin Redon <kredon@sysmocom.de> </div>