<p>Harald Welte <strong>merged</strong> this change.</p><p><a href="https://gerrit.osmocom.org/10306">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">mgcp_test: release endpoints after use<br><br>The test function test_multilple_codec() in mgcp_test.c creates a<br>lot of connections, but it never releases them. Just freeing the<br>cfg object is not enough since the UDP ports stay open and this<br>may interfere with other tests that also create connections<br>(port numbers).<br><br>- Make sure all endpoints are released when test_multilple_codec()<br>  is done.<br><br>Change-Id: Ic13b4368162149ec36c93f4188fa4c71166e08d5<br>---<br>M tests/mgcp/mgcp_test.c<br>1 file changed, 4 insertions(+), 0 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/tests/mgcp/mgcp_test.c b/tests/mgcp/mgcp_test.c</span><br><span>index df6ea2f..ea79485 100644</span><br><span>--- a/tests/mgcp/mgcp_test.c</span><br><span>+++ b/tests/mgcp/mgcp_test.c</span><br><span>@@ -1265,6 +1265,7 @@</span><br><span>         struct in_addr addr;</span><br><span>         struct mgcp_conn_rtp *conn = NULL;</span><br><span>   char conn_id[256];</span><br><span style="color: hsl(120, 100%, 40%);">+    int i;</span><br><span> </span><br><span>   printf("Testing multiple payload types\n");</span><br><span> </span><br><span>@@ -1398,6 +1399,9 @@</span><br><span>    OSMO_ASSERT(conn);</span><br><span>   OSMO_ASSERT(conn->end.codec->payload_type == 0);</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+    for (i = 1; i < cfg->trunk.number_endpoints; i++)</span><br><span style="color: hsl(120, 100%, 40%);">+               mgcp_endp_release(&cfg->trunk.endpoints[i]);</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span>        talloc_free(cfg);</span><br><span> }</span><br><span> </span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/10306">change 10306</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/10306"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-mgw </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: merged </div>
<div style="display:none"> Gerrit-Change-Id: Ic13b4368162149ec36c93f4188fa4c71166e08d5 </div>
<div style="display:none"> Gerrit-Change-Number: 10306 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: dexter <pmaier@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Harald Welte <laforge@gnumonks.org> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>