<p>Harald Welte has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/10294">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">Migrate from osmo_ipa_idtag_parse() to ipa_ccm_id_resp_parse()<br><br>In libosmocore Change-ID I1834d90fbcdbfcb05f5b8cfe39bfe9543737ef8f<br>we have introduced ipa_ccm_id_resp_parse() as a bugfixed replacement<br>of ipa_ccm_idtag_parse().<br><br>The main difference is that the returned "value" parts now have<br>a correct reported "length", whereas before this commit they all<br>reported a one-byte too-long "length" for each IE.<br><br>Change-Id: I7d5ab323989c13d0cc6ff05547306edb918e423f<br>---<br>M src/ipaccess/ipaccess-proxy.c<br>1 file changed, 1 insertion(+), 2 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/94/10294/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/ipaccess/ipaccess-proxy.c b/src/ipaccess/ipaccess-proxy.c</span><br><span>index aa5e7b4..a2ce633 100644</span><br><span>--- a/src/ipaccess/ipaccess-proxy.c</span><br><span>+++ b/src/ipaccess/ipaccess-proxy.c</span><br><span>@@ -458,8 +458,7 @@</span><br><span>         case IPAC_MSGT_ID_RESP:</span><br><span>              DEBUGP(DLMI, "ID_RESP ");</span><br><span>          /* parse tags, search for Unit ID */</span><br><span style="color: hsl(0, 100%, 40%);">-            ipa_ccm_idtag_parse(&tlvp, (uint8_t *)msg->l2h + 2,</span><br><span style="color: hsl(0, 100%, 40%);">-                                   msgb_l2len(msg)-2);</span><br><span style="color: hsl(120, 100%, 40%);">+              ipa_ccm_id_resp_parse(&tlvp, (uint8_t *)msg->l2h+1, msgb_l2len(msg)-1);</span><br><span>               DEBUGP(DLMI, "\n");</span><br><span> </span><br><span>            if (!TLVP_PRESENT(&tlvp, IPAC_IDTAG_UNIT)) {</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/10294">change 10294</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/10294"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-bsc </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I7d5ab323989c13d0cc6ff05547306edb918e423f </div>
<div style="display:none"> Gerrit-Change-Number: 10294 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Harald Welte <laforge@gnumonks.org> </div>