<p>dexter has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/10286">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">endpoint_fsm: add missing return in mgcp_pick_codec<br><br>The function mgcp_pick_codec is responsible to set the codec<br>information. In cases whee the codec type can not be determined<br>correctly it sets verb_info->codecs_len = 0, indicating to the caller<br>that no codocs are set. However, after that it does not return, it sets<br>an invalid codec anyway.<br><br>- Add missing return to keep the no-codec setting in case of error.<br><br>Change-Id: I8d1f8553357b6ad328ab1e5d4525fad0dd282a42<br>---<br>M src/osmo-bsc/mgw_endpoint_fsm.c<br>1 file changed, 1 insertion(+), 0 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/86/10286/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/osmo-bsc/mgw_endpoint_fsm.c b/src/osmo-bsc/mgw_endpoint_fsm.c</span><br><span>index ba10f5c..18e9dcf 100644</span><br><span>--- a/src/osmo-bsc/mgw_endpoint_fsm.c</span><br><span>+++ b/src/osmo-bsc/mgw_endpoint_fsm.c</span><br><span>@@ -739,6 +739,7 @@</span><br><span>                           "Unable to determine MGCP codec type for %s in chan-mode %s\n",</span><br><span>                    gsm_lchant_name(lchan->type), gsm48_chan_mode_name(lchan->tch_mode));</span><br><span>                verb_info->codecs_len = 0;</span><br><span style="color: hsl(120, 100%, 40%);">+         return;</span><br><span>      }</span><br><span> </span><br><span>        verb_info->codecs[0] = codec;</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/10286">change 10286</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/10286"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-bsc </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I8d1f8553357b6ad328ab1e5d4525fad0dd282a42 </div>
<div style="display:none"> Gerrit-Change-Number: 10286 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: dexter <pmaier@sysmocom.de> </div>