<p>Harald Welte has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/10290">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">cosmetic: More context / naming / comment for test_idtag_parsing()<br><br>Change-Id: I1ebeba2067549e0dd1541fa84715d44321ff3b43<br>---<br>M tests/utils/utils_test.c<br>1 file changed, 3 insertions(+), 2 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/90/10290/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/tests/utils/utils_test.c b/tests/utils/utils_test.c</span><br><span>index a146190..eec13ca 100644</span><br><span>--- a/tests/utils/utils_test.c</span><br><span>+++ b/tests/utils/utils_test.c</span><br><span>@@ -175,7 +175,8 @@</span><br><span>        struct tlv_parsed tvp;</span><br><span>       int rc;</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-        static uint8_t data[] = {</span><br><span style="color: hsl(120, 100%, 40%);">+  /* IPA CCM IDENTITY REQUEST message: 8bit length followed by respective value */</span><br><span style="color: hsl(120, 100%, 40%);">+        static uint8_t id_get_data[] = {</span><br><span>           0x01, 0x08,</span><br><span>          0x01, 0x07,</span><br><span>          0x01, 0x02,</span><br><span>@@ -188,7 +189,7 @@</span><br><span>            0x11, 0x24, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00</span><br><span>         };</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-    rc = ipa_ccm_idtag_parse_off(&tvp, data, sizeof(data), 1);</span><br><span style="color: hsl(120, 100%, 40%);">+        rc = ipa_ccm_idtag_parse_off(&tvp, id_get_data, sizeof(id_get_data), 1);</span><br><span>         OSMO_ASSERT(rc == 0);</span><br><span> </span><br><span>    OSMO_ASSERT(TLVP_PRESENT(&tvp, 8));</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/10290">change 10290</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/10290"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: libosmocore </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I1ebeba2067549e0dd1541fa84715d44321ff3b43 </div>
<div style="display:none"> Gerrit-Change-Number: 10290 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Harald Welte <laforge@gnumonks.org> </div>