<p>Harald Welte <strong>merged</strong> this change.</p><p><a href="https://gerrit.osmocom.org/10258">View Change</a></p><div style="white-space:pre-wrap">Approvals:
Jenkins Builder: Verified
Harald Welte: Looks good to me, approved
</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">import oap_client_test from osmo-sgsn<br><br>As oap_client has moved from osmo-sgsn to libosmogsm, it is only fair<br>that the related unit test shall also be moved here.<br><br>Change-Id: I9d64e10b4bacac9b530cf077841bad762fc6d558<br>---<br>M tests/Makefile.am<br>D tests/oap/Makefile.am<br>A tests/oap/oap_client_test.c<br>A tests/oap/oap_client_test.err<br>A tests/oap/oap_client_test.ok<br>M tests/testsuite.at<br>6 files changed, 322 insertions(+), 39 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/tests/Makefile.am b/tests/Makefile.am</span><br><span>index eaaa8df..072bb4a 100644</span><br><span>--- a/tests/Makefile.am</span><br><span>+++ b/tests/Makefile.am</span><br><span>@@ -23,7 +23,8 @@</span><br><span> coding/coding_test conv/conv_gsm0503_test \</span><br><span> abis/abis_test endian/endian_test sercomm/sercomm_test \</span><br><span> prbs/prbs_test gsm23003/gsm23003_test \</span><br><span style="color: hsl(0, 100%, 40%);">- codec/codec_ecu_fr_test timer/clk_override_test</span><br><span style="color: hsl(120, 100%, 40%);">+ codec/codec_ecu_fr_test timer/clk_override_test \</span><br><span style="color: hsl(120, 100%, 40%);">+ oap/oap_client_test</span><br><span> </span><br><span> if ENABLE_MSGFILE</span><br><span> check_PROGRAMS += msgfile/msgfile_test</span><br><span>@@ -172,6 +173,9 @@</span><br><span> oap_oap_test_SOURCES = oap/oap_test.c</span><br><span> oap_oap_test_LDADD = $(LDADD) $(top_builddir)/src/gsm/libosmogsm.la</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+oap_oap_client_test_SOURCES = oap/oap_client_test.c</span><br><span style="color: hsl(120, 100%, 40%);">+oap_oap_client_test_LDADD = $(LDADD) $(top_builddir)/src/gsm/libosmogsm.la</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> fsm_fsm_test_SOURCES = fsm/fsm_test.c</span><br><span> fsm_fsm_test_LDADD = $(LDADD) $(top_builddir)/src/ctrl/libosmoctrl.la</span><br><span> </span><br><span>@@ -253,7 +257,8 @@</span><br><span> conv/conv_gsm0503_test.ok endian/endian_test.ok \</span><br><span> sercomm/sercomm_test.ok prbs/prbs_test.ok \</span><br><span> gsm23003/gsm23003_test.ok \</span><br><span style="color: hsl(0, 100%, 40%);">- timer/clk_override_test.ok</span><br><span style="color: hsl(120, 100%, 40%);">+ timer/clk_override_test.ok \</span><br><span style="color: hsl(120, 100%, 40%);">+ oap/oap_client_test.ok oap/oap_client_test.err</span><br><span> </span><br><span> DISTCLEANFILES = atconfig atlocal conv/gsm0503_test_vectors.c</span><br><span> BUILT_SOURCES = conv/gsm0503_test_vectors.c</span><br><span>diff --git a/tests/oap/Makefile.am b/tests/oap/Makefile.am</span><br><span>deleted file mode 100644</span><br><span>index 06ccf33..0000000</span><br><span>--- a/tests/oap/Makefile.am</span><br><span>+++ /dev/null</span><br><span>@@ -1,37 +0,0 @@</span><br><span style="color: hsl(0, 100%, 40%);">-AM_CPPFLAGS = \</span><br><span style="color: hsl(0, 100%, 40%);">- $(all_includes) \</span><br><span style="color: hsl(0, 100%, 40%);">- -I$(top_srcdir)/include \</span><br><span style="color: hsl(0, 100%, 40%);">- $(NULL)</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">-AM_CFLAGS = \</span><br><span style="color: hsl(0, 100%, 40%);">- -Wall \</span><br><span style="color: hsl(0, 100%, 40%);">- -ggdb3 \</span><br><span style="color: hsl(0, 100%, 40%);">- $(LIBOSMOCORE_CFLAGS) \</span><br><span style="color: hsl(0, 100%, 40%);">- $(LIBOSMOGSM_CFLAGS) \</span><br><span style="color: hsl(0, 100%, 40%);">- $(NULL)</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">-EXTRA_DIST = \</span><br><span style="color: hsl(0, 100%, 40%);">- oap_test.ok \</span><br><span style="color: hsl(0, 100%, 40%);">- $(NULL)</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">-if HAVE_LIBGTP</span><br><span style="color: hsl(0, 100%, 40%);">-if HAVE_LIBCARES</span><br><span style="color: hsl(0, 100%, 40%);">-noinst_PROGRAMS = \</span><br><span style="color: hsl(0, 100%, 40%);">- oap_test \</span><br><span style="color: hsl(0, 100%, 40%);">- $(NULL)</span><br><span style="color: hsl(0, 100%, 40%);">-endif</span><br><span style="color: hsl(0, 100%, 40%);">-endif</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">-oap_test_SOURCES = \</span><br><span style="color: hsl(0, 100%, 40%);">- oap_test.c \</span><br><span style="color: hsl(0, 100%, 40%);">- $(NULL)</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">-oap_test_LDADD = \</span><br><span style="color: hsl(0, 100%, 40%);">- $(top_builddir)/src/gprs/oap.o \</span><br><span style="color: hsl(0, 100%, 40%);">- $(top_builddir)/src/gprs/oap_messages.o \</span><br><span style="color: hsl(0, 100%, 40%);">- $(top_builddir)/src/gprs/gprs_utils.o \</span><br><span style="color: hsl(0, 100%, 40%);">- $(top_builddir)/src/libcommon/libcommon.a \</span><br><span style="color: hsl(0, 100%, 40%);">- $(LIBOSMOCORE_LIBS) \</span><br><span style="color: hsl(0, 100%, 40%);">- $(LIBOSMOGSM_LIBS) \</span><br><span style="color: hsl(0, 100%, 40%);">- -lrt</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span>diff --git a/tests/oap/oap_client_test.c b/tests/oap/oap_client_test.c</span><br><span>new file mode 100644</span><br><span>index 0000000..a841b38</span><br><span>--- /dev/null</span><br><span>+++ b/tests/oap/oap_client_test.c</span><br><span>@@ -0,0 +1,271 @@</span><br><span style="color: hsl(120, 100%, 40%);">+/* Test Osmocom Authentication Protocol */</span><br><span style="color: hsl(120, 100%, 40%);">+/*</span><br><span style="color: hsl(120, 100%, 40%);">+ * (C) 2015 by sysmocom s.f.m.c. GmbH</span><br><span style="color: hsl(120, 100%, 40%);">+ * All Rights Reserved</span><br><span style="color: hsl(120, 100%, 40%);">+ *</span><br><span style="color: hsl(120, 100%, 40%);">+ * This program is free software; you can redistribute it and/or modify</span><br><span style="color: hsl(120, 100%, 40%);">+ * it under the terms of the GNU Affero General Public License as published by</span><br><span style="color: hsl(120, 100%, 40%);">+ * the Free Software Foundation; either version 3 of the License, or</span><br><span style="color: hsl(120, 100%, 40%);">+ * (at your option) any later version.</span><br><span style="color: hsl(120, 100%, 40%);">+ *</span><br><span style="color: hsl(120, 100%, 40%);">+ * This program is distributed in the hope that it will be useful,</span><br><span style="color: hsl(120, 100%, 40%);">+ * but WITHOUT ANY WARRANTY; without even the implied warranty of</span><br><span style="color: hsl(120, 100%, 40%);">+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the</span><br><span style="color: hsl(120, 100%, 40%);">+ * GNU Affero General Public License for more details.</span><br><span style="color: hsl(120, 100%, 40%);">+ *</span><br><span style="color: hsl(120, 100%, 40%);">+ * You should have received a copy of the GNU Affero General Public License</span><br><span style="color: hsl(120, 100%, 40%);">+ * along with this program. If not, see <http://www.gnu.org/licenses/>.</span><br><span style="color: hsl(120, 100%, 40%);">+ *</span><br><span style="color: hsl(120, 100%, 40%);">+ */</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+#include <osmocom/core/application.h></span><br><span style="color: hsl(120, 100%, 40%);">+#include <osmocom/core/logging.h></span><br><span style="color: hsl(120, 100%, 40%);">+#include <osmocom/gsm/oap.h></span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+#include <osmocom/gsm/oap_client.h></span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+#include <stdio.h></span><br><span style="color: hsl(120, 100%, 40%);">+#include <string.h></span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+static void test_oap_api(void)</span><br><span style="color: hsl(120, 100%, 40%);">+{</span><br><span style="color: hsl(120, 100%, 40%);">+ printf("Testing OAP API\n");</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ struct osmo_oap_client_config _config;</span><br><span style="color: hsl(120, 100%, 40%);">+ struct osmo_oap_client_config *config = &_config;</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ struct osmo_oap_client_state _state;</span><br><span style="color: hsl(120, 100%, 40%);">+ struct osmo_oap_client_state *state = &_state;</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ struct osmo_oap_message oap_rx;</span><br><span style="color: hsl(120, 100%, 40%);">+ struct msgb *msg_rx;</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ struct osmo_oap_message oap_tx;</span><br><span style="color: hsl(120, 100%, 40%);">+ struct msgb *msg_tx;</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ memset(config, 0, sizeof(*config));</span><br><span style="color: hsl(120, 100%, 40%);">+ memset(state, 0, sizeof(*state));</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ OSMO_ASSERT(osmo_hexparse("0102030405060708090a0b0c0d0e0f10", config->secret_k, 16) == 16);</span><br><span style="color: hsl(120, 100%, 40%);">+ OSMO_ASSERT(osmo_hexparse("1112131415161718191a1b1c1d1e1f20", config->secret_opc, 16) == 16);</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ fprintf(stderr, "- make sure filling with zeros means uninitialized\n");</span><br><span style="color: hsl(120, 100%, 40%);">+ OSMO_ASSERT(state->state == OSMO_OAP_UNINITIALIZED);</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ fprintf(stderr, "- reject messages in uninitialized state\n");</span><br><span style="color: hsl(120, 100%, 40%);">+ memset(&oap_rx, 0, sizeof(oap_rx));</span><br><span style="color: hsl(120, 100%, 40%);">+ state->client_id = 1;</span><br><span style="color: hsl(120, 100%, 40%);">+ oap_rx.message_type = OAP_MSGT_REGISTER_ERROR;</span><br><span style="color: hsl(120, 100%, 40%);">+ msg_rx = osmo_oap_client_encoded(&oap_rx);</span><br><span style="color: hsl(120, 100%, 40%);">+ OSMO_ASSERT(osmo_oap_client_handle(state, msg_rx, &msg_tx) < 0);</span><br><span style="color: hsl(120, 100%, 40%);">+ OSMO_ASSERT(state->state == OSMO_OAP_UNINITIALIZED);</span><br><span style="color: hsl(120, 100%, 40%);">+ msgb_free(msg_rx);</span><br><span style="color: hsl(120, 100%, 40%);">+ OSMO_ASSERT(!msg_tx);</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ fprintf(stderr, "- NULL config should disable\n");</span><br><span style="color: hsl(120, 100%, 40%);">+ OSMO_ASSERT( osmo_oap_client_init(NULL, state) == 0 );</span><br><span style="color: hsl(120, 100%, 40%);">+ OSMO_ASSERT(state->state == OSMO_OAP_DISABLED);</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ fprintf(stderr, "- reject messages in disabled state\n");</span><br><span style="color: hsl(120, 100%, 40%);">+ memset(state, 0, sizeof(*state));</span><br><span style="color: hsl(120, 100%, 40%);">+ memset(&oap_rx, 0, sizeof(oap_rx));</span><br><span style="color: hsl(120, 100%, 40%);">+ state->state = OSMO_OAP_DISABLED;</span><br><span style="color: hsl(120, 100%, 40%);">+ state->client_id = 1;</span><br><span style="color: hsl(120, 100%, 40%);">+ oap_rx.message_type = OAP_MSGT_REGISTER_ERROR;</span><br><span style="color: hsl(120, 100%, 40%);">+ msg_rx = osmo_oap_client_encoded(&oap_rx);</span><br><span style="color: hsl(120, 100%, 40%);">+ OSMO_ASSERT(osmo_oap_client_handle(state, msg_rx, &msg_tx) < 0);</span><br><span style="color: hsl(120, 100%, 40%);">+ OSMO_ASSERT(state->state == OSMO_OAP_DISABLED);</span><br><span style="color: hsl(120, 100%, 40%);">+ msgb_free(msg_rx);</span><br><span style="color: hsl(120, 100%, 40%);">+ OSMO_ASSERT(!msg_tx);</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ fprintf(stderr, "- invalid client_id and shared secret\n");</span><br><span style="color: hsl(120, 100%, 40%);">+ memset(state, 0, sizeof(*state));</span><br><span style="color: hsl(120, 100%, 40%);">+ config->client_id = 0;</span><br><span style="color: hsl(120, 100%, 40%);">+ config->secret_k_present = 0;</span><br><span style="color: hsl(120, 100%, 40%);">+ config->secret_opc_present = 0;</span><br><span style="color: hsl(120, 100%, 40%);">+ OSMO_ASSERT( osmo_oap_client_init(config, state) == 0 );</span><br><span style="color: hsl(120, 100%, 40%);">+ OSMO_ASSERT(state->state == OSMO_OAP_DISABLED);</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ fprintf(stderr, "- reset state\n");</span><br><span style="color: hsl(120, 100%, 40%);">+ memset(state, 0, sizeof(*state));</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ fprintf(stderr, "- only client_id is invalid\n");</span><br><span style="color: hsl(120, 100%, 40%);">+ config->client_id = 0;</span><br><span style="color: hsl(120, 100%, 40%);">+ config->secret_k_present = 1;</span><br><span style="color: hsl(120, 100%, 40%);">+ config->secret_opc_present = 1;</span><br><span style="color: hsl(120, 100%, 40%);">+ OSMO_ASSERT( osmo_oap_client_init(config, state) == 0 );</span><br><span style="color: hsl(120, 100%, 40%);">+ OSMO_ASSERT(state->state == OSMO_OAP_DISABLED);</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ memset(state, 0, sizeof(*state));</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ fprintf(stderr, "- valid id, but omitted shared_secret (1/2)\n");</span><br><span style="color: hsl(120, 100%, 40%);">+ config->client_id = 12345;</span><br><span style="color: hsl(120, 100%, 40%);">+ config->secret_k_present = 0;</span><br><span style="color: hsl(120, 100%, 40%);">+ config->secret_opc_present = 1;</span><br><span style="color: hsl(120, 100%, 40%);">+ OSMO_ASSERT( osmo_oap_client_init(config, state) == 0 );</span><br><span style="color: hsl(120, 100%, 40%);">+ OSMO_ASSERT(state->state == OSMO_OAP_DISABLED);</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ memset(state, 0, sizeof(*state));</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ fprintf(stderr, "- valid id, but omitted shared_secret (2/2)\n");</span><br><span style="color: hsl(120, 100%, 40%);">+ config->client_id = 12345;</span><br><span style="color: hsl(120, 100%, 40%);">+ config->secret_k_present = 1;</span><br><span style="color: hsl(120, 100%, 40%);">+ config->secret_opc_present = 0;</span><br><span style="color: hsl(120, 100%, 40%);">+ OSMO_ASSERT( osmo_oap_client_init(config, state) == 0 );</span><br><span style="color: hsl(120, 100%, 40%);">+ OSMO_ASSERT(state->state == OSMO_OAP_DISABLED);</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ memset(state, 0, sizeof(*state));</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ fprintf(stderr, "- mint configuration\n");</span><br><span style="color: hsl(120, 100%, 40%);">+ config->client_id = 12345;</span><br><span style="color: hsl(120, 100%, 40%);">+ config->secret_k_present = 1;</span><br><span style="color: hsl(120, 100%, 40%);">+ config->secret_opc_present = 1;</span><br><span style="color: hsl(120, 100%, 40%);">+ /*config->secret_* buffers are still set from the top */</span><br><span style="color: hsl(120, 100%, 40%);">+ OSMO_ASSERT( osmo_oap_client_init(config, state) == 0 );</span><br><span style="color: hsl(120, 100%, 40%);">+ OSMO_ASSERT(state->state == OSMO_OAP_INITIALIZED);</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ fprintf(stderr, "- Missing challenge data\n");</span><br><span style="color: hsl(120, 100%, 40%);">+ memset(&oap_rx, 0, sizeof(oap_rx));</span><br><span style="color: hsl(120, 100%, 40%);">+ oap_rx.message_type = OAP_MSGT_CHALLENGE_REQUEST;</span><br><span style="color: hsl(120, 100%, 40%);">+ oap_rx.rand_present = 0;</span><br><span style="color: hsl(120, 100%, 40%);">+ oap_rx.autn_present = 0;</span><br><span style="color: hsl(120, 100%, 40%);">+ msg_rx = osmo_oap_client_encoded(&oap_rx);</span><br><span style="color: hsl(120, 100%, 40%);">+ OSMO_ASSERT(osmo_oap_client_handle(state, msg_rx, &msg_tx) == -2);</span><br><span style="color: hsl(120, 100%, 40%);">+ msgb_free(msg_rx);</span><br><span style="color: hsl(120, 100%, 40%);">+ OSMO_ASSERT(!msg_tx);</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ fprintf(stderr, "- AUTN missing\n");</span><br><span style="color: hsl(120, 100%, 40%);">+ osmo_hexparse("0102030405060708090a0b0c0d0e0f10",</span><br><span style="color: hsl(120, 100%, 40%);">+ oap_rx.rand, 16);</span><br><span style="color: hsl(120, 100%, 40%);">+ oap_rx.rand_present = 1;</span><br><span style="color: hsl(120, 100%, 40%);">+ msg_rx = osmo_oap_client_encoded(&oap_rx);</span><br><span style="color: hsl(120, 100%, 40%);">+ OSMO_ASSERT(osmo_oap_client_handle(state, msg_rx, &msg_tx) == -2);</span><br><span style="color: hsl(120, 100%, 40%);">+ msgb_free(msg_rx);</span><br><span style="color: hsl(120, 100%, 40%);">+ OSMO_ASSERT(!msg_tx);</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ fprintf(stderr, "- RAND missing\n");</span><br><span style="color: hsl(120, 100%, 40%);">+ oap_rx.rand_present = 0;</span><br><span style="color: hsl(120, 100%, 40%);">+ osmo_hexparse("cec4e3848a33000086781158ca40f136",</span><br><span style="color: hsl(120, 100%, 40%);">+ oap_rx.autn, 16);</span><br><span style="color: hsl(120, 100%, 40%);">+ oap_rx.autn_present = 1;</span><br><span style="color: hsl(120, 100%, 40%);">+ msg_rx = osmo_oap_client_encoded(&oap_rx);</span><br><span style="color: hsl(120, 100%, 40%);">+ OSMO_ASSERT(osmo_oap_client_handle(state, msg_rx, &msg_tx) == -2);</span><br><span style="color: hsl(120, 100%, 40%);">+ msgb_free(msg_rx);</span><br><span style="color: hsl(120, 100%, 40%);">+ OSMO_ASSERT(!msg_tx);</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ fprintf(stderr, "- wrong autn (by one bit)\n");</span><br><span style="color: hsl(120, 100%, 40%);">+ osmo_hexparse("0102030405060708090a0b0c0d0e0f10",</span><br><span style="color: hsl(120, 100%, 40%);">+ oap_rx.rand, 16);</span><br><span style="color: hsl(120, 100%, 40%);">+ osmo_hexparse("dec4e3848a33000086781158ca40f136",</span><br><span style="color: hsl(120, 100%, 40%);">+ oap_rx.autn, 16);</span><br><span style="color: hsl(120, 100%, 40%);">+ oap_rx.rand_present = 1;</span><br><span style="color: hsl(120, 100%, 40%);">+ oap_rx.autn_present = 1;</span><br><span style="color: hsl(120, 100%, 40%);">+ msg_rx = osmo_oap_client_encoded(&oap_rx);</span><br><span style="color: hsl(120, 100%, 40%);">+ OSMO_ASSERT(osmo_oap_client_handle(state, msg_rx, &msg_tx) == -2);</span><br><span style="color: hsl(120, 100%, 40%);">+ msgb_free(msg_rx);</span><br><span style="color: hsl(120, 100%, 40%);">+ OSMO_ASSERT(!msg_tx);</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ fprintf(stderr, "- all data correct\n");</span><br><span style="color: hsl(120, 100%, 40%);">+ osmo_hexparse("cec4e3848a33000086781158ca40f136",</span><br><span style="color: hsl(120, 100%, 40%);">+ oap_rx.autn, 16);</span><br><span style="color: hsl(120, 100%, 40%);">+ msg_rx = osmo_oap_client_encoded(&oap_rx);</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ fprintf(stderr, "- but refuse to evaluate in uninitialized state\n");</span><br><span style="color: hsl(120, 100%, 40%);">+ OSMO_ASSERT(state->state == OSMO_OAP_INITIALIZED);</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ state->state = OSMO_OAP_UNINITIALIZED;</span><br><span style="color: hsl(120, 100%, 40%);">+ OSMO_ASSERT(osmo_oap_client_handle(state, msg_rx, &msg_tx) < 0);</span><br><span style="color: hsl(120, 100%, 40%);">+ OSMO_ASSERT(!msg_tx);</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ state->state = OSMO_OAP_DISABLED;</span><br><span style="color: hsl(120, 100%, 40%);">+ OSMO_ASSERT(osmo_oap_client_handle(state, msg_rx, &msg_tx) < 0);</span><br><span style="color: hsl(120, 100%, 40%);">+ OSMO_ASSERT(!msg_tx);</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ state->state = OSMO_OAP_INITIALIZED;</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ fprintf(stderr, "- now everything is correct\n");</span><br><span style="color: hsl(120, 100%, 40%);">+ /* a successful return value here indicates correct autn */</span><br><span style="color: hsl(120, 100%, 40%);">+ OSMO_ASSERT(osmo_oap_client_handle(state, msg_rx, &msg_tx) == 0);</span><br><span style="color: hsl(120, 100%, 40%);">+ msgb_free(msg_rx);</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ fprintf(stderr, "- Expect the challenge response in msg_tx\n");</span><br><span style="color: hsl(120, 100%, 40%);">+ OSMO_ASSERT(msg_tx);</span><br><span style="color: hsl(120, 100%, 40%);">+ OSMO_ASSERT(osmo_oap_decode(&oap_tx, msg_tx->data, msg_tx->len) == 0);</span><br><span style="color: hsl(120, 100%, 40%);">+ OSMO_ASSERT(oap_tx.message_type == OAP_MSGT_CHALLENGE_RESULT);</span><br><span style="color: hsl(120, 100%, 40%);">+ OSMO_ASSERT(strcmp("e2d05b598c61d9ba",</span><br><span style="color: hsl(120, 100%, 40%);">+ osmo_hexdump_nospc(oap_tx.xres, sizeof(oap_tx.xres)))</span><br><span style="color: hsl(120, 100%, 40%);">+ == 0);</span><br><span style="color: hsl(120, 100%, 40%);">+ OSMO_ASSERT(state->state == OSMO_OAP_SENT_CHALLENGE_RESULT);</span><br><span style="color: hsl(120, 100%, 40%);">+ msgb_free(msg_tx);</span><br><span style="color: hsl(120, 100%, 40%);">+ msg_tx = 0;</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ struct osmo_oap_client_state saved_state = _state;</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ fprintf(stderr, "- Receive registration error for the first time.\n");</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ memset(&oap_rx, 0, sizeof(oap_rx));</span><br><span style="color: hsl(120, 100%, 40%);">+ oap_rx.message_type = OAP_MSGT_REGISTER_ERROR;</span><br><span style="color: hsl(120, 100%, 40%);">+ oap_rx.cause = GMM_CAUSE_PROTO_ERR_UNSPEC;</span><br><span style="color: hsl(120, 100%, 40%);">+ msg_rx = osmo_oap_client_encoded(&oap_rx);</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ OSMO_ASSERT(state->registration_failures == 0);</span><br><span style="color: hsl(120, 100%, 40%);">+ OSMO_ASSERT(osmo_oap_client_handle(state, msg_rx, &msg_tx) == 0);</span><br><span style="color: hsl(120, 100%, 40%);">+ OSMO_ASSERT(state->registration_failures == 1);</span><br><span style="color: hsl(120, 100%, 40%);">+ OSMO_ASSERT(msg_tx);</span><br><span style="color: hsl(120, 100%, 40%);">+ OSMO_ASSERT(osmo_oap_decode(&oap_tx, msg_tx->data, msg_tx->len) == 0);</span><br><span style="color: hsl(120, 100%, 40%);">+ OSMO_ASSERT(oap_tx.message_type == OAP_MSGT_REGISTER_REQUEST);</span><br><span style="color: hsl(120, 100%, 40%);">+ OSMO_ASSERT(state->state == OSMO_OAP_REQUESTED_CHALLENGE);</span><br><span style="color: hsl(120, 100%, 40%);">+ msgb_free(msg_tx);</span><br><span style="color: hsl(120, 100%, 40%);">+ msg_tx = 0;</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ fprintf(stderr, "- Receive registration error for the Nth time.\n");</span><br><span style="color: hsl(120, 100%, 40%);">+ state->registration_failures = 999;</span><br><span style="color: hsl(120, 100%, 40%);">+ OSMO_ASSERT(osmo_oap_client_handle(state, msg_rx, &msg_tx) == -11);</span><br><span style="color: hsl(120, 100%, 40%);">+ OSMO_ASSERT(!msg_tx);</span><br><span style="color: hsl(120, 100%, 40%);">+ OSMO_ASSERT(state->state == OSMO_OAP_INITIALIZED);</span><br><span style="color: hsl(120, 100%, 40%);">+ msgb_free(msg_tx);</span><br><span style="color: hsl(120, 100%, 40%);">+ msg_tx = 0;</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ msgb_free(msg_rx);</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ fprintf(stderr, "- Registration success\n");</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ _state = saved_state;</span><br><span style="color: hsl(120, 100%, 40%);">+ memset(&oap_rx, 0, sizeof(oap_rx));</span><br><span style="color: hsl(120, 100%, 40%);">+ oap_rx.message_type = OAP_MSGT_REGISTER_RESULT;</span><br><span style="color: hsl(120, 100%, 40%);">+ msg_rx = osmo_oap_client_encoded(&oap_rx);</span><br><span style="color: hsl(120, 100%, 40%);">+ OSMO_ASSERT(osmo_oap_client_handle(state, msg_rx, &msg_tx) == 0);</span><br><span style="color: hsl(120, 100%, 40%);">+ OSMO_ASSERT(!msg_tx);</span><br><span style="color: hsl(120, 100%, 40%);">+ OSMO_ASSERT(state->state == OSMO_OAP_REGISTERED);</span><br><span style="color: hsl(120, 100%, 40%);">+ msgb_free(msg_rx);</span><br><span style="color: hsl(120, 100%, 40%);">+}</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+static struct log_info_cat oap_client_test_categories[] = {</span><br><span style="color: hsl(120, 100%, 40%);">+};</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+static struct log_info info = {</span><br><span style="color: hsl(120, 100%, 40%);">+ .cat = oap_client_test_categories,</span><br><span style="color: hsl(120, 100%, 40%);">+ .num_cat = ARRAY_SIZE(oap_client_test_categories),</span><br><span style="color: hsl(120, 100%, 40%);">+};</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+int main(int argc, char **argv)</span><br><span style="color: hsl(120, 100%, 40%);">+{</span><br><span style="color: hsl(120, 100%, 40%);">+ void *ctx = talloc_named_const(NULL, 0, "oap_client_test");</span><br><span style="color: hsl(120, 100%, 40%);">+ msgb_talloc_ctx_init(ctx, 0);</span><br><span style="color: hsl(120, 100%, 40%);">+ osmo_init_logging2(ctx, &info);</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ OSMO_ASSERT(osmo_stderr_target);</span><br><span style="color: hsl(120, 100%, 40%);">+ log_set_use_color(osmo_stderr_target, 0);</span><br><span style="color: hsl(120, 100%, 40%);">+ log_set_print_timestamp(osmo_stderr_target, 0);</span><br><span style="color: hsl(120, 100%, 40%);">+ log_set_print_filename(osmo_stderr_target, 0);</span><br><span style="color: hsl(120, 100%, 40%);">+ log_set_print_category(osmo_stderr_target, 1);</span><br><span style="color: hsl(120, 100%, 40%);">+ log_parse_category_mask(osmo_stderr_target, "DLOAP,1");</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ test_oap_api();</span><br><span style="color: hsl(120, 100%, 40%);">+ printf("Done\n");</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ return 0;</span><br><span style="color: hsl(120, 100%, 40%);">+}</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span>diff --git a/tests/oap/oap_client_test.err b/tests/oap/oap_client_test.err</span><br><span>new file mode 100644</span><br><span>index 0000000..62ddc9e</span><br><span>--- /dev/null</span><br><span>+++ b/tests/oap/oap_client_test.err</span><br><span>@@ -0,0 +1,35 @@</span><br><span style="color: hsl(120, 100%, 40%);">+- make sure filling with zeros means uninitialized</span><br><span style="color: hsl(120, 100%, 40%);">+- reject messages in uninitialized state</span><br><span style="color: hsl(120, 100%, 40%);">+DLOAP Received OAP message 5, but the OAP client is not initialized</span><br><span style="color: hsl(120, 100%, 40%);">+- NULL config should disable</span><br><span style="color: hsl(120, 100%, 40%);">+- reject messages in disabled state</span><br><span style="color: hsl(120, 100%, 40%);">+DLOAP Received OAP message 5, but the OAP client is disabled</span><br><span style="color: hsl(120, 100%, 40%);">+- invalid client_id and shared secret</span><br><span style="color: hsl(120, 100%, 40%);">+- reset state</span><br><span style="color: hsl(120, 100%, 40%);">+- only client_id is invalid</span><br><span style="color: hsl(120, 100%, 40%);">+- valid id, but omitted shared_secret (1/2)</span><br><span style="color: hsl(120, 100%, 40%);">+DLOAP OAP: client ID set, but secret K missing.</span><br><span style="color: hsl(120, 100%, 40%);">+- valid id, but omitted shared_secret (2/2)</span><br><span style="color: hsl(120, 100%, 40%);">+DLOAP OAP: client ID set, but secret OPC missing.</span><br><span style="color: hsl(120, 100%, 40%);">+- mint configuration</span><br><span style="color: hsl(120, 100%, 40%);">+- Missing challenge data</span><br><span style="color: hsl(120, 100%, 40%);">+DLOAP OAP challenge incomplete (rand_present: 0, autn_present: 0)</span><br><span style="color: hsl(120, 100%, 40%);">+- AUTN missing</span><br><span style="color: hsl(120, 100%, 40%);">+DLOAP OAP challenge incomplete (rand_present: 1, autn_present: 0)</span><br><span style="color: hsl(120, 100%, 40%);">+- RAND missing</span><br><span style="color: hsl(120, 100%, 40%);">+DLOAP OAP challenge incomplete (rand_present: 0, autn_present: 1)</span><br><span style="color: hsl(120, 100%, 40%);">+- wrong autn (by one bit)</span><br><span style="color: hsl(120, 100%, 40%);">+DLOAP OAP: AUTN mismatch!</span><br><span style="color: hsl(120, 100%, 40%);">+DLOAP OAP: AUTN from server: dec4e3848a33000086781158ca40f136</span><br><span style="color: hsl(120, 100%, 40%);">+DLOAP OAP: AUTN expected: cec4e3848a33000086781158ca40f136</span><br><span style="color: hsl(120, 100%, 40%);">+- all data correct</span><br><span style="color: hsl(120, 100%, 40%);">+- but refuse to evaluate in uninitialized state</span><br><span style="color: hsl(120, 100%, 40%);">+DLOAP Received OAP message 8, but the OAP client is not initialized</span><br><span style="color: hsl(120, 100%, 40%);">+DLOAP Received OAP message 8, but the OAP client is disabled</span><br><span style="color: hsl(120, 100%, 40%);">+- now everything is correct</span><br><span style="color: hsl(120, 100%, 40%);">+- Expect the challenge response in msg_tx</span><br><span style="color: hsl(120, 100%, 40%);">+- Receive registration error for the first time.</span><br><span style="color: hsl(120, 100%, 40%);">+DLOAP OAP registration failed</span><br><span style="color: hsl(120, 100%, 40%);">+- Receive registration error for the Nth time.</span><br><span style="color: hsl(120, 100%, 40%);">+DLOAP OAP registration failed</span><br><span style="color: hsl(120, 100%, 40%);">+- Registration success</span><br><span>diff --git a/tests/oap/oap_client_test.ok b/tests/oap/oap_client_test.ok</span><br><span>new file mode 100644</span><br><span>index 0000000..59108a7</span><br><span>--- /dev/null</span><br><span>+++ b/tests/oap/oap_client_test.ok</span><br><span>@@ -0,0 +1,2 @@</span><br><span style="color: hsl(120, 100%, 40%);">+Testing OAP API</span><br><span style="color: hsl(120, 100%, 40%);">+Done</span><br><span>diff --git a/tests/testsuite.at b/tests/testsuite.at</span><br><span>index 43b58e8..a1cf98a 100644</span><br><span>--- a/tests/testsuite.at</span><br><span>+++ b/tests/testsuite.at</span><br><span>@@ -274,6 +274,13 @@</span><br><span> AT_CHECK([$abs_top_builddir/tests/oap/oap_test], [0], [expout], [experr])</span><br><span> AT_CLEANUP</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+AT_SETUP([oap_client])</span><br><span style="color: hsl(120, 100%, 40%);">+AT_KEYWORDS([oap_client])</span><br><span style="color: hsl(120, 100%, 40%);">+cat $abs_srcdir/oap/oap_client_test.ok > expout</span><br><span style="color: hsl(120, 100%, 40%);">+cat $abs_srcdir/oap/oap_client_test.err > experr</span><br><span style="color: hsl(120, 100%, 40%);">+AT_CHECK([$abs_top_builddir/tests/oap/oap_client_test], [0], [expout], [experr])</span><br><span style="color: hsl(120, 100%, 40%);">+AT_CLEANUP</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> AT_SETUP([socket])</span><br><span> AT_KEYWORDS([socket])</span><br><span> cat $abs_srcdir/socket/socket_test.ok > expout</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/10258">change 10258</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/10258"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: libosmocore </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: merged </div>
<div style="display:none"> Gerrit-Change-Id: I9d64e10b4bacac9b530cf077841bad762fc6d558 </div>
<div style="display:none"> Gerrit-Change-Number: 10258 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: Harald Welte <laforge@gnumonks.org> </div>
<div style="display:none"> Gerrit-Reviewer: Harald Welte <laforge@gnumonks.org> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>