<p>Harald Welte <strong>merged</strong> this change.</p><p><a href="https://gerrit.osmocom.org/10031">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">ctrl/vty: fsm: use correct element when iterating over fsm->proc.children<br><br>Fixes crashes when using vty `show fsm-instances all`<br>when fsm children are present.<br><br>Change-Id: I4ae0bee7f7f57ec6675cfb52ca6cf0d523d15362<br>---<br>M src/ctrl/fsm_ctrl_commands.c<br>M src/vty/fsm_vty.c<br>2 files changed, 2 insertions(+), 2 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/ctrl/fsm_ctrl_commands.c b/src/ctrl/fsm_ctrl_commands.c</span><br><span>index 3c7e1bd..c93d3a5 100644</span><br><span>--- a/src/ctrl/fsm_ctrl_commands.c</span><br><span>+++ b/src/ctrl/fsm_ctrl_commands.c</span><br><span>@@ -156,7 +156,7 @@</span><br><span>        if (fi->proc.parent)</span><br><span>              cmd->reply = talloc_asprintf_append(cmd->reply, ",parent='%s'", fi->proc.parent->name);</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-       llist_for_each_entry(child, &fi->proc.children, list) {</span><br><span style="color: hsl(120, 100%, 40%);">+        llist_for_each_entry(child, &fi->proc.children, proc.child) {</span><br><span>                 cmd->reply = talloc_asprintf_append(cmd->reply, ",child='%s'", child->name);</span><br><span>      }</span><br><span> </span><br><span>diff --git a/src/vty/fsm_vty.c b/src/vty/fsm_vty.c</span><br><span>index 8628d15..9bde241 100644</span><br><span>--- a/src/vty/fsm_vty.c</span><br><span>+++ b/src/vty/fsm_vty.c</span><br><span>@@ -102,7 +102,7 @@</span><br><span>                                             fsmi->proc.parent_term_event),</span><br><span>                        VTY_NEWLINE);</span><br><span>        }</span><br><span style="color: hsl(0, 100%, 40%);">-       llist_for_each_entry(child, &fsmi->proc.children, list) {</span><br><span style="color: hsl(120, 100%, 40%);">+      llist_for_each_entry(child, &fsmi->proc.children, proc.child) {</span><br><span>               vty_out(vty, " Child: '%s'%s", child->name, VTY_NEWLINE);</span><br><span>       }</span><br><span> }</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/10031">change 10031</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/10031"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: libosmocore </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: merged </div>
<div style="display:none"> Gerrit-Change-Id: I4ae0bee7f7f57ec6675cfb52ca6cf0d523d15362 </div>
<div style="display:none"> Gerrit-Change-Number: 10031 </div>
<div style="display:none"> Gerrit-PatchSet: 3 </div>
<div style="display:none"> Gerrit-Owner: lynxis lazus <lynxis@fe80.eu> </div>
<div style="display:none"> Gerrit-Reviewer: Harald Welte <laforge@gnumonks.org> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr@sysmocom.de> </div>