<p>Harald Welte <strong>merged</strong> this change.</p><p><a href="https://gerrit.osmocom.org/10219">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">gsm0480: Factor out msgb allocation helper function<br><br>Change-Id: If25b467481023eadaaf3f78157eceff4b81d24d2<br>---<br>M include/osmocom/gsm/gsm0480.h<br>M src/gsm/gsm0480.c<br>M src/gsm/libosmogsm.map<br>3 files changed, 9 insertions(+), 1 deletion(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/include/osmocom/gsm/gsm0480.h b/include/osmocom/gsm/gsm0480.h</span><br><span>index e928d83..6a596ea 100644</span><br><span>--- a/include/osmocom/gsm/gsm0480.h</span><br><span>+++ b/include/osmocom/gsm/gsm0480.h</span><br><span>@@ -108,6 +108,8 @@</span><br><span> int gsm0480_decode_ss_request(const struct gsm48_hdr *hdr, uint16_t len,</span><br><span>                                struct ss_request *request);</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+struct msgb *gsm0480_msgb_alloc_name(const char *name);</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> struct msgb *gsm0480_create_ussd_resp(uint8_t invoke_id, uint8_t trans_id, const char *text);</span><br><span> struct msgb *gsm0480_create_unstructuredSS_Notify(int alertPattern, const char *text);</span><br><span> struct msgb *gsm0480_create_notifySS(const char *text);</span><br><span>diff --git a/src/gsm/gsm0480.c b/src/gsm/gsm0480.c</span><br><span>index 165b309..ac0fa12 100644</span><br><span>--- a/src/gsm/gsm0480.c</span><br><span>+++ b/src/gsm/gsm0480.c</span><br><span>@@ -787,13 +787,18 @@</span><br><span>   return rc;</span><br><span> }</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+struct msgb *gsm0480_msgb_alloc_name(const char *name)</span><br><span style="color: hsl(120, 100%, 40%);">+{</span><br><span style="color: hsl(120, 100%, 40%);">+        return msgb_alloc_headroom(1024, 128, name);</span><br><span style="color: hsl(120, 100%, 40%);">+}</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> struct msgb *gsm0480_create_ussd_resp(uint8_t invoke_id, uint8_t trans_id, const char *text)</span><br><span> {</span><br><span>       struct msgb *msg;</span><br><span>    uint8_t *ptr8;</span><br><span>       int response_len;</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-   msg = msgb_alloc_headroom(1024, 128, "GSM 04.80");</span><br><span style="color: hsl(120, 100%, 40%);">+  msg = gsm0480_msgb_alloc_name("TS 04.80 USSD Resp");</span><br><span>       if (!msg)</span><br><span>            return NULL;</span><br><span> </span><br><span>diff --git a/src/gsm/libosmogsm.map b/src/gsm/libosmogsm.map</span><br><span>index 3b403c2..312c990 100644</span><br><span>--- a/src/gsm/libosmogsm.map</span><br><span>+++ b/src/gsm/libosmogsm.map</span><br><span>@@ -97,6 +97,7 @@</span><br><span> gsm0480_wrap_invoke;</span><br><span> gsm0480_comp_type_names;</span><br><span> gsm0480_op_code_names;</span><br><span style="color: hsl(120, 100%, 40%);">+gsm0480_msgb_alloc_name;</span><br><span> </span><br><span> gsm0502_calc_paging_group;</span><br><span> </span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/10219">change 10219</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/10219"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: libosmocore </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: merged </div>
<div style="display:none"> Gerrit-Change-Id: If25b467481023eadaaf3f78157eceff4b81d24d2 </div>
<div style="display:none"> Gerrit-Change-Number: 10219 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: Harald Welte <laforge@gnumonks.org> </div>
<div style="display:none"> Gerrit-Reviewer: Harald Welte <laforge@gnumonks.org> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>