<p>Kévin Redon has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/10212">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">sniff: fix ATR checksum calculation<br><br>this issue also cause the sent ATR to be empty<br><br>Change-Id: I6edff7aeb3185c835656acde75886fb6c90c0582<br>---<br>M firmware/libcommon/source/sniffer.c<br>1 file changed, 1 insertion(+), 1 deletion(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/simtrace2 refs/changes/12/10212/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/firmware/libcommon/source/sniffer.c b/firmware/libcommon/source/sniffer.c</span><br><span>index 5cf96fd..c57877f 100644</span><br><span>--- a/firmware/libcommon/source/sniffer.c</span><br><span>+++ b/firmware/libcommon/source/sniffer.c</span><br><span>@@ -505,7 +505,7 @@</span><br><span>          if (ATR_S_WAIT_TCK == atr_state) {</span><br><span>                   uint8_t ui;</span><br><span>                  uint8_t checksum = 0;</span><br><span style="color: hsl(0, 100%, 40%);">-                   for (ui = 1; ui < atr_i; atr_i++) {</span><br><span style="color: hsl(120, 100%, 40%);">+                        for (ui = 1; ui < atr_i; ui++) {</span><br><span>                          checksum ^= atr[ui];</span><br><span>                         }</span><br><span>                    if (checksum) {</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/10212">change 10212</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/10212"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: simtrace2 </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I6edff7aeb3185c835656acde75886fb6c90c0582 </div>
<div style="display:none"> Gerrit-Change-Number: 10212 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Kévin Redon <kredon@sysmocom.de> </div>